From 43d8fcf33aeec2b6c585a19f7f1e3cadeb50b182 Mon Sep 17 00:00:00 2001 From: Lukasz Date: Wed, 17 Jul 2019 11:33:26 -0400 Subject: [PATCH 1/5] Fix refresh param on getIdToken iOS. --- packages/firebase_auth/ios/Classes/FirebaseAuthPlugin.m | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/firebase_auth/ios/Classes/FirebaseAuthPlugin.m b/packages/firebase_auth/ios/Classes/FirebaseAuthPlugin.m index 90dddc04ef31..bbe6f8c4f283 100644 --- a/packages/firebase_auth/ios/Classes/FirebaseAuthPlugin.m +++ b/packages/firebase_auth/ios/Classes/FirebaseAuthPlugin.m @@ -198,8 +198,10 @@ - (void)handleMethodCall:(FlutterMethodCall *)call result:(FlutterResult)result [self sendResult:result forObject:nil error:nil]; } } else if ([@"getIdToken" isEqualToString:call.method]) { + NSDictionary *args = call.arguments; + BOOL refresh = [args objectForKey:@"refresh"]; [[self getAuth:call.arguments].currentUser - getIDTokenForcingRefresh:YES + getIDTokenForcingRefresh:refresh completion:^(NSString *_Nullable token, NSError *_Nullable error) { [self sendResult:result forObject:token error:error]; }]; From 51f7f1c6f072f19a9e25cab0e3a6eaeed49bef9f Mon Sep 17 00:00:00 2001 From: Lukasz Date: Wed, 17 Jul 2019 11:38:22 -0400 Subject: [PATCH 2/5] Update authors. --- AUTHORS | 1 + 1 file changed, 1 insertion(+) diff --git a/AUTHORS b/AUTHORS index 6650f7423cb3..31a8f62280e0 100644 --- a/AUTHORS +++ b/AUTHORS @@ -40,3 +40,4 @@ Jonathan Younger Jose Sanchez Debkanchan Samadder Audrius Karosevicius +Lukasz Piliszczuk \ No newline at end of file From 8cb04e930be61827abca7baa4e229a541fbbd6bb Mon Sep 17 00:00:00 2001 From: Lukasz Date: Wed, 17 Jul 2019 11:43:41 -0400 Subject: [PATCH 3/5] Bump pubspec version. --- packages/firebase_auth/pubspec.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/firebase_auth/pubspec.yaml b/packages/firebase_auth/pubspec.yaml index 3b5904d0a0e9..18bca1002fb4 100755 --- a/packages/firebase_auth/pubspec.yaml +++ b/packages/firebase_auth/pubspec.yaml @@ -4,7 +4,7 @@ description: Flutter plugin for Firebase Auth, enabling Android and iOS like Google, Facebook and Twitter. author: Flutter Team homepage: https://github.com/flutter/plugins/tree/master/packages/firebase_auth -version: "0.11.1+10" +version: "0.11.1+11" flutter: plugin: From 393962e7e70f56073f40c9617b42ac2a2cdf6b16 Mon Sep 17 00:00:00 2001 From: Lukasz Date: Wed, 17 Jul 2019 11:44:46 -0400 Subject: [PATCH 4/5] Update changelog. --- packages/firebase_auth/CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/firebase_auth/CHANGELOG.md b/packages/firebase_auth/CHANGELOG.md index 8a9adcfb9b3e..edc3632b90bf 100644 --- a/packages/firebase_auth/CHANGELOG.md +++ b/packages/firebase_auth/CHANGELOG.md @@ -1,3 +1,7 @@ +## 0.11.1+11 + +* On iOS, `getIdToken()` now properly takes in account the refresh parameter. It was previously ignored, and always set to `true`. + ## 0.11.1+10 * On Android, `providerData` now includes `UserInfo` for the phone authentication provider. From 7597834e0c06f481d9f2fd7c4665413718d38775 Mon Sep 17 00:00:00 2001 From: Collin Jackson Date: Wed, 17 Jul 2019 13:53:00 -0700 Subject: [PATCH 5/5] Update CHANGELOG.md --- packages/firebase_auth/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/firebase_auth/CHANGELOG.md b/packages/firebase_auth/CHANGELOG.md index edc3632b90bf..1839016e5267 100644 --- a/packages/firebase_auth/CHANGELOG.md +++ b/packages/firebase_auth/CHANGELOG.md @@ -1,6 +1,6 @@ ## 0.11.1+11 -* On iOS, `getIdToken()` now properly takes in account the refresh parameter. It was previously ignored, and always set to `true`. +* On iOS, `getIdToken()` now uses the `refresh` parameter instead of always using `true`. ## 0.11.1+10