From e5941c638b522cc617fb0d707598348acfccdd06 Mon Sep 17 00:00:00 2001 From: creativecreatorormaybenot <19204050+creativecreatorormaybenot@users.noreply.github.com> Date: Fri, 19 Jul 2019 13:30:31 +0000 Subject: [PATCH 1/4] explicit type for invokeMethod --- packages/share/CHANGELOG.md | 4 ++++ packages/share/lib/share.dart | 5 +---- packages/share/pubspec.yaml | 2 +- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/packages/share/CHANGELOG.md b/packages/share/CHANGELOG.md index 38bd86675e98..b03a584ea6a9 100644 --- a/packages/share/CHANGELOG.md +++ b/packages/share/CHANGELOG.md @@ -1,3 +1,7 @@ +## 0.6.2+1 + +* Specify explicit type for `invokeMethod`. + ## 0.6.2 * Add optional subject to fill email subject in case user selects email app. diff --git a/packages/share/lib/share.dart b/packages/share/lib/share.dart index 7bbaae827fec..3707a2f7c704 100644 --- a/packages/share/lib/share.dart +++ b/packages/share/lib/share.dart @@ -49,9 +49,6 @@ class Share { params['originHeight'] = sharePositionOrigin.height; } - // TODO(amirh): remove this on when the invokeMethod update makes it to stable Flutter. - // https://github.com/flutter/flutter/issues/26431 - // ignore: strong_mode_implicit_dynamic_method - return channel.invokeMethod('share', params); + return channel.invokeMethod('share', params); } } diff --git a/packages/share/pubspec.yaml b/packages/share/pubspec.yaml index ba36708478df..95a3b4cff76f 100644 --- a/packages/share/pubspec.yaml +++ b/packages/share/pubspec.yaml @@ -3,7 +3,7 @@ description: Flutter plugin for sharing content via the platform share UI, using the ACTION_SEND intent on Android and UIActivityViewController on iOS. author: Flutter Team homepage: https://github.com/flutter/plugins/tree/master/packages/share -version: 0.6.2 +version: 0.6.2+1 flutter: plugin: From c07536c1dbf0030b8a6f9f7d4a254791ba38bef4 Mon Sep 17 00:00:00 2001 From: creativecreatorormaybenot <19204050+creativecreatorormaybenot@users.noreply.github.com> Date: Fri, 19 Jul 2019 14:05:08 +0000 Subject: [PATCH 2/4] fix tests + const Rect --- packages/share/CHANGELOG.md | 1 + packages/share/test/share_test.dart | 15 ++++----------- 2 files changed, 5 insertions(+), 11 deletions(-) diff --git a/packages/share/CHANGELOG.md b/packages/share/CHANGELOG.md index b03a584ea6a9..30c69531c50f 100644 --- a/packages/share/CHANGELOG.md +++ b/packages/share/CHANGELOG.md @@ -1,6 +1,7 @@ ## 0.6.2+1 * Specify explicit type for `invokeMethod`. +* Use `const` for `Rect`. ## 0.6.2 diff --git a/packages/share/test/share_test.dart b/packages/share/test/share_test.dart index b7ca6a60c1d7..275c052d7264 100644 --- a/packages/share/test/share_test.dart +++ b/packages/share/test/share_test.dart @@ -17,10 +17,8 @@ void main() { mockChannel = MockMethodChannel(); // Re-pipe to mockito for easier verifies. Share.channel.setMockMethodCallHandler((MethodCall call) async { - // TODO(amirh): remove this on when the invokeMethod update makes it to stable Flutter. - // https://github.com/flutter/flutter/issues/26431 - // ignore: strong_mode_implicit_dynamic_method - mockChannel.invokeMethod(call.method, call.arguments); + // The explicit type can be void as the only method call has a return type of void. + mockChannel.invokeMethod(call.method, call.arguments); }); }); @@ -44,14 +42,9 @@ void main() { await Share.share( 'some text to share', subject: 'some subject to share', - // TODO(jackson): Use const Rect when available in minimum Flutter SDK - // ignore: prefer_const_constructors - sharePositionOrigin: Rect.fromLTWH(1.0, 2.0, 3.0, 4.0), + sharePositionOrigin: const Rect.fromLTWH(1.0, 2.0, 3.0, 4.0), ); - // TODO(amirh): remove this on when the invokeMethod update makes it to stable Flutter. - // https://github.com/flutter/flutter/issues/26431 - // ignore: strong_mode_implicit_dynamic_method - verify(mockChannel.invokeMethod('share', { + verify(mockChannel.invokeMethod('share', { 'text': 'some text to share', 'subject': 'some subject to share', 'originX': 1.0, From b0f300a7cce596a587f24af4111488beb951f1d5 Mon Sep 17 00:00:00 2001 From: Collin Jackson Date: Sat, 20 Jul 2019 09:55:25 -0700 Subject: [PATCH 3/4] Update pubspec.yaml --- packages/share/pubspec.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/share/pubspec.yaml b/packages/share/pubspec.yaml index 95a3b4cff76f..a051b4480eaa 100644 --- a/packages/share/pubspec.yaml +++ b/packages/share/pubspec.yaml @@ -24,4 +24,4 @@ dev_dependencies: environment: sdk: ">=2.0.0-dev.28.0 <3.0.0" - flutter: ">=0.1.4 <2.0.0" + flutter: ">=1.6.0 <2.0.0" From 84bc178257dac357a17167121a772fc8eb64b7de Mon Sep 17 00:00:00 2001 From: Collin Jackson Date: Sat, 20 Jul 2019 09:56:20 -0700 Subject: [PATCH 4/4] Update CHANGELOG.md --- packages/share/CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/share/CHANGELOG.md b/packages/share/CHANGELOG.md index 30c69531c50f..b2567e4e096c 100644 --- a/packages/share/CHANGELOG.md +++ b/packages/share/CHANGELOG.md @@ -2,6 +2,7 @@ * Specify explicit type for `invokeMethod`. * Use `const` for `Rect`. +* Updated minimum Flutter SDK to 1.6.0. ## 0.6.2