From f68b62835fe176bed3f58ea3b1f55eb38d18e880 Mon Sep 17 00:00:00 2001 From: David Berroa Date: Sun, 21 Jul 2019 18:46:23 -0400 Subject: [PATCH 01/13] Allow use emulator functions --- .../cloudfunctions/CloudFunctionsPlugin.java | 4 ++++ .../ios/Classes/CloudFunctionsPlugin.m | 4 ++++ .../lib/src/cloud_functions.dart | 15 +++++++++++++-- .../cloud_functions/lib/src/https_callable.dart | 1 + .../test/cloud_functions_test.dart | 17 +++++++++++++++++ 5 files changed, 39 insertions(+), 2 deletions(-) diff --git a/packages/cloud_functions/android/src/main/java/io/flutter/plugins/firebase/cloudfunctions/CloudFunctionsPlugin.java b/packages/cloud_functions/android/src/main/java/io/flutter/plugins/firebase/cloudfunctions/CloudFunctionsPlugin.java index 81dfc98e6a95..daeedd763743 100644 --- a/packages/cloud_functions/android/src/main/java/io/flutter/plugins/firebase/cloudfunctions/CloudFunctionsPlugin.java +++ b/packages/cloud_functions/android/src/main/java/io/flutter/plugins/firebase/cloudfunctions/CloudFunctionsPlugin.java @@ -38,12 +38,16 @@ public void onMethodCall(MethodCall call, final Result result) { String appName = call.argument("app"); FirebaseApp app = FirebaseApp.getInstance(appName); String region = call.argument("region"); + String origin = call.argument("origin"); FirebaseFunctions functions; if (region != null) { functions = FirebaseFunctions.getInstance(app, region); } else { functions = FirebaseFunctions.getInstance(app); } + if (origin != null) { + functions.useFunctionsEmulator(origin); + } HttpsCallableReference httpsCallableReference = functions.getHttpsCallable(functionName); Number timeoutMilliseconds = call.argument("timeoutMilliseconds"); if (timeoutMilliseconds != null) { diff --git a/packages/cloud_functions/ios/Classes/CloudFunctionsPlugin.m b/packages/cloud_functions/ios/Classes/CloudFunctionsPlugin.m index cdeaf53debfb..56d6df13dfef 100644 --- a/packages/cloud_functions/ios/Classes/CloudFunctionsPlugin.m +++ b/packages/cloud_functions/ios/Classes/CloudFunctionsPlugin.m @@ -44,6 +44,7 @@ - (void)handleMethodCall:(FlutterMethodCall *)call result:(FlutterResult)result NSObject *parameters = call.arguments[@"parameters"]; NSString *appName = call.arguments[@"app"]; NSString *region = call.arguments[@"region"]; + NSString *origin = call.arguments[@"origin"]; NSNumber *timeoutMicroseconds = call.arguments[@"timeoutMicroseconds"]; FIRApp *app = [FIRApp appNamed:appName]; FIRFunctions *functions; @@ -52,6 +53,9 @@ - (void)handleMethodCall:(FlutterMethodCall *)call result:(FlutterResult)result } else { functions = [FIRFunctions functionsForApp:app]; } + if (origin != nil && origin != (id)[NSNull null]) { + [functions useFunctionsEmulator:origin]; + } FIRHTTPSCallable *function = [functions HTTPSCallableWithName:functionName]; if (timeoutMicroseconds != nil && timeoutMicroseconds != [NSNull null]) { [function setTimeoutInterval:(NSTimeInterval)timeoutMicroseconds.doubleValue / 1000000]; diff --git a/packages/cloud_functions/lib/src/cloud_functions.dart b/packages/cloud_functions/lib/src/cloud_functions.dart index 03c1705efa53..08711d5dc5ed 100644 --- a/packages/cloud_functions/lib/src/cloud_functions.dart +++ b/packages/cloud_functions/lib/src/cloud_functions.dart @@ -16,9 +16,10 @@ class CloudFunctionsException implements Exception { /// /// You can get an instance by calling [CloudFunctions.instance]. class CloudFunctions { - CloudFunctions({FirebaseApp app, String region}) + CloudFunctions({FirebaseApp app, String region, String origin}) : _app = app ?? FirebaseApp.instance, - _region = region; + _region = region, + _origin = origin; @visibleForTesting static const MethodChannel channel = MethodChannel('cloud_functions'); @@ -31,6 +32,8 @@ class CloudFunctions { final String _region; + String _origin; + /// Gets an instance of a Callable HTTPS trigger in Cloud Functions. /// /// Can then be executed by calling `call()` on it. @@ -39,4 +42,12 @@ class CloudFunctions { HttpsCallable getHttpsCallable({@required String functionName}) { return HttpsCallable._(this, functionName); } + + /// Changes this instance to point to a Cloud Functions emulator running locally. + /// + /// @param origin The origin of the local emulator, such as "//10.0.2.2:5005". + CloudFunctions useEmulatorFunctions({@required String origin}) { + _origin = origin; + return this; + } } diff --git a/packages/cloud_functions/lib/src/https_callable.dart b/packages/cloud_functions/lib/src/https_callable.dart index 09a8f578596f..6ae34dbf73f5 100644 --- a/packages/cloud_functions/lib/src/https_callable.dart +++ b/packages/cloud_functions/lib/src/https_callable.dart @@ -34,6 +34,7 @@ class HttpsCallable { .invokeMethod('CloudFunctions#call', { 'app': _cloudFunctions._app.name, 'region': _cloudFunctions._region, + 'origin': _cloudFunctions._origin, 'timeoutMicroseconds': timeout?.inMicroseconds, 'functionName': _functionName, 'parameters': parameters, diff --git a/packages/cloud_functions/test/cloud_functions_test.dart b/packages/cloud_functions/test/cloud_functions_test.dart index 10cb74ae02a6..f9f477568597 100644 --- a/packages/cloud_functions/test/cloud_functions_test.dart +++ b/packages/cloud_functions/test/cloud_functions_test.dart @@ -38,6 +38,10 @@ void main() { await callable.call({ 'quux': 'quuz', }); + await CloudFunctions.instance + .useEmulatorFunctions(origin: 'http://localhost:5001') + .getHttpsCallable(functionName: 'bez') + .call(); expect( log, [ @@ -46,6 +50,7 @@ void main() { arguments: { 'app': '[DEFAULT]', 'region': null, + 'origin': null, 'functionName': 'baz', 'timeoutMicroseconds': null, 'parameters': null, @@ -56,11 +61,23 @@ void main() { arguments: { 'app': '1337', 'region': 'space', + 'origin': null, 'functionName': 'qux', 'timeoutMicroseconds': (const Duration(days: 300)).inMicroseconds, 'parameters': {'quux': 'quuz'}, }, ), + isMethodCall( + 'CloudFunctions#call', + arguments: { + 'app': '[DEFAULT]', + 'region': null, + 'origin': 'http://localhost:5001', + 'functionName': 'bez', + 'timeoutMicroseconds': null, + 'parameters': null, + }, + ), ], ); }); From 7143c48ea515e6e7a626501805b1137adc21f453 Mon Sep 17 00:00:00 2001 From: David Berroa Date: Sun, 21 Jul 2019 18:59:45 -0400 Subject: [PATCH 02/13] updated CHANGELOG.md to add a description of the change --- packages/cloud_functions/CHANGELOG.md | 60 ++++++++++++++------------- 1 file changed, 32 insertions(+), 28 deletions(-) diff --git a/packages/cloud_functions/CHANGELOG.md b/packages/cloud_functions/CHANGELOG.md index 3e8796b82d1a..2c838c111d83 100644 --- a/packages/cloud_functions/CHANGELOG.md +++ b/packages/cloud_functions/CHANGELOG.md @@ -1,59 +1,63 @@ +## 0.4.0+3 + +- Allow use cloud functions locally. + ## 0.4.0+2 -* Automatically use version from pubspec.yaml when reporting usage to Firebase. +- Automatically use version from pubspec.yaml when reporting usage to Firebase. ## 0.4.0+1 -* Remove reference to unused header file. +- Remove reference to unused header file. ## 0.4.0 -* Removed unused `parameters` param from `getHttpsCallable`. +- Removed unused `parameters` param from `getHttpsCallable`. ## 0.3.0+1 -* Update iOS dependencies to latest. +- Update iOS dependencies to latest. ## 0.3.0 -* Update Android dependencies to latest. +- Update Android dependencies to latest. ## 0.2.0+1 -* Removed flaky timeout test. +- Removed flaky timeout test. ## 0.2.0 -* **Breaking change**. Updated Dart API to replace `call` with `getHttpsCallable`. -* Added support for timeouts. -* Additional integration testing. +- **Breaking change**. Updated Dart API to replace `call` with `getHttpsCallable`. +- Added support for timeouts. +- Additional integration testing. ## 0.1.2+1 -* Added a driver test. +- Added a driver test. ## 0.1.2 -* Specifying a version for Cloud Functions CocoaPod dependency to prevent build errors on iOS. -* Fix on iOS when using a null region. -* Upgrade the firebase_core dependency of the example app. +- Specifying a version for Cloud Functions CocoaPod dependency to prevent build errors on iOS. +- Fix on iOS when using a null region. +- Upgrade the firebase_core dependency of the example app. ## 0.1.1+1 -* Log messages about automatic configuration of the default app are now less confusing. +- Log messages about automatic configuration of the default app are now less confusing. ## 0.1.1 -* Support for regions and multiple apps +- Support for regions and multiple apps ## 0.1.0+1 -* Log a more detailed warning at build time about the previous AndroidX +- Log a more detailed warning at build time about the previous AndroidX migration. ## 0.1.0 -* **Breaking change**. Migrate from the deprecated original Android Support +- **Breaking change**. Migrate from the deprecated original Android Support Library to AndroidX. This shouldn't result in any functional changes, but it requires any Android apps using this plugin to [also migrate](https://developer.android.com/jetpack/androidx/migrate) if they're @@ -61,35 +65,35 @@ ## 0.0.5 -* Set iOS deployment target to 8.0 (minimum supported by both Firebase SDKs and Flutter), fixes compilation errors. -* Fixes null pointer error when callable function fails with exception (iOS). +- Set iOS deployment target to 8.0 (minimum supported by both Firebase SDKs and Flutter), fixes compilation errors. +- Fixes null pointer error when callable function fails with exception (iOS). ## 0.0.4+1 -* Bump Android dependencies to latest. +- Bump Android dependencies to latest. ## 0.0.4 -* Fixed podspec to use static_framework +- Fixed podspec to use static_framework ## 0.0.3 -* Added missing dependency on meta package. +- Added missing dependency on meta package. ## 0.0.2 -* Bump Android and Firebase dependency versions. +- Bump Android and Firebase dependency versions. ## 0.0.1 -* The Cloud Functions for Firebase client SDKs let you call functions +- The Cloud Functions for Firebase client SDKs let you call functions directly from a Firebase app. This plugin exposes this ability to Flutter apps. [Callable functions](https://firebase.google.com/docs/functions/callable) are similar to other HTTP functions, with these additional features: - - With callables, Firebase Authentication and FCM tokens are - automatically included in requests. - - The functions.https.onCall trigger automatically deserializes - the request body and validates auth tokens. + - With callables, Firebase Authentication and FCM tokens are + automatically included in requests. + - The functions.https.onCall trigger automatically deserializes + the request body and validates auth tokens. From cf24c8fd829c5550f944d637880a97d91c7a4cb8 Mon Sep 17 00:00:00 2001 From: David Berroa Date: Sun, 21 Jul 2019 19:00:03 -0400 Subject: [PATCH 03/13] updated pubspec.yaml with an appropriate new version --- packages/cloud_functions/pubspec.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/cloud_functions/pubspec.yaml b/packages/cloud_functions/pubspec.yaml index dd6d6e0927c4..f14508b0cedc 100644 --- a/packages/cloud_functions/pubspec.yaml +++ b/packages/cloud_functions/pubspec.yaml @@ -1,6 +1,6 @@ name: cloud_functions description: Flutter plugin for Cloud Functions. -version: 0.4.0+2 +version: 0.4.0+3 author: Flutter Team homepage: https://github.com/flutter/plugins/tree/master/packages/cloud_functions @@ -23,5 +23,5 @@ dev_dependencies: test: any environment: - sdk: ">=2.0.0-dev.28.0 <3.0.0" - flutter: ">=0.2.4 <2.0.0" + sdk: '>=2.0.0-dev.28.0 <3.0.0' + flutter: '>=0.2.4 <2.0.0' From 11d4a03222fba6611b97405f4c1cf335bcdb48fb Mon Sep 17 00:00:00 2001 From: David Berroa Date: Sun, 21 Jul 2019 19:17:00 -0400 Subject: [PATCH 04/13] Fix useFunctionsEmulator method name --- packages/cloud_functions/ios/Classes/CloudFunctionsPlugin.m | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/cloud_functions/ios/Classes/CloudFunctionsPlugin.m b/packages/cloud_functions/ios/Classes/CloudFunctionsPlugin.m index 56d6df13dfef..e48c0fbc73cb 100644 --- a/packages/cloud_functions/ios/Classes/CloudFunctionsPlugin.m +++ b/packages/cloud_functions/ios/Classes/CloudFunctionsPlugin.m @@ -54,7 +54,7 @@ - (void)handleMethodCall:(FlutterMethodCall *)call result:(FlutterResult)result functions = [FIRFunctions functionsForApp:app]; } if (origin != nil && origin != (id)[NSNull null]) { - [functions useFunctionsEmulator:origin]; + [functions useFunctionsEmulatorOrigin:origin]; } FIRHTTPSCallable *function = [functions HTTPSCallableWithName:functionName]; if (timeoutMicroseconds != nil && timeoutMicroseconds != [NSNull null]) { From 4b20b7d7ceb0311eadc3a9da43b355f70ed1dc2f Mon Sep 17 00:00:00 2001 From: Davo Date: Tue, 23 Jul 2019 22:38:22 -0400 Subject: [PATCH 05/13] Update packages/cloud_functions/lib/src/cloud_functions.dart Co-Authored-By: Collin Jackson --- packages/cloud_functions/lib/src/cloud_functions.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/cloud_functions/lib/src/cloud_functions.dart b/packages/cloud_functions/lib/src/cloud_functions.dart index 08711d5dc5ed..7d21e16f7f38 100644 --- a/packages/cloud_functions/lib/src/cloud_functions.dart +++ b/packages/cloud_functions/lib/src/cloud_functions.dart @@ -46,7 +46,7 @@ class CloudFunctions { /// Changes this instance to point to a Cloud Functions emulator running locally. /// /// @param origin The origin of the local emulator, such as "//10.0.2.2:5005". - CloudFunctions useEmulatorFunctions({@required String origin}) { + CloudFunctions useFunctionsEmulator({@required String origin}) { _origin = origin; return this; } From 3769244183a324409a41fbe342d44d15cddb9534 Mon Sep 17 00:00:00 2001 From: Davo Date: Tue, 23 Jul 2019 22:59:34 -0400 Subject: [PATCH 06/13] Using asterisks instead of hyphens. @collinjackson explains this [here](https://github.com/flutter/plugins/pull/1887/commits/7143c48ea515e6e7a626501805b1137adc21f453#r305878318) --- packages/cloud_functions/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/cloud_functions/CHANGELOG.md b/packages/cloud_functions/CHANGELOG.md index f6fa26efb2aa..eb18149239ef 100644 --- a/packages/cloud_functions/CHANGELOG.md +++ b/packages/cloud_functions/CHANGELOG.md @@ -4,7 +4,7 @@ ## 0.4.0+3 -* Update google-services Android gradle plugin to 4.3.0 in documentation and examples. +- Update google-services Android gradle plugin to 4.3.0 in documentation and examples. ## 0.4.0+2 From 63ee2424f0987923dd6faf0c35ce4eb561565d55 Mon Sep 17 00:00:00 2001 From: Davo Date: Fri, 26 Jul 2019 20:09:50 -0400 Subject: [PATCH 07/13] Updating description of the change --- packages/cloud_functions/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/cloud_functions/CHANGELOG.md b/packages/cloud_functions/CHANGELOG.md index eb18149239ef..60a602554681 100644 --- a/packages/cloud_functions/CHANGELOG.md +++ b/packages/cloud_functions/CHANGELOG.md @@ -1,6 +1,6 @@ ## 0.4.1 -- Automatically use version from pubspec.yaml when reporting usage to Firebase. +- Support for cloud functions emulators. ## 0.4.0+3 From 49cd0d1f5e732bbafc20672105adb6d044fa9e12 Mon Sep 17 00:00:00 2001 From: Davo Date: Fri, 26 Jul 2019 20:16:18 -0400 Subject: [PATCH 08/13] Changing to useFunctionsEmulator to fix the test --- packages/cloud_functions/test/cloud_functions_test.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/cloud_functions/test/cloud_functions_test.dart b/packages/cloud_functions/test/cloud_functions_test.dart index f9f477568597..6e58c422423f 100644 --- a/packages/cloud_functions/test/cloud_functions_test.dart +++ b/packages/cloud_functions/test/cloud_functions_test.dart @@ -39,7 +39,7 @@ void main() { 'quux': 'quuz', }); await CloudFunctions.instance - .useEmulatorFunctions(origin: 'http://localhost:5001') + .useFunctionsEmulator(origin: 'http://localhost:5001') .getHttpsCallable(functionName: 'bez') .call(); expect( From 4ea504dbe9bf53f17a0f42dfd49215722b7b04c9 Mon Sep 17 00:00:00 2001 From: Davo Date: Fri, 26 Jul 2019 20:22:02 -0400 Subject: [PATCH 09/13] Fix version of the change Co-Authored-By: Collin Jackson --- packages/cloud_functions/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/cloud_functions/CHANGELOG.md b/packages/cloud_functions/CHANGELOG.md index 60a602554681..b4d9524ae066 100644 --- a/packages/cloud_functions/CHANGELOG.md +++ b/packages/cloud_functions/CHANGELOG.md @@ -2,7 +2,7 @@ - Support for cloud functions emulators. -## 0.4.0+3 +## 0.4.1 - Update google-services Android gradle plugin to 4.3.0 in documentation and examples. From 4acfee5cda2984350026087df8e13b9fc2035ee5 Mon Sep 17 00:00:00 2001 From: Davo Date: Fri, 26 Jul 2019 20:41:11 -0400 Subject: [PATCH 10/13] Update CHANGELOG.md --- packages/cloud_functions/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/cloud_functions/CHANGELOG.md b/packages/cloud_functions/CHANGELOG.md index b4d9524ae066..60a602554681 100644 --- a/packages/cloud_functions/CHANGELOG.md +++ b/packages/cloud_functions/CHANGELOG.md @@ -2,7 +2,7 @@ - Support for cloud functions emulators. -## 0.4.1 +## 0.4.0+3 - Update google-services Android gradle plugin to 4.3.0 in documentation and examples. From 2fa73b98123ff84a2ec7e9a3ddf43615ecc8624c Mon Sep 17 00:00:00 2001 From: David Berroa Date: Fri, 26 Jul 2019 20:56:57 -0400 Subject: [PATCH 11/13] Update version in pubspec.yaml --- packages/cloud_functions/pubspec.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/cloud_functions/pubspec.yaml b/packages/cloud_functions/pubspec.yaml index f14508b0cedc..d1e9bf14f4cd 100644 --- a/packages/cloud_functions/pubspec.yaml +++ b/packages/cloud_functions/pubspec.yaml @@ -1,6 +1,6 @@ name: cloud_functions description: Flutter plugin for Cloud Functions. -version: 0.4.0+3 +version: 0.4.1 author: Flutter Team homepage: https://github.com/flutter/plugins/tree/master/packages/cloud_functions From bd2f8b56269d77da5ab17cacbe8d30296ccfb2bd Mon Sep 17 00:00:00 2001 From: Collin Jackson Date: Sat, 27 Jul 2019 17:00:32 -0700 Subject: [PATCH 12/13] Fix up readme --- packages/cloud_functions/CHANGELOG.md | 52 +++++++++++++-------------- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/packages/cloud_functions/CHANGELOG.md b/packages/cloud_functions/CHANGELOG.md index 60a602554681..57062fbbfa2c 100644 --- a/packages/cloud_functions/CHANGELOG.md +++ b/packages/cloud_functions/CHANGELOG.md @@ -1,67 +1,67 @@ ## 0.4.1 -- Support for cloud functions emulators. +* Support for cloud functions emulators. ## 0.4.0+3 -- Update google-services Android gradle plugin to 4.3.0 in documentation and examples. +* Update google-services Android gradle plugin to 4.3.0 in documentation and examples. ## 0.4.0+2 -- Automatically use version from pubspec.yaml when reporting usage to Firebase. +* Automatically use version from pubspec.yaml when reporting usage to Firebase. ## 0.4.0+1 -- Remove reference to unused header file. +* Remove reference to unused header file. ## 0.4.0 -- Removed unused `parameters` param from `getHttpsCallable`. +* Removed unused `parameters` param from `getHttpsCallable`. ## 0.3.0+1 -- Update iOS dependencies to latest. +* Update iOS dependencies to latest. ## 0.3.0 -- Update Android dependencies to latest. +* Update Android dependencies to latest. ## 0.2.0+1 -- Removed flaky timeout test. +* Removed flaky timeout test. ## 0.2.0 -- **Breaking change**. Updated Dart API to replace `call` with `getHttpsCallable`. -- Added support for timeouts. -- Additional integration testing. +* **Breaking change**. Updated Dart API to replace `call` with `getHttpsCallable`. +* Added support for timeouts. +* Additional integration testing. ## 0.1.2+1 -- Added a driver test. +* Added a driver test. ## 0.1.2 -- Specifying a version for Cloud Functions CocoaPod dependency to prevent build errors on iOS. -- Fix on iOS when using a null region. -- Upgrade the firebase_core dependency of the example app. +* Specifying a version for Cloud Functions CocoaPod dependency to prevent build errors on iOS. +* Fix on iOS when using a null region. +* Upgrade the firebase_core dependency of the example app. ## 0.1.1+1 -- Log messages about automatic configuration of the default app are now less confusing. +* Log messages about automatic configuration of the default app are now less confusing. ## 0.1.1 -- Support for regions and multiple apps +* Support for regions and multiple apps ## 0.1.0+1 -- Log a more detailed warning at build time about the previous AndroidX +* Log a more detailed warning at build time about the previous AndroidX migration. ## 0.1.0 -- **Breaking change**. Migrate from the deprecated original Android Support +* **Breaking change**. Migrate from the deprecated original Android Support Library to AndroidX. This shouldn't result in any functional changes, but it requires any Android apps using this plugin to [also migrate](https://developer.android.com/jetpack/androidx/migrate) if they're @@ -69,28 +69,28 @@ ## 0.0.5 -- Set iOS deployment target to 8.0 (minimum supported by both Firebase SDKs and Flutter), fixes compilation errors. -- Fixes null pointer error when callable function fails with exception (iOS). +* Set iOS deployment target to 8.0 (minimum supported by both Firebase SDKs and Flutter), fixes compilation errors. +* Fixes null pointer error when callable function fails with exception (iOS). ## 0.0.4+1 -- Bump Android dependencies to latest. +* Bump Android dependencies to latest. ## 0.0.4 -- Fixed podspec to use static_framework +* Fixed podspec to use static_framework ## 0.0.3 -- Added missing dependency on meta package. +* Added missing dependency on meta package. ## 0.0.2 -- Bump Android and Firebase dependency versions. +* Bump Android and Firebase dependency versions. ## 0.0.1 -- The Cloud Functions for Firebase client SDKs let you call functions +* The Cloud Functions for Firebase client SDKs let you call functions directly from a Firebase app. This plugin exposes this ability to Flutter apps. From cc90890b6235c7b1c0c79d9444c6d0a5f4e72221 Mon Sep 17 00:00:00 2001 From: Collin Jackson Date: Sat, 27 Jul 2019 19:38:13 -0700 Subject: [PATCH 13/13] Format --- .../plugins/firebase/cloudfunctions/CloudFunctionsPlugin.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/cloud_functions/android/src/main/java/io/flutter/plugins/firebase/cloudfunctions/CloudFunctionsPlugin.java b/packages/cloud_functions/android/src/main/java/io/flutter/plugins/firebase/cloudfunctions/CloudFunctionsPlugin.java index daeedd763743..b99ddefec324 100644 --- a/packages/cloud_functions/android/src/main/java/io/flutter/plugins/firebase/cloudfunctions/CloudFunctionsPlugin.java +++ b/packages/cloud_functions/android/src/main/java/io/flutter/plugins/firebase/cloudfunctions/CloudFunctionsPlugin.java @@ -47,7 +47,7 @@ public void onMethodCall(MethodCall call, final Result result) { } if (origin != null) { functions.useFunctionsEmulator(origin); - } + } HttpsCallableReference httpsCallableReference = functions.getHttpsCallable(functionName); Number timeoutMilliseconds = call.argument("timeoutMilliseconds"); if (timeoutMilliseconds != null) {