From 6d78d290538d74d1e9d70ef4a7e7574d780599d8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=BAlio=20Cotta?= Date: Tue, 23 Jul 2019 02:55:33 -0300 Subject: [PATCH 1/4] fix plugin lifecycle --- .../java/io/flutter/plugins/googlemaps/GoogleMapsPlugin.java | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/google_maps_flutter/android/src/main/java/io/flutter/plugins/googlemaps/GoogleMapsPlugin.java b/packages/google_maps_flutter/android/src/main/java/io/flutter/plugins/googlemaps/GoogleMapsPlugin.java index aced16772d50..b27fea425ba5 100644 --- a/packages/google_maps_flutter/android/src/main/java/io/flutter/plugins/googlemaps/GoogleMapsPlugin.java +++ b/packages/google_maps_flutter/android/src/main/java/io/flutter/plugins/googlemaps/GoogleMapsPlugin.java @@ -88,6 +88,7 @@ public void onActivityDestroyed(Activity activity) { if (activity.hashCode() != registrarActivityHashCode) { return; } + activity.getApplication().unregisterActivityLifecycleCallbacks(this); state.set(DESTROYED); } From 477ad79089ba7d34b5aba2f174f0825deaebb3f9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=BAlio=20Cotta?= Date: Tue, 23 Jul 2019 02:56:46 -0300 Subject: [PATCH 2/4] update pubspec.yaml and CHANGELOG.md --- packages/google_maps_flutter/CHANGELOG.md | 4 ++++ packages/google_maps_flutter/pubspec.yaml | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/google_maps_flutter/CHANGELOG.md b/packages/google_maps_flutter/CHANGELOG.md index ba8774ce450a..9a78f7fee982 100644 --- a/packages/google_maps_flutter/CHANGELOG.md +++ b/packages/google_maps_flutter/CHANGELOG.md @@ -1,3 +1,7 @@ +## 0.5.21 + +* Android: Fix memory leak of ActivityLifecycleCallbacks. + ## 0.5.20 * Add map toolbar support diff --git a/packages/google_maps_flutter/pubspec.yaml b/packages/google_maps_flutter/pubspec.yaml index 4ca1734202af..f8a852998d42 100644 --- a/packages/google_maps_flutter/pubspec.yaml +++ b/packages/google_maps_flutter/pubspec.yaml @@ -2,7 +2,7 @@ name: google_maps_flutter description: A Flutter plugin for integrating Google Maps in iOS and Android applications. author: Flutter Team homepage: https://github.com/flutter/plugins/tree/master/packages/google_maps_flutter -version: 0.5.20 +version: 0.5.21 dependencies: flutter: From afdcb2de5eefa3e74002852c41b5c3ac9d636e1e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=BAlio=20Cotta?= Date: Tue, 23 Jul 2019 19:04:17 -0300 Subject: [PATCH 3/4] updated version to 0.5.20+1 --- packages/google_maps_flutter/CHANGELOG.md | 2 +- packages/google_maps_flutter/pubspec.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/google_maps_flutter/CHANGELOG.md b/packages/google_maps_flutter/CHANGELOG.md index 9a78f7fee982..c15a2ef0dce5 100644 --- a/packages/google_maps_flutter/CHANGELOG.md +++ b/packages/google_maps_flutter/CHANGELOG.md @@ -1,4 +1,4 @@ -## 0.5.21 +## 0.5.20+1 * Android: Fix memory leak of ActivityLifecycleCallbacks. diff --git a/packages/google_maps_flutter/pubspec.yaml b/packages/google_maps_flutter/pubspec.yaml index f8a852998d42..7b595046e1a3 100644 --- a/packages/google_maps_flutter/pubspec.yaml +++ b/packages/google_maps_flutter/pubspec.yaml @@ -2,7 +2,7 @@ name: google_maps_flutter description: A Flutter plugin for integrating Google Maps in iOS and Android applications. author: Flutter Team homepage: https://github.com/flutter/plugins/tree/master/packages/google_maps_flutter -version: 0.5.21 +version: 0.5.20+1 dependencies: flutter: From 640638fbf703c820b4c34409b93e7fed12f42587 Mon Sep 17 00:00:00 2001 From: Amir Hardon Date: Fri, 26 Jul 2019 11:55:00 -0700 Subject: [PATCH 4/4] update changelog --- packages/google_maps_flutter/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/google_maps_flutter/CHANGELOG.md b/packages/google_maps_flutter/CHANGELOG.md index c15a2ef0dce5..aecdc28a1541 100644 --- a/packages/google_maps_flutter/CHANGELOG.md +++ b/packages/google_maps_flutter/CHANGELOG.md @@ -1,6 +1,6 @@ ## 0.5.20+1 -* Android: Fix memory leak of ActivityLifecycleCallbacks. +* Android: Unregister ActivityLifecycleCallbacks on activity destroy (fixes a memory leak). ## 0.5.20