From 8cfbc68b19545fe9da0cfa96db5231c0301d03e9 Mon Sep 17 00:00:00 2001 From: Klaus Jokinen <36441457+KlausJokinen@users.noreply.github.com> Date: Wed, 31 Jul 2019 14:18:04 +0300 Subject: [PATCH 1/3] Fix polyline width when created by adding density option to PolyLineBuilder class --- .../java/io/flutter/plugins/googlemaps/PolylineBuilder.java | 6 ++++-- .../io/flutter/plugins/googlemaps/PolylinesController.java | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/packages/google_maps_flutter/android/src/main/java/io/flutter/plugins/googlemaps/PolylineBuilder.java b/packages/google_maps_flutter/android/src/main/java/io/flutter/plugins/googlemaps/PolylineBuilder.java index 034659768844..49091b4686d4 100644 --- a/packages/google_maps_flutter/android/src/main/java/io/flutter/plugins/googlemaps/PolylineBuilder.java +++ b/packages/google_maps_flutter/android/src/main/java/io/flutter/plugins/googlemaps/PolylineBuilder.java @@ -9,9 +9,11 @@ class PolylineBuilder implements PolylineOptionsSink { private final PolylineOptions polylineOptions; private boolean consumeTapEvents; + private final float density; - PolylineBuilder() { + PolylineBuilder(float density) { this.polylineOptions = new PolylineOptions(); + this.density = density; } PolylineOptions build() { @@ -70,7 +72,7 @@ public void setVisible(boolean visible) { @Override public void setWidth(float width) { - polylineOptions.width(width); + polylineOptions.width(width * density); } @Override diff --git a/packages/google_maps_flutter/android/src/main/java/io/flutter/plugins/googlemaps/PolylinesController.java b/packages/google_maps_flutter/android/src/main/java/io/flutter/plugins/googlemaps/PolylinesController.java index cafc94c53a7d..a6ad61adc170 100644 --- a/packages/google_maps_flutter/android/src/main/java/io/flutter/plugins/googlemaps/PolylinesController.java +++ b/packages/google_maps_flutter/android/src/main/java/io/flutter/plugins/googlemaps/PolylinesController.java @@ -81,7 +81,7 @@ private void addPolyline(Object polyline) { if (polyline == null) { return; } - PolylineBuilder polylineBuilder = new PolylineBuilder(); + PolylineBuilder polylineBuilder = new PolylineBuilder(density); String polylineId = Convert.interpretPolylineOptions(polyline, polylineBuilder); PolylineOptions options = polylineBuilder.build(); addPolyline(polylineId, options, polylineBuilder.consumeTapEvents()); From 251b5cf8ac41fa82d88bc0d57bd24605e14c764e Mon Sep 17 00:00:00 2001 From: Klaus Jokinen <36441457+KlausJokinen@users.noreply.github.com> Date: Wed, 7 Aug 2019 13:38:45 +0300 Subject: [PATCH 2/3] Version bump --- packages/google_maps_flutter/pubspec.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/google_maps_flutter/pubspec.yaml b/packages/google_maps_flutter/pubspec.yaml index 7b595046e1a3..dcd2b3eb4ed3 100644 --- a/packages/google_maps_flutter/pubspec.yaml +++ b/packages/google_maps_flutter/pubspec.yaml @@ -2,7 +2,7 @@ name: google_maps_flutter description: A Flutter plugin for integrating Google Maps in iOS and Android applications. author: Flutter Team homepage: https://github.com/flutter/plugins/tree/master/packages/google_maps_flutter -version: 0.5.20+1 +version: 0.5.20+2 dependencies: flutter: From 44784b42837c19cb63f5da6db864f93950733370 Mon Sep 17 00:00:00 2001 From: Klaus Jokinen <36441457+KlausJokinen@users.noreply.github.com> Date: Wed, 7 Aug 2019 13:39:05 +0300 Subject: [PATCH 3/3] Adjust changelog --- packages/google_maps_flutter/CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/google_maps_flutter/CHANGELOG.md b/packages/google_maps_flutter/CHANGELOG.md index aecdc28a1541..d3f56e36327d 100644 --- a/packages/google_maps_flutter/CHANGELOG.md +++ b/packages/google_maps_flutter/CHANGELOG.md @@ -1,3 +1,7 @@ +## 0.5.20+2 + +* Android: Fix polyline width in building phase. + ## 0.5.20+1 * Android: Unregister ActivityLifecycleCallbacks on activity destroy (fixes a memory leak).