From 0986c493864bb502e5044a16927adf2b59b38142 Mon Sep 17 00:00:00 2001 From: Collin Jackson Date: Wed, 21 Aug 2019 15:19:14 -0700 Subject: [PATCH 1/4] Fix deprecated member use --- packages/video_player/example/lib/main.dart | 32 ++++++++++----------- 1 file changed, 15 insertions(+), 17 deletions(-) diff --git a/packages/video_player/example/lib/main.dart b/packages/video_player/example/lib/main.dart index 320df27c8e3e..4718d0f18cf2 100644 --- a/packages/video_player/example/lib/main.dart +++ b/packages/video_player/example/lib/main.dart @@ -246,23 +246,21 @@ Widget buildCard(String title) { leading: const Icon(Icons.airline_seat_flat_angled), title: Text(title), ), - ButtonTheme.bar( - child: ButtonBar( - children: [ - FlatButton( - child: const Text('BUY TICKETS'), - onPressed: () { - /* ... */ - }, - ), - FlatButton( - child: const Text('SELL TICKETS'), - onPressed: () { - /* ... */ - }, - ), - ], - ), + ButtonBar( + children: [ + FlatButton( + child: const Text('BUY TICKETS'), + onPressed: () { + /* ... */ + }, + ), + FlatButton( + child: const Text('SELL TICKETS'), + onPressed: () { + /* ... */ + }, + ), + ], ), ], ), From 0400863097c33a8656aa847ff1d89d81bd594075 Mon Sep 17 00:00:00 2001 From: Collin Jackson Date: Wed, 21 Aug 2019 15:24:48 -0700 Subject: [PATCH 2/4] Ignore deprecation warning --- packages/video_player/example/lib/main.dart | 33 +++++++++++---------- 1 file changed, 18 insertions(+), 15 deletions(-) diff --git a/packages/video_player/example/lib/main.dart b/packages/video_player/example/lib/main.dart index 4718d0f18cf2..78e24224a90e 100644 --- a/packages/video_player/example/lib/main.dart +++ b/packages/video_player/example/lib/main.dart @@ -246,21 +246,24 @@ Widget buildCard(String title) { leading: const Icon(Icons.airline_seat_flat_angled), title: Text(title), ), - ButtonBar( - children: [ - FlatButton( - child: const Text('BUY TICKETS'), - onPressed: () { - /* ... */ - }, - ), - FlatButton( - child: const Text('SELL TICKETS'), - onPressed: () { - /* ... */ - }, - ), - ], + // ignore: deprecated_member_use + ButtonTheme.bar( + child: ButtonBar( + children: [ + FlatButton( + child: const Text('BUY TICKETS'), + onPressed: () { + /* ... */ + }, + ), + FlatButton( + child: const Text('SELL TICKETS'), + onPressed: () { + /* ... */ + }, + ), + ], + ), ), ], ), From 8ebcc7fc3b55e23746ecb629237665d752ae8d49 Mon Sep 17 00:00:00 2001 From: Collin Jackson Date: Wed, 21 Aug 2019 15:25:02 -0700 Subject: [PATCH 3/4] Bump for release --- packages/video_player/pubspec.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/video_player/pubspec.yaml b/packages/video_player/pubspec.yaml index 218c50f64349..72ec7fa55b62 100644 --- a/packages/video_player/pubspec.yaml +++ b/packages/video_player/pubspec.yaml @@ -2,7 +2,7 @@ name: video_player description: Flutter plugin for displaying inline video with other Flutter widgets on Android and iOS. author: Flutter Team -version: 0.10.1+6 +version: 0.10.1+7 homepage: https://github.com/flutter/plugins/tree/master/packages/video_player flutter: From e7b8eea40d5ec52f947b59c7fd21d03a3942ca8d Mon Sep 17 00:00:00 2001 From: Collin Jackson Date: Wed, 21 Aug 2019 16:00:31 -0700 Subject: [PATCH 4/4] Update comment --- packages/video_player/CHANGELOG.md | 4 ++++ packages/video_player/example/lib/main.dart | 1 + 2 files changed, 5 insertions(+) diff --git a/packages/video_player/CHANGELOG.md b/packages/video_player/CHANGELOG.md index 207a9ca272ce..795d97fdb960 100644 --- a/packages/video_player/CHANGELOG.md +++ b/packages/video_player/CHANGELOG.md @@ -1,3 +1,7 @@ +## 0.10.1+7 + +* Fix tests by ignoring deprecated member use. + ## 0.10.1+6 * [iOS] Fixed a memory leak with notification observing. diff --git a/packages/video_player/example/lib/main.dart b/packages/video_player/example/lib/main.dart index 78e24224a90e..dea1086593df 100644 --- a/packages/video_player/example/lib/main.dart +++ b/packages/video_player/example/lib/main.dart @@ -246,6 +246,7 @@ Widget buildCard(String title) { leading: const Icon(Icons.airline_seat_flat_angled), title: Text(title), ), + // TODO(jackson): Remove when deprecation is on stable branch // ignore: deprecated_member_use ButtonTheme.bar( child: ButtonBar(