From ad6fe13630306ad77bc51cae6c8b9ed587206253 Mon Sep 17 00:00:00 2001 From: Michael Klimushyn Date: Wed, 28 Aug 2019 13:30:40 -0700 Subject: [PATCH 1/2] [in_app_purchase] Remove skipped driver test This test was never providing much value since it needed to be run manually and only verified one of the API calls. Manually opening the configured example app took just as much time and verified much more. CI is failing based on it being skipped right now. Remove it completely to unbreak CI. --- .../example/test_driver/app.dart | 11 ------- .../example/test_driver/app_test.dart | 30 ------------------- 2 files changed, 41 deletions(-) delete mode 100644 packages/in_app_purchase/example/test_driver/app.dart delete mode 100644 packages/in_app_purchase/example/test_driver/app_test.dart diff --git a/packages/in_app_purchase/example/test_driver/app.dart b/packages/in_app_purchase/example/test_driver/app.dart deleted file mode 100644 index 051f7a128cf5..000000000000 --- a/packages/in_app_purchase/example/test_driver/app.dart +++ /dev/null @@ -1,11 +0,0 @@ -// Copyright 2019 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -import 'package:flutter_driver/driver_extension.dart'; -import 'package:in_app_purchase_example/main.dart' as app; - -void main() { - enableFlutterDriverExtension(); - app.main(); -} diff --git a/packages/in_app_purchase/example/test_driver/app_test.dart b/packages/in_app_purchase/example/test_driver/app_test.dart deleted file mode 100644 index 90fd6db027f7..000000000000 --- a/packages/in_app_purchase/example/test_driver/app_test.dart +++ /dev/null @@ -1,30 +0,0 @@ -// Copyright 2019 The Chromium Authors. All rights reserved. -// Use of this source code is governed by a BSD-style license that can be -// found in the LICENSE file. - -import 'package:test/test.dart'; -import 'package:flutter_driver/flutter_driver.dart'; - -void main() { - group('Store connection tests', () { - FlutterDriver driver; - final SerializableFinder connectedFinder = - find.text('The store is available.'); - - setUpAll(() async { - driver = await FlutterDriver.connect(); - }); - - tearDownAll(() async { - if (driver != null) { - driver.close(); - } - }); - - test('can connect', () async { - await driver.waitFor(connectedFinder); - }, - skip: - "run this test manually https://github.com/flutter/flutter/issues/29462"); - }); -} From b5a524d3bacd488d2f7f7108261bc462014a4bdf Mon Sep 17 00:00:00 2001 From: Michael Klimushyn Date: Wed, 28 Aug 2019 14:34:15 -0700 Subject: [PATCH 2/2] Update changelog/pubspec --- packages/in_app_purchase/CHANGELOG.md | 4 ++++ packages/in_app_purchase/pubspec.yaml | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/in_app_purchase/CHANGELOG.md b/packages/in_app_purchase/CHANGELOG.md index 891818199c1a..e7eb3a4faebc 100644 --- a/packages/in_app_purchase/CHANGELOG.md +++ b/packages/in_app_purchase/CHANGELOG.md @@ -1,3 +1,7 @@ +## 0.2.1+1 + +* Remove skipped driver test. + ## 0.2.1 * iOS: Add currencyCode to priceLocale on productDetails. diff --git a/packages/in_app_purchase/pubspec.yaml b/packages/in_app_purchase/pubspec.yaml index a398d945fa03..1bd07cda704b 100644 --- a/packages/in_app_purchase/pubspec.yaml +++ b/packages/in_app_purchase/pubspec.yaml @@ -2,7 +2,7 @@ name: in_app_purchase description: A Flutter plugin for in-app purchases. Exposes APIs for making in-app purchases through the App Store and Google Play. author: Flutter Team homepage: https://github.com/flutter/plugins/tree/master/packages/in_app_purchase -version: 0.2.1 +version: 0.2.1+1 dependencies: