diff --git a/packages/e2e/CHANGELOG.md b/packages/e2e/CHANGELOG.md index ee813dc1c88f..4fcb28efcf75 100644 --- a/packages/e2e/CHANGELOG.md +++ b/packages/e2e/CHANGELOG.md @@ -1,3 +1,10 @@ +## 0.2.1 + +* Support the v2 Android embedder. +* Print a warning if the plugin is not registered. +* Updated method channel name. +* Set a Flutter minimum SDK version. + ## 0.2.0+1 * Updated README. diff --git a/packages/e2e/android/build.gradle b/packages/e2e/android/build.gradle index c91d4721d3ac..08486c8c800c 100644 --- a/packages/e2e/android/build.gradle +++ b/packages/e2e/android/build.gradle @@ -40,3 +40,28 @@ android { api 'androidx.test.espresso:espresso-core:3.2.0' } } + +// TODO(amirh): Remove this hack once androidx.lifecycle is included on stable. https://github.com/flutter/flutter/issues/42348 +afterEvaluate { + def containsEmbeddingDependencies = false + for (def configuration : configurations.all) { + for (def dependency : configuration.dependencies) { + if (dependency.group == 'io.flutter' && + dependency.name.startsWith('flutter_embedding') && + dependency.isTransitive()) + { + containsEmbeddingDependencies = true + break + } + } + } + if (!containsEmbeddingDependencies) { + android { + dependencies { + def lifecycle_version = "2.1.0" + api "androidx.lifecycle:lifecycle-common-java8:$lifecycle_version" + api "androidx.lifecycle:lifecycle-runtime:$lifecycle_version" + } + } + } +} \ No newline at end of file diff --git a/packages/e2e/android/src/main/java/dev/flutter/plugins/e2e/E2EPlugin.java b/packages/e2e/android/src/main/java/dev/flutter/plugins/e2e/E2EPlugin.java index bbb8d8bb4479..ec536408c3fa 100644 --- a/packages/e2e/android/src/main/java/dev/flutter/plugins/e2e/E2EPlugin.java +++ b/packages/e2e/android/src/main/java/dev/flutter/plugins/e2e/E2EPlugin.java @@ -4,6 +4,9 @@ package dev.flutter.plugins.e2e; +import android.content.Context; +import io.flutter.embedding.engine.plugins.FlutterPlugin; +import io.flutter.plugin.common.BinaryMessenger; import io.flutter.plugin.common.MethodCall; import io.flutter.plugin.common.MethodChannel; import io.flutter.plugin.common.MethodChannel.MethodCallHandler; @@ -13,16 +16,34 @@ import java.util.concurrent.CompletableFuture; /** E2EPlugin */ -public class E2EPlugin implements MethodCallHandler { +public class E2EPlugin implements MethodCallHandler, FlutterPlugin { + private MethodChannel methodChannel; public static CompletableFuture> testResults = new CompletableFuture<>(); - private static final String CHANNEL = "plugins.flutter.dev/e2e"; + private static final String CHANNEL = "plugins.flutter.io/e2e"; /** Plugin registration. */ public static void registerWith(Registrar registrar) { - final MethodChannel channel = new MethodChannel(registrar.messenger(), CHANNEL); - channel.setMethodCallHandler(new E2EPlugin()); + final E2EPlugin instance = new E2EPlugin(); + instance.onAttachedToEngine(registrar.context(), registrar.messenger()); + } + + @Override + public void onAttachedToEngine(FlutterPluginBinding binding) { + onAttachedToEngine( + binding.getApplicationContext(), binding.getFlutterEngine().getDartExecutor()); + } + + private void onAttachedToEngine(Context applicationContext, BinaryMessenger messenger) { + methodChannel = new MethodChannel(messenger, "plugins.flutter.io/e2e"); + methodChannel.setMethodCallHandler(this); + } + + @Override + public void onDetachedFromEngine(FlutterPluginBinding binding) { + methodChannel.setMethodCallHandler(null); + methodChannel = null; } @Override diff --git a/packages/e2e/example/android/app/src/androidTest/java/com/example/e2e_example/EmbedderV1ActivityTest.java b/packages/e2e/example/android/app/src/androidTest/java/com/example/e2e_example/EmbedderV1ActivityTest.java new file mode 100644 index 000000000000..a526c1c8422e --- /dev/null +++ b/packages/e2e/example/android/app/src/androidTest/java/com/example/e2e_example/EmbedderV1ActivityTest.java @@ -0,0 +1,13 @@ +package com.example.e2e_example; + +import androidx.test.rule.ActivityTestRule; +import dev.flutter.plugins.e2e.FlutterRunner; +import org.junit.Rule; +import org.junit.runner.RunWith; + +@RunWith(FlutterRunner.class) +public class EmbedderV1ActivityTest { + @Rule + public ActivityTestRule rule = + new ActivityTestRule<>(EmbedderV1Activity.class); +} diff --git a/packages/e2e/example/android/app/src/androidTest/java/com/example/e2e_example/MainActivityTest.java b/packages/e2e/example/android/app/src/androidTest/java/com/example/e2e_example/MainActivityTest.java index 11a6c6afb2fa..b61c056e176d 100644 --- a/packages/e2e/example/android/app/src/androidTest/java/com/example/e2e_example/MainActivityTest.java +++ b/packages/e2e/example/android/app/src/androidTest/java/com/example/e2e_example/MainActivityTest.java @@ -1,7 +1,7 @@ package com.example.e2e_example; import androidx.test.rule.ActivityTestRule; -import dev.flutter.plugins.instrumentationadapter.FlutterRunner; +import dev.flutter.plugins.e2e.FlutterRunner; import org.junit.Rule; import org.junit.runner.RunWith; diff --git a/packages/e2e/example/android/app/src/main/AndroidManifest.xml b/packages/e2e/example/android/app/src/main/AndroidManifest.xml index d2477d5977f5..ae1a11dbcb34 100644 --- a/packages/e2e/example/android/app/src/main/AndroidManifest.xml +++ b/packages/e2e/example/android/app/src/main/AndroidManifest.xml @@ -10,20 +10,18 @@ android:name="io.flutter.app.FlutterApplication" android:label="e2e_example" android:icon="@mipmap/ic_launcher"> + + - - diff --git a/packages/e2e/example/android/app/src/main/java/com/example/e2e_example/EmbedderV1Activity.java b/packages/e2e/example/android/app/src/main/java/com/example/e2e_example/EmbedderV1Activity.java new file mode 100644 index 000000000000..4056569eed8c --- /dev/null +++ b/packages/e2e/example/android/app/src/main/java/com/example/e2e_example/EmbedderV1Activity.java @@ -0,0 +1,17 @@ +// Copyright 2019 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + +package com.example.e2e_example; + +import android.os.Bundle; +import io.flutter.app.FlutterActivity; +import io.flutter.plugins.GeneratedPluginRegistrant; + +public class EmbedderV1Activity extends FlutterActivity { + @Override + protected void onCreate(Bundle savedInstanceState) { + super.onCreate(savedInstanceState); + GeneratedPluginRegistrant.registerWith(this); + } +} diff --git a/packages/e2e/example/android/app/src/main/java/com/example/e2e_example/MainActivity.java b/packages/e2e/example/android/app/src/main/java/com/example/e2e_example/MainActivity.java index 3a58e4e64863..a868db8d9d1c 100644 --- a/packages/e2e/example/android/app/src/main/java/com/example/e2e_example/MainActivity.java +++ b/packages/e2e/example/android/app/src/main/java/com/example/e2e_example/MainActivity.java @@ -1,13 +1,16 @@ +// Copyright 2019 The Chromium Authors. All rights reserved. +// Use of this source code is governed by a BSD-style license that can be +// found in the LICENSE file. + package com.example.e2e_example; -import android.os.Bundle; -import io.flutter.app.FlutterActivity; -import io.flutter.plugins.GeneratedPluginRegistrant; +import dev.flutter.plugins.e2e.E2EPlugin; +import io.flutter.embedding.android.FlutterActivity; +import io.flutter.embedding.engine.FlutterEngine; public class MainActivity extends FlutterActivity { @Override - protected void onCreate(Bundle savedInstanceState) { - super.onCreate(savedInstanceState); - GeneratedPluginRegistrant.registerWith(this); + public void configureFlutterEngine(FlutterEngine flutterEngine) { + flutterEngine.getPlugins().add(new E2EPlugin()); } } diff --git a/packages/e2e/example/android/gradle.properties b/packages/e2e/example/android/gradle.properties index 1515360c4bce..755300e3a0b5 100644 --- a/packages/e2e/example/android/gradle.properties +++ b/packages/e2e/example/android/gradle.properties @@ -2,4 +2,3 @@ org.gradle.jvmargs=-Xmx1536M android.useAndroidX=true android.enableJetifier=true -android.enableR8=true diff --git a/packages/e2e/example/pubspec.yaml b/packages/e2e/example/pubspec.yaml index 3538bb65db0f..456a62f2b36a 100644 --- a/packages/e2e/example/pubspec.yaml +++ b/packages/e2e/example/pubspec.yaml @@ -4,6 +4,7 @@ publish_to: 'none' environment: sdk: ">=2.1.0 <3.0.0" + flutter: ">=1.6.7 <2.0.0" dependencies: flutter: diff --git a/packages/e2e/lib/e2e.dart b/packages/e2e/lib/e2e.dart index 00d29633d045..2f8dc0ebac90 100644 --- a/packages/e2e/lib/e2e.dart +++ b/packages/e2e/lib/e2e.dart @@ -18,7 +18,7 @@ class E2EWidgetsFlutterBinding extends LiveTestWidgetsFlutterBinding { await _channel.invokeMethod( 'allTestsFinished', {'results': _results}); } on MissingPluginException { - // Tests were run on the host rather than a device. + print('Warning: E2E test plugin was not detected.'); } if (!_allTestsPassed.isCompleted) _allTestsPassed.complete(true); }); @@ -34,8 +34,7 @@ class E2EWidgetsFlutterBinding extends LiveTestWidgetsFlutterBinding { return WidgetsBinding.instance; } - static const MethodChannel _channel = - MethodChannel('plugins.flutter.dev/e2e'); + static const MethodChannel _channel = MethodChannel('plugins.flutter.io/e2e'); static Map _results = {}; diff --git a/packages/e2e/pubspec.yaml b/packages/e2e/pubspec.yaml index 2515a51f07fd..bee996db5656 100644 --- a/packages/e2e/pubspec.yaml +++ b/packages/e2e/pubspec.yaml @@ -1,11 +1,12 @@ name: e2e description: Runs tests that use the flutter_test API as integration tests. -version: 0.2.0+1 +version: 0.2.1 author: Flutter Team homepage: https://github.com/flutter/plugins/tree/master/packages/e2e environment: sdk: ">=2.1.0 <3.0.0" + flutter: ">=1.6.7 <2.0.0" dependencies: flutter: