From ab1a72c9e171ff1e00ce2bfa635bffc49acf8cfc Mon Sep 17 00:00:00 2001 From: Michael Klimushyn Date: Tue, 12 Nov 2019 16:25:51 -0800 Subject: [PATCH] [infra] Ignore analyzer issues in CI 35e984 migrated some deprecated analyzer warnings to the newer alternatives. These created some failures in unrelated plugins based on the warnings being slightly different. Added `ignore`s for now to turn CI green again as soon as possible. The previous analysis options really should not be used so I prefer ignoring specific already failing cases to reverting. --- packages/android_alarm_manager/lib/android_alarm_manager.dart | 4 ++++ packages/camera/lib/camera.dart | 1 + .../lib/src/in_app_purchase/google_play_connection.dart | 2 ++ 3 files changed, 7 insertions(+) diff --git a/packages/android_alarm_manager/lib/android_alarm_manager.dart b/packages/android_alarm_manager/lib/android_alarm_manager.dart index b90823e5c9d4..76994b9edac7 100644 --- a/packages/android_alarm_manager/lib/android_alarm_manager.dart +++ b/packages/android_alarm_manager/lib/android_alarm_manager.dart @@ -39,8 +39,10 @@ void _alarmManagerCallbackDispatcher() { exit(-1); } + // ignore: inference_failure_on_function_return_type if (closure is Function()) { closure(); + // ignore: inference_failure_on_function_return_type } else if (closure is Function(int)) { final int id = args[1]; closure(id); @@ -182,6 +184,7 @@ class AndroidAlarmManager { bool wakeup = false, bool rescheduleOnReboot = false, }) async { + // ignore: inference_failure_on_function_return_type assert(callback is Function() || callback is Function(int)); assert(id.bitLength < 32); final int startMillis = time.millisecondsSinceEpoch; @@ -245,6 +248,7 @@ class AndroidAlarmManager { bool wakeup = false, bool rescheduleOnReboot = false, }) async { + // ignore: inference_failure_on_function_return_type assert(callback is Function() || callback is Function(int)); assert(id.bitLength < 32); final int now = DateTime.now().millisecondsSinceEpoch; diff --git a/packages/camera/lib/camera.dart b/packages/camera/lib/camera.dart index ee1892c4cbc0..cc12b907fa65 100644 --- a/packages/camera/lib/camera.dart +++ b/packages/camera/lib/camera.dart @@ -38,6 +38,7 @@ enum ResolutionPreset { max, } +// ignore: inference_failure_on_function_return_type typedef onLatestImageAvailable = Function(CameraImage image); /// Returns the resolution preset as a String. diff --git a/packages/in_app_purchase/lib/src/in_app_purchase/google_play_connection.dart b/packages/in_app_purchase/lib/src/in_app_purchase/google_play_connection.dart index 32f8fc79681e..d64467ed3775 100644 --- a/packages/in_app_purchase/lib/src/in_app_purchase/google_play_connection.dart +++ b/packages/in_app_purchase/lib/src/in_app_purchase/google_play_connection.dart @@ -186,8 +186,10 @@ class GooglePlayConnection } on PlatformException catch (e) { exception = e; responses = [ + // ignore: invalid_use_of_visible_for_testing_member SkuDetailsResponseWrapper( responseCode: BillingResponse.error, skuDetailsList: []), + // ignore: invalid_use_of_visible_for_testing_member SkuDetailsResponseWrapper( responseCode: BillingResponse.error, skuDetailsList: []) ];