From c164302725eb1b2fa4fee927dea3e19bd59fe551 Mon Sep 17 00:00:00 2001 From: Michael Klimushyn Date: Tue, 26 Nov 2019 12:09:07 -0800 Subject: [PATCH] [android_intent] Fix pedantic linter errors --- packages/android_intent/CHANGELOG.md | 4 ++++ packages/android_intent/analysis_options.yaml | 11 ----------- .../example/test_driver/android_intent_e2e.dart | 3 +-- .../example/test_driver/android_intent_e2e_test.dart | 2 +- packages/android_intent/pubspec.yaml | 2 +- packages/android_intent/test/android_intent_test.dart | 6 +++--- 6 files changed, 10 insertions(+), 18 deletions(-) delete mode 100644 packages/android_intent/analysis_options.yaml diff --git a/packages/android_intent/CHANGELOG.md b/packages/android_intent/CHANGELOG.md index de7b818e0d0b..76db8d19fd8a 100644 --- a/packages/android_intent/CHANGELOG.md +++ b/packages/android_intent/CHANGELOG.md @@ -1,3 +1,7 @@ +## 0.3.4+7 + +* Fix pedantic linter errors. + ## 0.3.4+6 * Add missing DartDocs for public members. diff --git a/packages/android_intent/analysis_options.yaml b/packages/android_intent/analysis_options.yaml deleted file mode 100644 index 0eab8e531dc1..000000000000 --- a/packages/android_intent/analysis_options.yaml +++ /dev/null @@ -1,11 +0,0 @@ -# This is a temporary file to allow us to land a new set of linter rules in a -# series of manageable patches instead of one gigantic PR. It disables some of -# the new lints that are already failing on this plugin, for this plugin. It -# should be deleted and the failing lints addressed as soon as possible. - -include: ../../analysis_options.yaml - -analyzer: - errors: - avoid_relative_lib_imports: ignore - unawaited_futures: ignore diff --git a/packages/android_intent/example/test_driver/android_intent_e2e.dart b/packages/android_intent/example/test_driver/android_intent_e2e.dart index 8df8146f52be..2c45262147b1 100644 --- a/packages/android_intent/example/test_driver/android_intent_e2e.dart +++ b/packages/android_intent/example/test_driver/android_intent_e2e.dart @@ -1,13 +1,12 @@ import 'dart:io'; +import 'package:android_intent/android_intent.dart'; import 'package:android_intent_example/main.dart'; import 'package:e2e/e2e.dart'; import 'package:flutter/material.dart'; import 'package:flutter/services.dart'; import 'package:flutter_test/flutter_test.dart'; -import '../../lib/android_intent.dart'; - /// This is a smoke test that verifies that the example app builds and loads. /// Because this plugin works by launching Android platform UIs it's not /// possible to meaningfully test it through its Dart interface currently. There diff --git a/packages/android_intent/example/test_driver/android_intent_e2e_test.dart b/packages/android_intent/example/test_driver/android_intent_e2e_test.dart index 4f38746ce76c..6147d44df2ec 100644 --- a/packages/android_intent/example/test_driver/android_intent_e2e_test.dart +++ b/packages/android_intent/example/test_driver/android_intent_e2e_test.dart @@ -7,6 +7,6 @@ Future main() async { final FlutterDriver driver = await FlutterDriver.connect(); final String result = await driver.requestData(null, timeout: const Duration(minutes: 1)); - driver.close(); + await driver.close(); exit(result == 'pass' ? 0 : 1); } diff --git a/packages/android_intent/pubspec.yaml b/packages/android_intent/pubspec.yaml index 3048d5bbbdf2..85b83b5a8f0a 100644 --- a/packages/android_intent/pubspec.yaml +++ b/packages/android_intent/pubspec.yaml @@ -2,7 +2,7 @@ name: android_intent description: Flutter plugin for launching Android Intents. Not supported on iOS. author: Flutter Team homepage: https://github.com/flutter/plugins/tree/master/packages/android_intent -version: 0.3.4+6 +version: 0.3.4+7 flutter: plugin: diff --git a/packages/android_intent/test/android_intent_test.dart b/packages/android_intent/test/android_intent_test.dart index b13438bf7469..5562159d7bcc 100644 --- a/packages/android_intent/test/android_intent_test.dart +++ b/packages/android_intent/test/android_intent_test.dart @@ -23,7 +23,7 @@ void main() { flags: [Flag.FLAG_ACTIVITY_NEW_TASK], channel: mockChannel, platform: FakePlatform(operatingSystem: 'android')); - androidIntent.launch(); + await androidIntent.launch(); verify(mockChannel.invokeMethod('launch', { 'action': 'action_view', 'data': Uri.encodeFull('https://flutter.io'), @@ -35,7 +35,7 @@ void main() { action: null, channel: mockChannel, platform: FakePlatform(operatingSystem: 'android')); - androidIntent.launch(); + await androidIntent.launch(); verify(mockChannel.invokeMethod('launch', { 'action': null, })); @@ -46,7 +46,7 @@ void main() { action: null, channel: mockChannel, platform: FakePlatform(operatingSystem: 'ios')); - androidIntent.launch(); + await androidIntent.launch(); verifyZeroInteractions(mockChannel); }); });