From 37485c92b75002cb727d6526bd939bb4fb687bc8 Mon Sep 17 00:00:00 2001 From: Michael Klimushyn Date: Wed, 4 Dec 2019 14:44:31 -0800 Subject: [PATCH] [video_player_platform_interface] Fix some pedantic lints Fixes unawaited_futures. There are still some undocumented members here that are unclear to me, so unfortunately the analysis_options.yaml is still there. --- .../video_player_platform_interface/CHANGELOG.md | 4 ++++ .../analysis_options.yaml | 1 - .../lib/video_player_platform_interface.dart | 4 ++-- .../video_player_platform_interface/pubspec.yaml | 2 +- .../test/method_channel_video_player_test.dart | 10 +++++----- 5 files changed, 12 insertions(+), 9 deletions(-) diff --git a/packages/video_player/video_player_platform_interface/CHANGELOG.md b/packages/video_player/video_player_platform_interface/CHANGELOG.md index 54d9e6ba4ecb..acaff15f5466 100644 --- a/packages/video_player/video_player_platform_interface/CHANGELOG.md +++ b/packages/video_player/video_player_platform_interface/CHANGELOG.md @@ -1,3 +1,7 @@ +## 1.0.2 + +* Fix unawaited futures in the tests. + ## 1.0.1 * Return correct platform event type when buffering diff --git a/packages/video_player/video_player_platform_interface/analysis_options.yaml b/packages/video_player/video_player_platform_interface/analysis_options.yaml index e1dadb9e2b2a..969b55796944 100644 --- a/packages/video_player/video_player_platform_interface/analysis_options.yaml +++ b/packages/video_player/video_player_platform_interface/analysis_options.yaml @@ -8,4 +8,3 @@ include: ../../../analysis_options.yaml analyzer: errors: public_member_api_docs: ignore - unawaited_futures: ignore diff --git a/packages/video_player/video_player_platform_interface/lib/video_player_platform_interface.dart b/packages/video_player/video_player_platform_interface/lib/video_player_platform_interface.dart index 46b04d4579a9..d8aa26d6ee46 100644 --- a/packages/video_player/video_player_platform_interface/lib/video_player_platform_interface.dart +++ b/packages/video_player/video_player_platform_interface/lib/video_player_platform_interface.dart @@ -27,6 +27,8 @@ abstract class VideoPlayerPlatform { @visibleForTesting bool get isMock => false; + static VideoPlayerPlatform _instance = MethodChannelVideoPlayer(); + /// The default instance of [VideoPlayerPlatform] to use. /// /// Platform-specific plugins should override this with their own @@ -34,8 +36,6 @@ abstract class VideoPlayerPlatform { /// register themselves. /// /// Defaults to [MethodChannelVideoPlayer]. - static VideoPlayerPlatform _instance = MethodChannelVideoPlayer(); - static VideoPlayerPlatform get instance => _instance; // TODO(amirh): Extract common platform interface logic. diff --git a/packages/video_player/video_player_platform_interface/pubspec.yaml b/packages/video_player/video_player_platform_interface/pubspec.yaml index e36c9583e147..38bde72e28fc 100644 --- a/packages/video_player/video_player_platform_interface/pubspec.yaml +++ b/packages/video_player/video_player_platform_interface/pubspec.yaml @@ -4,7 +4,7 @@ author: Flutter Team homepage: https://github.com/flutter/plugins/tree/master/packages/video_player/video_player_platform_interface # NOTE: We strongly prefer non-breaking changes, even at the expense of a # less-clean API. See https://flutter.dev/go/platform-interface-breaking-changes -version: 1.0.1 +version: 1.0.2 dependencies: flutter: diff --git a/packages/video_player/video_player_platform_interface/test/method_channel_video_player_test.dart b/packages/video_player/video_player_platform_interface/test/method_channel_video_player_test.dart index 02c7bbba22b4..a5fdbbc257de 100644 --- a/packages/video_player/video_player_platform_interface/test/method_channel_video_player_test.dart +++ b/packages/video_player/video_player_platform_interface/test/method_channel_video_player_test.dart @@ -233,7 +233,7 @@ void main() { // with `ServicesBinding.instance.defaultBinaryMessenger` when it's // available on all the versions of Flutter that we test. // ignore: deprecated_member_use - defaultBinaryMessenger.handlePlatformMessage( + await defaultBinaryMessenger.handlePlatformMessage( "flutter.io/videoPlayer/videoEvents123", const StandardMethodCodec() .encodeSuccessEnvelope({ @@ -248,7 +248,7 @@ void main() { // with `ServicesBinding.instance.defaultBinaryMessenger` when it's // available on all the versions of Flutter that we test. // ignore: deprecated_member_use - defaultBinaryMessenger.handlePlatformMessage( + await defaultBinaryMessenger.handlePlatformMessage( "flutter.io/videoPlayer/videoEvents123", const StandardMethodCodec() .encodeSuccessEnvelope({ @@ -260,7 +260,7 @@ void main() { // with `ServicesBinding.instance.defaultBinaryMessenger` when it's // available on all the versions of Flutter that we test. // ignore: deprecated_member_use - defaultBinaryMessenger.handlePlatformMessage( + await defaultBinaryMessenger.handlePlatformMessage( "flutter.io/videoPlayer/videoEvents123", const StandardMethodCodec() .encodeSuccessEnvelope({ @@ -276,7 +276,7 @@ void main() { // with `ServicesBinding.instance.defaultBinaryMessenger` when it's // available on all the versions of Flutter that we test. // ignore: deprecated_member_use - defaultBinaryMessenger.handlePlatformMessage( + await defaultBinaryMessenger.handlePlatformMessage( "flutter.io/videoPlayer/videoEvents123", const StandardMethodCodec() .encodeSuccessEnvelope({ @@ -288,7 +288,7 @@ void main() { // with `ServicesBinding.instance.defaultBinaryMessenger` when it's // available on all the versions of Flutter that we test. // ignore: deprecated_member_use - defaultBinaryMessenger.handlePlatformMessage( + await defaultBinaryMessenger.handlePlatformMessage( "flutter.io/videoPlayer/videoEvents123", const StandardMethodCodec() .encodeSuccessEnvelope({