From 77c5d95dd4b6fd989fb998b38850328983c141e0 Mon Sep 17 00:00:00 2001 From: Conner Kasten Date: Mon, 10 Feb 2020 09:50:05 -0800 Subject: [PATCH 01/12] Add two new scope handling methods to platform_interface. --- .../lib/google_sign_in_platform_interface.dart | 10 ++++++++++ .../lib/src/method_channel_google_sign_in.dart | 16 ++++++++++++++++ .../test/method_channel_google_sign_in_test.dart | 8 ++++++++ 3 files changed, 34 insertions(+) diff --git a/packages/google_sign_in/google_sign_in_platform_interface/lib/google_sign_in_platform_interface.dart b/packages/google_sign_in/google_sign_in_platform_interface/lib/google_sign_in_platform_interface.dart index 01230150c1d0..bc323c32b2a4 100644 --- a/packages/google_sign_in/google_sign_in_platform_interface/lib/google_sign_in_platform_interface.dart +++ b/packages/google_sign_in/google_sign_in_platform_interface/lib/google_sign_in_platform_interface.dart @@ -121,4 +121,14 @@ abstract class GoogleSignInPlatform { Future clearAuthCache({@required String token}) async { throw UnimplementedError('clearAuthCache() has not been implemented.'); } + + /// Indicates whether this Oauth [scope] has been granted. + Future hasGrantedScope(String scope) async { + throw UnimplementedError('hasGrantedScope() has not been implmented.'); + } + + /// Requests the user grant an additional Oauth [scope]. + Future requestScope(String scope) async { + throw UnimplementedError('requestScope() has not been implmented.'); + } } diff --git a/packages/google_sign_in/google_sign_in_platform_interface/lib/src/method_channel_google_sign_in.dart b/packages/google_sign_in/google_sign_in_platform_interface/lib/src/method_channel_google_sign_in.dart index 1d1eb64edd92..59ab34b837a0 100644 --- a/packages/google_sign_in/google_sign_in_platform_interface/lib/src/method_channel_google_sign_in.dart +++ b/packages/google_sign_in/google_sign_in_platform_interface/lib/src/method_channel_google_sign_in.dart @@ -78,4 +78,20 @@ class MethodChannelGoogleSignIn extends GoogleSignInPlatform { {'token': token}, ); } + + @override + Future hasGrantedScope(String scope) { + return channel.invokeMethod( + 'hasGrantedScope', + {'scope': scope}, + ); + } + + @override + Future requestScope(String scope) { + return channel.invokeMethod( + 'requestScope', + {'scope': scope}, + ); + } } diff --git a/packages/google_sign_in/google_sign_in_platform_interface/test/method_channel_google_sign_in_test.dart b/packages/google_sign_in/google_sign_in_platform_interface/test/method_channel_google_sign_in_test.dart index 13de6acf0748..bd6e22429400 100644 --- a/packages/google_sign_in/google_sign_in_platform_interface/test/method_channel_google_sign_in_test.dart +++ b/packages/google_sign_in/google_sign_in_platform_interface/test/method_channel_google_sign_in_test.dart @@ -114,6 +114,14 @@ void main() { }: isMethodCall('clearAuthCache', arguments: { 'token': 'abc', }), + () { + googleSignIn.hasGrantedScope('grantedScope'); + }: isMethodCall('hasGrantedScope', + arguments: {'scope': 'grantedScope'}), + () { + googleSignIn.requestScope('newScope'); + }: isMethodCall('requestScope', + arguments: {'scope': 'newScope'}), googleSignIn.signOut: isMethodCall('signOut', arguments: null), googleSignIn.disconnect: isMethodCall('disconnect', arguments: null), googleSignIn.isSignedIn: isMethodCall('isSignedIn', arguments: null), From 4d20016f7ec9b4f445a8e0407db8dee1e4e654e9 Mon Sep 17 00:00:00 2001 From: Conner Kasten Date: Mon, 10 Feb 2020 10:03:29 -0800 Subject: [PATCH 02/12] Update changelog and version for google_sign_in_platform_interface. --- .../google_sign_in_platform_interface/CHANGELOG.md | 5 +++++ .../google_sign_in_platform_interface/pubspec.yaml | 3 ++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/packages/google_sign_in/google_sign_in_platform_interface/CHANGELOG.md b/packages/google_sign_in/google_sign_in_platform_interface/CHANGELOG.md index 7819e747ecd4..c0627df8c1da 100644 --- a/packages/google_sign_in/google_sign_in_platform_interface/CHANGELOG.md +++ b/packages/google_sign_in/google_sign_in_platform_interface/CHANGELOG.md @@ -1,3 +1,8 @@ +## 1.1.0 + +* Add hasRequestedScope method to determine if an Oauth scope has been granted. +* Add requestScope Method to request new Oauth scopes be granted by the user. + ## 1.0.4 * Make the pedantic dev_dependency explicit. diff --git a/packages/google_sign_in/google_sign_in_platform_interface/pubspec.yaml b/packages/google_sign_in/google_sign_in_platform_interface/pubspec.yaml index 23937e2511ef..84fda1cf500d 100644 --- a/packages/google_sign_in/google_sign_in_platform_interface/pubspec.yaml +++ b/packages/google_sign_in/google_sign_in_platform_interface/pubspec.yaml @@ -3,7 +3,8 @@ description: A common platform interface for the google_sign_in plugin. homepage: https://github.com/flutter/plugins/tree/master/packages/google_sign_in/google_sign_in_platform_interface # NOTE: We strongly prefer non-breaking changes, even at the expense of a # less-clean API. See https://flutter.dev/go/platform-interface-breaking-changes -version: 1.0.4 +version: 1.1.0 + dependencies: flutter: From 00fbc7e246d6471824a1e79de8a6fc7eccb8f5c9 Mon Sep 17 00:00:00 2001 From: Conner Kasten Date: Mon, 10 Feb 2020 10:07:43 -0800 Subject: [PATCH 03/12] Make test formatting consistent. --- .../test/method_channel_google_sign_in_test.dart | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/packages/google_sign_in/google_sign_in_platform_interface/test/method_channel_google_sign_in_test.dart b/packages/google_sign_in/google_sign_in_platform_interface/test/method_channel_google_sign_in_test.dart index bd6e22429400..cf51cd3a1735 100644 --- a/packages/google_sign_in/google_sign_in_platform_interface/test/method_channel_google_sign_in_test.dart +++ b/packages/google_sign_in/google_sign_in_platform_interface/test/method_channel_google_sign_in_test.dart @@ -116,12 +116,14 @@ void main() { }), () { googleSignIn.hasGrantedScope('grantedScope'); - }: isMethodCall('hasGrantedScope', - arguments: {'scope': 'grantedScope'}), + }: isMethodCall('hasGrantedScope', arguments: { + 'scope': 'grantedScope', + }), () { googleSignIn.requestScope('newScope'); - }: isMethodCall('requestScope', - arguments: {'scope': 'newScope'}), + }: isMethodCall('requestScope', arguments: { + 'scope': 'newScope', + }), googleSignIn.signOut: isMethodCall('signOut', arguments: null), googleSignIn.disconnect: isMethodCall('disconnect', arguments: null), googleSignIn.isSignedIn: isMethodCall('isSignedIn', arguments: null), From 43407b109deeeda0db63d164a77c5e489863f9b5 Mon Sep 17 00:00:00 2001 From: Conner Kasten Date: Fri, 21 Feb 2020 10:34:26 -0800 Subject: [PATCH 04/12] Fix formatting. --- .../lib/src/method_channel_google_sign_in.dart | 4 ++-- .../google_sign_in_platform_interface/pubspec.yaml | 1 - 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/packages/google_sign_in/google_sign_in_platform_interface/lib/src/method_channel_google_sign_in.dart b/packages/google_sign_in/google_sign_in_platform_interface/lib/src/method_channel_google_sign_in.dart index 59ab34b837a0..24cee6ace481 100644 --- a/packages/google_sign_in/google_sign_in_platform_interface/lib/src/method_channel_google_sign_in.dart +++ b/packages/google_sign_in/google_sign_in_platform_interface/lib/src/method_channel_google_sign_in.dart @@ -82,7 +82,7 @@ class MethodChannelGoogleSignIn extends GoogleSignInPlatform { @override Future hasGrantedScope(String scope) { return channel.invokeMethod( - 'hasGrantedScope', + 'hasGrantedScope', {'scope': scope}, ); } @@ -90,7 +90,7 @@ class MethodChannelGoogleSignIn extends GoogleSignInPlatform { @override Future requestScope(String scope) { return channel.invokeMethod( - 'requestScope', + 'requestScope', {'scope': scope}, ); } diff --git a/packages/google_sign_in/google_sign_in_platform_interface/pubspec.yaml b/packages/google_sign_in/google_sign_in_platform_interface/pubspec.yaml index 84fda1cf500d..d1f7abc291c4 100644 --- a/packages/google_sign_in/google_sign_in_platform_interface/pubspec.yaml +++ b/packages/google_sign_in/google_sign_in_platform_interface/pubspec.yaml @@ -5,7 +5,6 @@ homepage: https://github.com/flutter/plugins/tree/master/packages/google_sign_in # less-clean API. See https://flutter.dev/go/platform-interface-breaking-changes version: 1.1.0 - dependencies: flutter: sdk: flutter From cd919c2da3f1a528b57d59c478c767843cc5b808 Mon Sep 17 00:00:00 2001 From: Conner Kasten Date: Thu, 27 Feb 2020 12:52:52 -0800 Subject: [PATCH 05/12] Convert reqeustScope to allow multiple scopes requested at once. --- .../lib/google_sign_in_platform_interface.dart | 4 ++-- .../lib/src/method_channel_google_sign_in.dart | 4 ++-- .../test/method_channel_google_sign_in_test.dart | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/google_sign_in/google_sign_in_platform_interface/lib/google_sign_in_platform_interface.dart b/packages/google_sign_in/google_sign_in_platform_interface/lib/google_sign_in_platform_interface.dart index bc323c32b2a4..1dcf00a4c16e 100644 --- a/packages/google_sign_in/google_sign_in_platform_interface/lib/google_sign_in_platform_interface.dart +++ b/packages/google_sign_in/google_sign_in_platform_interface/lib/google_sign_in_platform_interface.dart @@ -128,7 +128,7 @@ abstract class GoogleSignInPlatform { } /// Requests the user grant an additional Oauth [scope]. - Future requestScope(String scope) async { - throw UnimplementedError('requestScope() has not been implmented.'); + Future requestScopes(List scopes) async { + throw UnimplementedError('requestScopes() has not been implmented.'); } } diff --git a/packages/google_sign_in/google_sign_in_platform_interface/lib/src/method_channel_google_sign_in.dart b/packages/google_sign_in/google_sign_in_platform_interface/lib/src/method_channel_google_sign_in.dart index 24cee6ace481..1b247cd19ab1 100644 --- a/packages/google_sign_in/google_sign_in_platform_interface/lib/src/method_channel_google_sign_in.dart +++ b/packages/google_sign_in/google_sign_in_platform_interface/lib/src/method_channel_google_sign_in.dart @@ -88,10 +88,10 @@ class MethodChannelGoogleSignIn extends GoogleSignInPlatform { } @override - Future requestScope(String scope) { + Future requestScopes(List scopes) { return channel.invokeMethod( 'requestScope', - {'scope': scope}, + >{'scope': scopes}, ); } } diff --git a/packages/google_sign_in/google_sign_in_platform_interface/test/method_channel_google_sign_in_test.dart b/packages/google_sign_in/google_sign_in_platform_interface/test/method_channel_google_sign_in_test.dart index cf51cd3a1735..d4c18de24500 100644 --- a/packages/google_sign_in/google_sign_in_platform_interface/test/method_channel_google_sign_in_test.dart +++ b/packages/google_sign_in/google_sign_in_platform_interface/test/method_channel_google_sign_in_test.dart @@ -120,9 +120,9 @@ void main() { 'scope': 'grantedScope', }), () { - googleSignIn.requestScope('newScope'); + googleSignIn.requestScopes(['newScope', 'anotherScope']); }: isMethodCall('requestScope', arguments: { - 'scope': 'newScope', + 'scope': ['newScope', 'anotherScope'], }), googleSignIn.signOut: isMethodCall('signOut', arguments: null), googleSignIn.disconnect: isMethodCall('disconnect', arguments: null), From e9af63f1a2d60596f6ff6df8cd30a2396891e77f Mon Sep 17 00:00:00 2001 From: Conner Kasten Date: Fri, 28 Feb 2020 08:34:40 -0800 Subject: [PATCH 06/12] Allow multiple scope grants to be checked at once. --- .../lib/google_sign_in_platform_interface.dart | 4 ++-- .../lib/src/method_channel_google_sign_in.dart | 8 ++++---- .../test/method_channel_google_sign_in_test.dart | 6 +++--- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/packages/google_sign_in/google_sign_in_platform_interface/lib/google_sign_in_platform_interface.dart b/packages/google_sign_in/google_sign_in_platform_interface/lib/google_sign_in_platform_interface.dart index 1dcf00a4c16e..33abdf7d9f70 100644 --- a/packages/google_sign_in/google_sign_in_platform_interface/lib/google_sign_in_platform_interface.dart +++ b/packages/google_sign_in/google_sign_in_platform_interface/lib/google_sign_in_platform_interface.dart @@ -122,8 +122,8 @@ abstract class GoogleSignInPlatform { throw UnimplementedError('clearAuthCache() has not been implemented.'); } - /// Indicates whether this Oauth [scope] has been granted. - Future hasGrantedScope(String scope) async { + /// Checks to see if [scopes] have been granted, returns those which have not. + Future> listMissingScopes(List scopes) async { throw UnimplementedError('hasGrantedScope() has not been implmented.'); } diff --git a/packages/google_sign_in/google_sign_in_platform_interface/lib/src/method_channel_google_sign_in.dart b/packages/google_sign_in/google_sign_in_platform_interface/lib/src/method_channel_google_sign_in.dart index 1b247cd19ab1..25f773abf968 100644 --- a/packages/google_sign_in/google_sign_in_platform_interface/lib/src/method_channel_google_sign_in.dart +++ b/packages/google_sign_in/google_sign_in_platform_interface/lib/src/method_channel_google_sign_in.dart @@ -80,10 +80,10 @@ class MethodChannelGoogleSignIn extends GoogleSignInPlatform { } @override - Future hasGrantedScope(String scope) { - return channel.invokeMethod( - 'hasGrantedScope', - {'scope': scope}, + Future> listMissingScopes(List scopes) { + return channel.invokeMethod>( + 'listMissingScopes', + >{'scopes': scopes}, ); } diff --git a/packages/google_sign_in/google_sign_in_platform_interface/test/method_channel_google_sign_in_test.dart b/packages/google_sign_in/google_sign_in_platform_interface/test/method_channel_google_sign_in_test.dart index d4c18de24500..16f3eb17159a 100644 --- a/packages/google_sign_in/google_sign_in_platform_interface/test/method_channel_google_sign_in_test.dart +++ b/packages/google_sign_in/google_sign_in_platform_interface/test/method_channel_google_sign_in_test.dart @@ -115,9 +115,9 @@ void main() { 'token': 'abc', }), () { - googleSignIn.hasGrantedScope('grantedScope'); - }: isMethodCall('hasGrantedScope', arguments: { - 'scope': 'grantedScope', + googleSignIn.listMissingScopes(['grantedScope']); + }: isMethodCall('listMissingScopes', arguments: { + 'scopes': ['grantedScope'], }), () { googleSignIn.requestScopes(['newScope', 'anotherScope']); From a3b635a7ca43f924cb6c61b3bc9565914c95062c Mon Sep 17 00:00:00 2001 From: Conner Kasten Date: Fri, 28 Feb 2020 08:41:11 -0800 Subject: [PATCH 07/12] Make pluralization of 'scopes' consistent. --- .../lib/google_sign_in_platform_interface.dart | 2 +- .../lib/src/method_channel_google_sign_in.dart | 4 ++-- .../test/method_channel_google_sign_in_test.dart | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/google_sign_in/google_sign_in_platform_interface/lib/google_sign_in_platform_interface.dart b/packages/google_sign_in/google_sign_in_platform_interface/lib/google_sign_in_platform_interface.dart index 33abdf7d9f70..1649a269ddb1 100644 --- a/packages/google_sign_in/google_sign_in_platform_interface/lib/google_sign_in_platform_interface.dart +++ b/packages/google_sign_in/google_sign_in_platform_interface/lib/google_sign_in_platform_interface.dart @@ -124,7 +124,7 @@ abstract class GoogleSignInPlatform { /// Checks to see if [scopes] have been granted, returns those which have not. Future> listMissingScopes(List scopes) async { - throw UnimplementedError('hasGrantedScope() has not been implmented.'); + throw UnimplementedError('listMissingScopes() has not been implmented.'); } /// Requests the user grant an additional Oauth [scope]. diff --git a/packages/google_sign_in/google_sign_in_platform_interface/lib/src/method_channel_google_sign_in.dart b/packages/google_sign_in/google_sign_in_platform_interface/lib/src/method_channel_google_sign_in.dart index 25f773abf968..6a6c7f59f18b 100644 --- a/packages/google_sign_in/google_sign_in_platform_interface/lib/src/method_channel_google_sign_in.dart +++ b/packages/google_sign_in/google_sign_in_platform_interface/lib/src/method_channel_google_sign_in.dart @@ -90,8 +90,8 @@ class MethodChannelGoogleSignIn extends GoogleSignInPlatform { @override Future requestScopes(List scopes) { return channel.invokeMethod( - 'requestScope', - >{'scope': scopes}, + 'requestScopes', + >{'scopes': scopes}, ); } } diff --git a/packages/google_sign_in/google_sign_in_platform_interface/test/method_channel_google_sign_in_test.dart b/packages/google_sign_in/google_sign_in_platform_interface/test/method_channel_google_sign_in_test.dart index 16f3eb17159a..1a2973d7b625 100644 --- a/packages/google_sign_in/google_sign_in_platform_interface/test/method_channel_google_sign_in_test.dart +++ b/packages/google_sign_in/google_sign_in_platform_interface/test/method_channel_google_sign_in_test.dart @@ -121,8 +121,8 @@ void main() { }), () { googleSignIn.requestScopes(['newScope', 'anotherScope']); - }: isMethodCall('requestScope', arguments: { - 'scope': ['newScope', 'anotherScope'], + }: isMethodCall('requestScopes', arguments: { + 'scopes': ['newScope', 'anotherScope'], }), googleSignIn.signOut: isMethodCall('signOut', arguments: null), googleSignIn.disconnect: isMethodCall('disconnect', arguments: null), From f8b462888db4400ec769bd7907cb30d7d8510ef3 Mon Sep 17 00:00:00 2001 From: Conner Kasten Date: Fri, 28 Feb 2020 11:40:13 -0800 Subject: [PATCH 08/12] Receive result as List before converting to List. --- .../lib/src/method_channel_google_sign_in.dart | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/google_sign_in/google_sign_in_platform_interface/lib/src/method_channel_google_sign_in.dart b/packages/google_sign_in/google_sign_in_platform_interface/lib/src/method_channel_google_sign_in.dart index 6a6c7f59f18b..94242525cc18 100644 --- a/packages/google_sign_in/google_sign_in_platform_interface/lib/src/method_channel_google_sign_in.dart +++ b/packages/google_sign_in/google_sign_in_platform_interface/lib/src/method_channel_google_sign_in.dart @@ -81,10 +81,10 @@ class MethodChannelGoogleSignIn extends GoogleSignInPlatform { @override Future> listMissingScopes(List scopes) { - return channel.invokeMethod>( + return channel.invokeMethod>( 'listMissingScopes', >{'scopes': scopes}, - ); + ).then((result) => List.from(result)); } @override From 379a9200c2a3c3ca7c3ab15cd945f03c1619e797 Mon Sep 17 00:00:00 2001 From: Conner Kasten Date: Fri, 28 Feb 2020 11:50:50 -0800 Subject: [PATCH 09/12] Handle null result for missing scopes. --- .../lib/src/method_channel_google_sign_in.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/google_sign_in/google_sign_in_platform_interface/lib/src/method_channel_google_sign_in.dart b/packages/google_sign_in/google_sign_in_platform_interface/lib/src/method_channel_google_sign_in.dart index 94242525cc18..24e376e505ef 100644 --- a/packages/google_sign_in/google_sign_in_platform_interface/lib/src/method_channel_google_sign_in.dart +++ b/packages/google_sign_in/google_sign_in_platform_interface/lib/src/method_channel_google_sign_in.dart @@ -84,7 +84,7 @@ class MethodChannelGoogleSignIn extends GoogleSignInPlatform { return channel.invokeMethod>( 'listMissingScopes', >{'scopes': scopes}, - ).then((result) => List.from(result)); + ).then((result) => result != null ? List.from(result) : null); } @override From f37f53d93d23bea1b13ee353dec892dc4391649c Mon Sep 17 00:00:00 2001 From: Conner Kasten Date: Fri, 28 Feb 2020 12:31:23 -0800 Subject: [PATCH 10/12] Remove listMissingScopes. --- .../lib/google_sign_in_platform_interface.dart | 7 +------ .../lib/src/method_channel_google_sign_in.dart | 8 -------- .../test/method_channel_google_sign_in_test.dart | 5 ----- 3 files changed, 1 insertion(+), 19 deletions(-) diff --git a/packages/google_sign_in/google_sign_in_platform_interface/lib/google_sign_in_platform_interface.dart b/packages/google_sign_in/google_sign_in_platform_interface/lib/google_sign_in_platform_interface.dart index 1649a269ddb1..ae21cfcace5c 100644 --- a/packages/google_sign_in/google_sign_in_platform_interface/lib/google_sign_in_platform_interface.dart +++ b/packages/google_sign_in/google_sign_in_platform_interface/lib/google_sign_in_platform_interface.dart @@ -122,12 +122,7 @@ abstract class GoogleSignInPlatform { throw UnimplementedError('clearAuthCache() has not been implemented.'); } - /// Checks to see if [scopes] have been granted, returns those which have not. - Future> listMissingScopes(List scopes) async { - throw UnimplementedError('listMissingScopes() has not been implmented.'); - } - - /// Requests the user grant an additional Oauth [scope]. + /// Requests the user grants additional Oauth [scopes]. Future requestScopes(List scopes) async { throw UnimplementedError('requestScopes() has not been implmented.'); } diff --git a/packages/google_sign_in/google_sign_in_platform_interface/lib/src/method_channel_google_sign_in.dart b/packages/google_sign_in/google_sign_in_platform_interface/lib/src/method_channel_google_sign_in.dart index 24e376e505ef..4d2a34fe0fe7 100644 --- a/packages/google_sign_in/google_sign_in_platform_interface/lib/src/method_channel_google_sign_in.dart +++ b/packages/google_sign_in/google_sign_in_platform_interface/lib/src/method_channel_google_sign_in.dart @@ -79,14 +79,6 @@ class MethodChannelGoogleSignIn extends GoogleSignInPlatform { ); } - @override - Future> listMissingScopes(List scopes) { - return channel.invokeMethod>( - 'listMissingScopes', - >{'scopes': scopes}, - ).then((result) => result != null ? List.from(result) : null); - } - @override Future requestScopes(List scopes) { return channel.invokeMethod( diff --git a/packages/google_sign_in/google_sign_in_platform_interface/test/method_channel_google_sign_in_test.dart b/packages/google_sign_in/google_sign_in_platform_interface/test/method_channel_google_sign_in_test.dart index 1a2973d7b625..6a8f73736004 100644 --- a/packages/google_sign_in/google_sign_in_platform_interface/test/method_channel_google_sign_in_test.dart +++ b/packages/google_sign_in/google_sign_in_platform_interface/test/method_channel_google_sign_in_test.dart @@ -114,11 +114,6 @@ void main() { }: isMethodCall('clearAuthCache', arguments: { 'token': 'abc', }), - () { - googleSignIn.listMissingScopes(['grantedScope']); - }: isMethodCall('listMissingScopes', arguments: { - 'scopes': ['grantedScope'], - }), () { googleSignIn.requestScopes(['newScope', 'anotherScope']); }: isMethodCall('requestScopes', arguments: { From a01fac40f30c49854cf69fa39e36abae50bebcd2 Mon Sep 17 00:00:00 2001 From: Conner Kasten Date: Wed, 4 Mar 2020 16:32:11 -0800 Subject: [PATCH 11/12] Add link to scope list in dartdoc. --- .../lib/google_sign_in_platform_interface.dart | 3 +++ 1 file changed, 3 insertions(+) diff --git a/packages/google_sign_in/google_sign_in_platform_interface/lib/google_sign_in_platform_interface.dart b/packages/google_sign_in/google_sign_in_platform_interface/lib/google_sign_in_platform_interface.dart index ae21cfcace5c..674f0e3fefa8 100644 --- a/packages/google_sign_in/google_sign_in_platform_interface/lib/google_sign_in_platform_interface.dart +++ b/packages/google_sign_in/google_sign_in_platform_interface/lib/google_sign_in_platform_interface.dart @@ -123,6 +123,9 @@ abstract class GoogleSignInPlatform { } /// Requests the user grants additional Oauth [scopes]. + /// + /// Scopes should come from the full list + /// [here](https://developers.google.com/identity/protocols/googlescopes). Future requestScopes(List scopes) async { throw UnimplementedError('requestScopes() has not been implmented.'); } From 02fdaa74df05905f9c902ce1024de81ee5f9acc0 Mon Sep 17 00:00:00 2001 From: Conner Kasten Date: Wed, 4 Mar 2020 16:37:35 -0800 Subject: [PATCH 12/12] Fix dartdoc formatting. --- .../lib/google_sign_in_platform_interface.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/google_sign_in/google_sign_in_platform_interface/lib/google_sign_in_platform_interface.dart b/packages/google_sign_in/google_sign_in_platform_interface/lib/google_sign_in_platform_interface.dart index 674f0e3fefa8..966e93551086 100644 --- a/packages/google_sign_in/google_sign_in_platform_interface/lib/google_sign_in_platform_interface.dart +++ b/packages/google_sign_in/google_sign_in_platform_interface/lib/google_sign_in_platform_interface.dart @@ -123,7 +123,7 @@ abstract class GoogleSignInPlatform { } /// Requests the user grants additional Oauth [scopes]. - /// + /// /// Scopes should come from the full list /// [here](https://developers.google.com/identity/protocols/googlescopes). Future requestScopes(List scopes) async {