From 1867a990bf03cf97ed1ee08e0515cc19f2538d17 Mon Sep 17 00:00:00 2001 From: Francisco Madgaleno Date: Thu, 27 Feb 2020 15:51:45 -0800 Subject: [PATCH 1/4] Rename StorageDirectory --- .../lib/path_provider_platform_interface.dart | 4 ++-- .../path_provider_platform_interface/lib/src/enums.dart | 2 +- .../lib/src/method_channel_path_provider.dart | 2 +- .../test/method_channel_path_provider_test.dart | 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/path_provider/path_provider_platform_interface/lib/path_provider_platform_interface.dart b/packages/path_provider/path_provider_platform_interface/lib/path_provider_platform_interface.dart index 72aadf35b3e8..4f796aaeec33 100644 --- a/packages/path_provider/path_provider_platform_interface/lib/path_provider_platform_interface.dart +++ b/packages/path_provider/path_provider_platform_interface/lib/path_provider_platform_interface.dart @@ -85,9 +85,9 @@ abstract class PathProviderPlatform extends PlatformInterface { /// These paths typically reside on external storage like separate partitions /// or SD cards. Phones may have multiple storage directories available. Future> getExternalStoragePaths({ - /// Optional parameter. See [AndroidStorageDirectory] for more informations on + /// Optional parameter. See [StorageDirectory] for more informations on /// how this type translates to Android storage directories. - AndroidStorageDirectory type, + StorageDirectory type, }) { throw UnimplementedError( 'getExternalStoragePaths() has not been implemented.'); diff --git a/packages/path_provider/path_provider_platform_interface/lib/src/enums.dart b/packages/path_provider/path_provider_platform_interface/lib/src/enums.dart index cf04a164203f..c97ef5d2b0f5 100644 --- a/packages/path_provider/path_provider_platform_interface/lib/src/enums.dart +++ b/packages/path_provider/path_provider_platform_interface/lib/src/enums.dart @@ -1,7 +1,7 @@ /// Corresponds to constants defined in Androids `android.os.Environment` class. /// /// https://developer.android.com/reference/android/os/Environment.html#fields_1 -enum AndroidStorageDirectory { +enum StorageDirectory { /// Contains audio files that should be treated as music. /// /// See https://developer.android.com/reference/android/os/Environment.html#DIRECTORY_MUSIC. diff --git a/packages/path_provider/path_provider_platform_interface/lib/src/method_channel_path_provider.dart b/packages/path_provider/path_provider_platform_interface/lib/src/method_channel_path_provider.dart index acac9d5fe7af..7826fa4365be 100644 --- a/packages/path_provider/path_provider_platform_interface/lib/src/method_channel_path_provider.dart +++ b/packages/path_provider/path_provider_platform_interface/lib/src/method_channel_path_provider.dart @@ -66,7 +66,7 @@ class MethodChannelPathProvider extends PathProviderPlatform { } Future> getExternalStoragePaths({ - AndroidStorageDirectory type, + StorageDirectory type, }) async { if (!_platform.isAndroid) { throw UnsupportedError('Functionality only available on Android'); diff --git a/packages/path_provider/path_provider_platform_interface/test/method_channel_path_provider_test.dart b/packages/path_provider/path_provider_platform_interface/test/method_channel_path_provider_test.dart index c21acdb140b6..99c9349f9ae5 100644 --- a/packages/path_provider/path_provider_platform_interface/test/method_channel_path_provider_test.dart +++ b/packages/path_provider/path_provider_platform_interface/test/method_channel_path_provider_test.dart @@ -147,8 +147,8 @@ void main() { } }); - for (AndroidStorageDirectory type - in AndroidStorageDirectory.values + [null]) { + for (StorageDirectory type + in StorageDirectory.values + [null]) { test('getExternalStoragePaths (type: $type) android succeeds', () async { final List result = await methodChannelPathProvider.getExternalStoragePaths(type: type); From 5e3b67b05395623e8f556404313e1f8b1dd4ed45 Mon Sep 17 00:00:00 2001 From: Francisco Madgaleno Date: Thu, 27 Feb 2020 15:59:30 -0800 Subject: [PATCH 2/4] Update version --- .../path_provider_platform_interface/CHANGELOG.md | 4 ++++ .../path_provider_platform_interface/pubspec.yaml | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/path_provider/path_provider_platform_interface/CHANGELOG.md b/packages/path_provider/path_provider_platform_interface/CHANGELOG.md index 0d8803f93540..503bde25ffcb 100644 --- a/packages/path_provider/path_provider_platform_interface/CHANGELOG.md +++ b/packages/path_provider/path_provider_platform_interface/CHANGELOG.md @@ -1,3 +1,7 @@ +## 2.0.0 + +* Rename enum to StorageDirectory for backwards compatibility. + ## 1.0.0 * Initial release. diff --git a/packages/path_provider/path_provider_platform_interface/pubspec.yaml b/packages/path_provider/path_provider_platform_interface/pubspec.yaml index 44bc0c2c161c..f0e0e376d1ed 100644 --- a/packages/path_provider/path_provider_platform_interface/pubspec.yaml +++ b/packages/path_provider/path_provider_platform_interface/pubspec.yaml @@ -3,7 +3,7 @@ description: A common platform interface for the path_provider plugin. homepage: https://github.com/flutter/plugins/tree/master/packages/path_provider/path_provider_platform_interface # NOTE: We strongly prefer non-breaking changes, even at the expense of a # less-clean API. See https://flutter.dev/go/platform-interface-breaking-changes -version: 1.0.0 +version: 2.0.0 dependencies: flutter: From fc791ac4ec91dc55bbe7e79aafc288a8184ff4b6 Mon Sep 17 00:00:00 2001 From: Francisco Madgaleno Date: Thu, 27 Feb 2020 16:13:04 -0800 Subject: [PATCH 3/4] Update version to non-breaking --- .../path_provider/path_provider_platform_interface/CHANGELOG.md | 2 +- .../path_provider/path_provider_platform_interface/pubspec.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/path_provider/path_provider_platform_interface/CHANGELOG.md b/packages/path_provider/path_provider_platform_interface/CHANGELOG.md index 503bde25ffcb..82528917c1c7 100644 --- a/packages/path_provider/path_provider_platform_interface/CHANGELOG.md +++ b/packages/path_provider/path_provider_platform_interface/CHANGELOG.md @@ -1,4 +1,4 @@ -## 2.0.0 +## 1.1.0 * Rename enum to StorageDirectory for backwards compatibility. diff --git a/packages/path_provider/path_provider_platform_interface/pubspec.yaml b/packages/path_provider/path_provider_platform_interface/pubspec.yaml index f0e0e376d1ed..bac671cb60d6 100644 --- a/packages/path_provider/path_provider_platform_interface/pubspec.yaml +++ b/packages/path_provider/path_provider_platform_interface/pubspec.yaml @@ -3,7 +3,7 @@ description: A common platform interface for the path_provider plugin. homepage: https://github.com/flutter/plugins/tree/master/packages/path_provider/path_provider_platform_interface # NOTE: We strongly prefer non-breaking changes, even at the expense of a # less-clean API. See https://flutter.dev/go/platform-interface-breaking-changes -version: 2.0.0 +version: 1.1.0 dependencies: flutter: From c6f36541a8931ba72dfb9b7ed55ca73524e9919b Mon Sep 17 00:00:00 2001 From: Francisco Madgaleno Date: Fri, 28 Feb 2020 10:09:37 -0800 Subject: [PATCH 4/4] Use 1.0.1 --- .../path_provider/path_provider_platform_interface/CHANGELOG.md | 2 +- .../path_provider/path_provider_platform_interface/pubspec.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/path_provider/path_provider_platform_interface/CHANGELOG.md b/packages/path_provider/path_provider_platform_interface/CHANGELOG.md index 82528917c1c7..d577554afe2f 100644 --- a/packages/path_provider/path_provider_platform_interface/CHANGELOG.md +++ b/packages/path_provider/path_provider_platform_interface/CHANGELOG.md @@ -1,4 +1,4 @@ -## 1.1.0 +## 1.0.1 * Rename enum to StorageDirectory for backwards compatibility. diff --git a/packages/path_provider/path_provider_platform_interface/pubspec.yaml b/packages/path_provider/path_provider_platform_interface/pubspec.yaml index bac671cb60d6..72f4b20b7e0c 100644 --- a/packages/path_provider/path_provider_platform_interface/pubspec.yaml +++ b/packages/path_provider/path_provider_platform_interface/pubspec.yaml @@ -3,7 +3,7 @@ description: A common platform interface for the path_provider plugin. homepage: https://github.com/flutter/plugins/tree/master/packages/path_provider/path_provider_platform_interface # NOTE: We strongly prefer non-breaking changes, even at the expense of a # less-clean API. See https://flutter.dev/go/platform-interface-breaking-changes -version: 1.1.0 +version: 1.0.1 dependencies: flutter: