From dd468f9406e79528bbbedb3624769c306df4bf66 Mon Sep 17 00:00:00 2001 From: cg021 Date: Thu, 4 Jun 2020 11:05:12 -0500 Subject: [PATCH 1/2] set message handler to nil on detach from engine --- .../video_player/ios/Classes/FLTVideoPlayerPlugin.m | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/packages/video_player/video_player/ios/Classes/FLTVideoPlayerPlugin.m b/packages/video_player/video_player/ios/Classes/FLTVideoPlayerPlugin.m index 7dbc1b0bfd11..0917e8ef303b 100644 --- a/packages/video_player/video_player/ios/Classes/FLTVideoPlayerPlugin.m +++ b/packages/video_player/video_player/ios/Classes/FLTVideoPlayerPlugin.m @@ -451,10 +451,7 @@ - (void)detachFromEngineForRegistrar:(NSObject*)registra [player disposeSansEventChannel]; } [_players removeAllObjects]; - // TODO(57151): This should be commented out when 57151's fix lands on stable. - // This is the correct behavior we never did it in the past and the engine - // doesn't currently support it. - // FLTVideoPlayerApiSetup(registrar.messenger, nil); + FLTVideoPlayerApiSetup(registrar.messenger, nil); } - (FLTTextureMessage*)onPlayerSetup:(FLTVideoPlayer*)player From 7a2f26365c06d9abdfa6fe23f6c205602fc3a310 Mon Sep 17 00:00:00 2001 From: cg021 Date: Thu, 4 Jun 2020 11:25:11 -0500 Subject: [PATCH 2/2] update version --- packages/video_player/video_player/CHANGELOG.md | 8 ++++++++ packages/video_player/video_player/pubspec.yaml | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/packages/video_player/video_player/CHANGELOG.md b/packages/video_player/video_player/CHANGELOG.md index 3d22a81d20ce..77776c7edf95 100644 --- a/packages/video_player/video_player/CHANGELOG.md +++ b/packages/video_player/video_player/CHANGELOG.md @@ -1,3 +1,11 @@ +## 0.10.11+2 + +* iOS: Set message handler to nil on detach fron engine. + +## 0.10.11+1 + +* Post-v2 Android embedding cleanups. + ## 0.10.11 * iOS: Fixed crash when detaching from a dying engine. diff --git a/packages/video_player/video_player/pubspec.yaml b/packages/video_player/video_player/pubspec.yaml index 2a4a5b0e9900..03f71bf4f412 100644 --- a/packages/video_player/video_player/pubspec.yaml +++ b/packages/video_player/video_player/pubspec.yaml @@ -4,7 +4,7 @@ description: Flutter plugin for displaying inline video with other Flutter # 0.10.y+z is compatible with 1.0.0, if you land a breaking change bump # the version to 2.0.0. # See more details: https://github.com/flutter/flutter/wiki/Package-migration-to-1.0.0 -version: 0.10.11 +version: 0.10.11+2 homepage: https://github.com/flutter/plugins/tree/master/packages/video_player/video_player flutter: