From 629660a9be66132ac5a9ee8de106e13f4f7edcb8 Mon Sep 17 00:00:00 2001 From: "Ming Lyu (CareF)" Date: Tue, 23 Jun 2020 00:13:20 -0400 Subject: [PATCH 1/3] Fix e2e device pixel ratio --- packages/e2e/lib/e2e.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/e2e/lib/e2e.dart b/packages/e2e/lib/e2e.dart index c2ddb2d6b801..623c8ba51de6 100644 --- a/packages/e2e/lib/e2e.dart +++ b/packages/e2e/lib/e2e.dart @@ -53,7 +53,7 @@ class E2EWidgetsFlutterBinding extends LiveTestWidgetsFlutterBinding { @override ViewConfiguration createViewConfiguration() => - TestViewConfiguration(size: window.physicalSize); + TestViewConfiguration(size: window.physicalSize/window.devicePixelRatio); final Completer _allTestsPassed = Completer(); From 95cd37ad9966715ac4aa4e4067fd1a5d9970c07e Mon Sep 17 00:00:00 2001 From: "Ming Lyu (CareF)" Date: Tue, 23 Jun 2020 00:21:55 -0400 Subject: [PATCH 2/3] Update changelog and version --- packages/e2e/CHANGELOG.md | 4 ++++ packages/e2e/pubspec.yaml | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/e2e/CHANGELOG.md b/packages/e2e/CHANGELOG.md index 725b648dc5a5..0d349965371b 100644 --- a/packages/e2e/CHANGELOG.md +++ b/packages/e2e/CHANGELOG.md @@ -1,3 +1,7 @@ +## 0.5.0+1 + +* Fixed the device pixel ratio problem. + ## 0.5.0 * **Breaking change** by default, tests will use the device window size. diff --git a/packages/e2e/pubspec.yaml b/packages/e2e/pubspec.yaml index 82de42bd5c66..0d4bc99f64f3 100644 --- a/packages/e2e/pubspec.yaml +++ b/packages/e2e/pubspec.yaml @@ -1,6 +1,6 @@ name: e2e description: Runs tests that use the flutter_test API as integration tests. -version: 0.5.0 +version: 0.5.0+1 homepage: https://github.com/flutter/plugins/tree/master/packages/e2e environment: From cb1634e560ea34922d798d69ebcf8da451a1757c Mon Sep 17 00:00:00 2001 From: "Ming Lyu (CareF)" Date: Tue, 23 Jun 2020 09:29:48 -0400 Subject: [PATCH 3/3] Formatting --- packages/e2e/lib/e2e.dart | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/e2e/lib/e2e.dart b/packages/e2e/lib/e2e.dart index 623c8ba51de6..ec1615e904b4 100644 --- a/packages/e2e/lib/e2e.dart +++ b/packages/e2e/lib/e2e.dart @@ -52,8 +52,8 @@ class E2EWidgetsFlutterBinding extends LiveTestWidgetsFlutterBinding { bool get registerTestTextInput => false; @override - ViewConfiguration createViewConfiguration() => - TestViewConfiguration(size: window.physicalSize/window.devicePixelRatio); + ViewConfiguration createViewConfiguration() => TestViewConfiguration( + size: window.physicalSize / window.devicePixelRatio); final Completer _allTestsPassed = Completer();