From 190d8c0aa72fc9b38d088b306e1881f44e5f3a5e Mon Sep 17 00:00:00 2001 From: Marius Preikschat Date: Mon, 7 Sep 2020 20:56:49 +0200 Subject: [PATCH 1/3] pr for [image_picker_for_web] Can't select some video file types (3gp, mp4, possibly others...) #58532 --- .../image_picker_for_web/lib/image_picker_for_web.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/image_picker/image_picker_for_web/lib/image_picker_for_web.dart b/packages/image_picker/image_picker_for_web/lib/image_picker_for_web.dart index ce99dd6d5fc6..f7a7eab4713f 100644 --- a/packages/image_picker/image_picker_for_web/lib/image_picker_for_web.dart +++ b/packages/image_picker/image_picker_for_web/lib/image_picker_for_web.dart @@ -8,7 +8,7 @@ import 'package:image_picker_platform_interface/image_picker_platform_interface. final String _kImagePickerInputsDomId = '__image_picker_web-file-input'; final String _kAcceptImageMimeType = 'image/*'; // TODO The value below seems to not be enough for Safari (https://github.com/flutter/flutter/issues/58532) -final String _kAcceptVideoMimeType = 'video/*'; +final String _kAcceptVideoMimeType = 'video/3gpp,video/x-m4v,video/mp4,video/*'; /// The web implementation of [ImagePickerPlatform]. /// From 8335c50b46663115b757dfe69cee928464bfa73e Mon Sep 17 00:00:00 2001 From: Marius Preikschat Date: Tue, 8 Sep 2020 20:49:35 +0200 Subject: [PATCH 2/3] unecessary comment deleted --- .../image_picker_for_web/lib/image_picker_for_web.dart | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/image_picker/image_picker_for_web/lib/image_picker_for_web.dart b/packages/image_picker/image_picker_for_web/lib/image_picker_for_web.dart index f7a7eab4713f..e50b4aad3c8d 100644 --- a/packages/image_picker/image_picker_for_web/lib/image_picker_for_web.dart +++ b/packages/image_picker/image_picker_for_web/lib/image_picker_for_web.dart @@ -7,7 +7,6 @@ import 'package:image_picker_platform_interface/image_picker_platform_interface. final String _kImagePickerInputsDomId = '__image_picker_web-file-input'; final String _kAcceptImageMimeType = 'image/*'; -// TODO The value below seems to not be enough for Safari (https://github.com/flutter/flutter/issues/58532) final String _kAcceptVideoMimeType = 'video/3gpp,video/x-m4v,video/mp4,video/*'; /// The web implementation of [ImagePickerPlatform]. From 841e2d0cdcbc58ddd0084b4163538bd892dc79f4 Mon Sep 17 00:00:00 2001 From: Marius Preikschat Date: Tue, 8 Sep 2020 21:16:03 +0200 Subject: [PATCH 3/3] updating changelog & pubspec --- packages/image_picker/image_picker_for_web/CHANGELOG.md | 4 ++++ packages/image_picker/image_picker_for_web/pubspec.yaml | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/image_picker/image_picker_for_web/CHANGELOG.md b/packages/image_picker/image_picker_for_web/CHANGELOG.md index 67320bcb3de2..604314240a1e 100644 --- a/packages/image_picker/image_picker_for_web/CHANGELOG.md +++ b/packages/image_picker/image_picker_for_web/CHANGELOG.md @@ -1,3 +1,7 @@ +# 0.1.0+2 + +* Adds Video MIME Types for the safari browser for acception + # 0.1.0+1 * Remove `android` directory. diff --git a/packages/image_picker/image_picker_for_web/pubspec.yaml b/packages/image_picker/image_picker_for_web/pubspec.yaml index 29b9b185cb90..32e89437415e 100644 --- a/packages/image_picker/image_picker_for_web/pubspec.yaml +++ b/packages/image_picker/image_picker_for_web/pubspec.yaml @@ -4,7 +4,7 @@ homepage: https://github.com/flutter/plugins/tree/master/packages/image_picker/i # 0.1.y+z is compatible with 1.0.0, if you land a breaking change bump # the version to 2.0.0. # See more details: https://github.com/flutter/flutter/wiki/Package-migration-to-1.0.0 -version: 0.1.0+1 +version: 0.1.0+2 flutter: plugin: