From 66e75b02ebd77b82b7d5b43de0467f09fbb40306 Mon Sep 17 00:00:00 2001 From: Hamdi Kahloun Date: Fri, 11 Sep 2020 10:13:10 +0100 Subject: [PATCH 1/3] [camera] CameraPlugin.java uses or overrides a deprecated API --- .../src/main/java/io/flutter/plugins/camera/CameraPlugin.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/camera/android/src/main/java/io/flutter/plugins/camera/CameraPlugin.java b/packages/camera/android/src/main/java/io/flutter/plugins/camera/CameraPlugin.java index 2511898038bb..4c08b222ba77 100644 --- a/packages/camera/android/src/main/java/io/flutter/plugins/camera/CameraPlugin.java +++ b/packages/camera/android/src/main/java/io/flutter/plugins/camera/CameraPlugin.java @@ -70,7 +70,7 @@ public void onAttachedToActivity(@NonNull ActivityPluginBinding binding) { binding.getActivity(), flutterPluginBinding.getBinaryMessenger(), binding::addRequestPermissionsResultListener, - flutterPluginBinding.getFlutterEngine().getRenderer()); + flutterPluginBinding.getTextureRegistry()); } @Override From 8155ef6ba9259bdaeeeb8c1057d4622b794961cc Mon Sep 17 00:00:00 2001 From: Hamdi Kahloun Date: Fri, 11 Sep 2020 10:23:03 +0100 Subject: [PATCH 2/3] [camera] CameraPlugin.java uses or overrides a deprecated API --- packages/camera/CHANGELOG.md | 4 ++++ .../src/main/java/io/flutter/plugins/camera/CameraPlugin.java | 1 + packages/camera/pubspec.yaml | 2 +- 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/packages/camera/CHANGELOG.md b/packages/camera/CHANGELOG.md index 2cf34dd55588..d405812bce6a 100644 --- a/packages/camera/CHANGELOG.md +++ b/packages/camera/CHANGELOG.md @@ -1,3 +1,7 @@ +## 0.5.8+6 + +* Avoiding uses or overrides a deprecated API in CameraPlugin.java. + ## 0.5.8+5 * Fix compilation/availability issues on iOS. diff --git a/packages/camera/android/src/main/java/io/flutter/plugins/camera/CameraPlugin.java b/packages/camera/android/src/main/java/io/flutter/plugins/camera/CameraPlugin.java index 4c08b222ba77..151dd4621af8 100644 --- a/packages/camera/android/src/main/java/io/flutter/plugins/camera/CameraPlugin.java +++ b/packages/camera/android/src/main/java/io/flutter/plugins/camera/CameraPlugin.java @@ -66,6 +66,7 @@ public void onDetachedFromEngine(@NonNull FlutterPluginBinding binding) { @Override public void onAttachedToActivity(@NonNull ActivityPluginBinding binding) { + /// getFlutterEngine() is deprecated maybeStartListening( binding.getActivity(), flutterPluginBinding.getBinaryMessenger(), diff --git a/packages/camera/pubspec.yaml b/packages/camera/pubspec.yaml index 01c7907792b2..9d1f7880df2d 100644 --- a/packages/camera/pubspec.yaml +++ b/packages/camera/pubspec.yaml @@ -2,7 +2,7 @@ name: camera description: A Flutter plugin for getting information about and controlling the camera on Android and iOS. Supports previewing the camera feed, capturing images, capturing video, and streaming image buffers to dart. -version: 0.5.8+5 +version: 0.5.8+6 homepage: https://github.com/flutter/plugins/tree/master/packages/camera From 50e12de84c4becd6137a5922ee45c7516ac5a4c4 Mon Sep 17 00:00:00 2001 From: Hamdi Kahloun Date: Sun, 13 Sep 2020 11:44:19 +0100 Subject: [PATCH 3/3] Handle deprecation & unchecked warning as error --- packages/camera/android/build.gradle | 5 +++++ .../main/java/io/flutter/plugins/camera/CameraPlugin.java | 1 - 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/camera/android/build.gradle b/packages/camera/android/build.gradle index 95f5a22cfb6d..3ff98a8d7f47 100644 --- a/packages/camera/android/build.gradle +++ b/packages/camera/android/build.gradle @@ -1,5 +1,6 @@ group 'io.flutter.plugins.camera' version '1.0-SNAPSHOT' +def args = ["-Xlint:deprecation","-Xlint:unchecked","-Werror"] buildscript { repositories { @@ -19,6 +20,10 @@ rootProject.allprojects { } } +project.getTasks().withType(JavaCompile){ + options.compilerArgs.addAll(args) +} + apply plugin: 'com.android.library' android { diff --git a/packages/camera/android/src/main/java/io/flutter/plugins/camera/CameraPlugin.java b/packages/camera/android/src/main/java/io/flutter/plugins/camera/CameraPlugin.java index 151dd4621af8..4c08b222ba77 100644 --- a/packages/camera/android/src/main/java/io/flutter/plugins/camera/CameraPlugin.java +++ b/packages/camera/android/src/main/java/io/flutter/plugins/camera/CameraPlugin.java @@ -66,7 +66,6 @@ public void onDetachedFromEngine(@NonNull FlutterPluginBinding binding) { @Override public void onAttachedToActivity(@NonNull ActivityPluginBinding binding) { - /// getFlutterEngine() is deprecated maybeStartListening( binding.getActivity(), flutterPluginBinding.getBinaryMessenger(),