From f46af7ba94f4a97422606fa74d837a5364d2193f Mon Sep 17 00:00:00 2001 From: Hamdi Kahloun Date: Fri, 11 Sep 2020 10:40:16 +0100 Subject: [PATCH 1/2] [video_player] VideoPlayerPlugin.java uses or overrides a deprecated API --- packages/video_player/video_player/CHANGELOG.md | 4 ++++ .../io/flutter/plugins/videoplayer/VideoPlayerPlugin.java | 3 ++- packages/video_player/video_player/pubspec.yaml | 2 +- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/packages/video_player/video_player/CHANGELOG.md b/packages/video_player/video_player/CHANGELOG.md index 35f50419f823..fb26e31c4a45 100644 --- a/packages/video_player/video_player/CHANGELOG.md +++ b/packages/video_player/video_player/CHANGELOG.md @@ -1,3 +1,7 @@ +## 0.10.12+3 + +* Avoiding uses or overrides a deprecated API in `VideoPlayerPlugin` class. + ## 0.10.12+2 * Fix `setMixWithOthers` test. diff --git a/packages/video_player/video_player/android/src/main/java/io/flutter/plugins/videoplayer/VideoPlayerPlugin.java b/packages/video_player/video_player/android/src/main/java/io/flutter/plugins/videoplayer/VideoPlayerPlugin.java index a22a4f2d7ae4..f76d7362657b 100644 --- a/packages/video_player/video_player/android/src/main/java/io/flutter/plugins/videoplayer/VideoPlayerPlugin.java +++ b/packages/video_player/video_player/android/src/main/java/io/flutter/plugins/videoplayer/VideoPlayerPlugin.java @@ -54,13 +54,14 @@ public static void registerWith(Registrar registrar) { @Override public void onAttachedToEngine(FlutterPluginBinding binding) { + /// getFlutterEngine() is deprecated this.flutterState = new FlutterState( binding.getApplicationContext(), binding.getBinaryMessenger(), FlutterMain::getLookupKeyForAsset, FlutterMain::getLookupKeyForAsset, - binding.getFlutterEngine().getRenderer()); + binding.getTextureRegistry()); flutterState.startListening(this, binding.getBinaryMessenger()); } diff --git a/packages/video_player/video_player/pubspec.yaml b/packages/video_player/video_player/pubspec.yaml index 04c7c6ba3ddb..1d46ea7ebbf9 100644 --- a/packages/video_player/video_player/pubspec.yaml +++ b/packages/video_player/video_player/pubspec.yaml @@ -4,7 +4,7 @@ description: Flutter plugin for displaying inline video with other Flutter # 0.10.y+z is compatible with 1.0.0, if you land a breaking change bump # the version to 2.0.0. # See more details: https://github.com/flutter/flutter/wiki/Package-migration-to-1.0.0 -version: 0.10.12+2 +version: 0.10.12+3 homepage: https://github.com/flutter/plugins/tree/master/packages/video_player/video_player flutter: From 9d68933c8db2852295cfa928123850140b9b5567 Mon Sep 17 00:00:00 2001 From: Hamdi Kahloun Date: Sun, 13 Sep 2020 12:00:28 +0100 Subject: [PATCH 2/2] Handle deprecation & unchecked warning as error --- packages/video_player/video_player/android/build.gradle | 5 +++++ .../io/flutter/plugins/videoplayer/VideoPlayerPlugin.java | 1 - 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/video_player/video_player/android/build.gradle b/packages/video_player/video_player/android/build.gradle index edbb4c7acce4..12725f3f7142 100644 --- a/packages/video_player/video_player/android/build.gradle +++ b/packages/video_player/video_player/android/build.gradle @@ -1,5 +1,6 @@ group 'io.flutter.plugins.videoplayer' version '1.0-SNAPSHOT' +def args = ["-Xlint:deprecation","-Xlint:unchecked","-Werror"] buildscript { repositories { @@ -19,6 +20,10 @@ rootProject.allprojects { } } +project.getTasks().withType(JavaCompile){ + options.compilerArgs.addAll(args) +} + apply plugin: 'com.android.library' android { diff --git a/packages/video_player/video_player/android/src/main/java/io/flutter/plugins/videoplayer/VideoPlayerPlugin.java b/packages/video_player/video_player/android/src/main/java/io/flutter/plugins/videoplayer/VideoPlayerPlugin.java index f76d7362657b..77fd10a7a69b 100644 --- a/packages/video_player/video_player/android/src/main/java/io/flutter/plugins/videoplayer/VideoPlayerPlugin.java +++ b/packages/video_player/video_player/android/src/main/java/io/flutter/plugins/videoplayer/VideoPlayerPlugin.java @@ -54,7 +54,6 @@ public static void registerWith(Registrar registrar) { @Override public void onAttachedToEngine(FlutterPluginBinding binding) { - /// getFlutterEngine() is deprecated this.flutterState = new FlutterState( binding.getApplicationContext(),