From c662d4cc813c7eb5008230389ee85f9315d9e184 Mon Sep 17 00:00:00 2001 From: valconetti Date: Fri, 11 Sep 2020 15:08:13 +0200 Subject: [PATCH 1/7] Updated documentation of getImage() to include information about Android's impossibility to specify camera --- packages/image_picker/image_picker/lib/image_picker.dart | 3 ++- .../lib/src/platform_interface/image_picker_platform.dart | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/image_picker/image_picker/lib/image_picker.dart b/packages/image_picker/image_picker/lib/image_picker.dart index 7dd7e8e52469..652426c5df74 100755 --- a/packages/image_picker/image_picker/lib/image_picker.dart +++ b/packages/image_picker/image_picker/lib/image_picker.dart @@ -87,7 +87,8 @@ class ImagePicker { /// /// Use `preferredCameraDevice` to specify the camera to use when the `source` is [ImageSource.camera]. /// The `preferredCameraDevice` is ignored when `source` is [ImageSource.gallery]. It is also ignored if the chosen camera is not supported on the device. - /// Defaults to [CameraDevice.rear]. + /// Defaults to [CameraDevice.rear]. Since Android has no documented parameter for an intent to specify if the front or rear camera should be opened, this + /// function is not guaranteed to work on an Android device. /// /// In Android, the MainActivity can be destroyed for various reasons. If that happens, the result will be lost /// in this call. You can then call [getLostData] when your app relaunches to retrieve the lost data. diff --git a/packages/image_picker/image_picker_platform_interface/lib/src/platform_interface/image_picker_platform.dart b/packages/image_picker/image_picker_platform_interface/lib/src/platform_interface/image_picker_platform.dart index 94be4c2f2ab1..f9faa95ece57 100644 --- a/packages/image_picker/image_picker_platform_interface/lib/src/platform_interface/image_picker_platform.dart +++ b/packages/image_picker/image_picker_platform_interface/lib/src/platform_interface/image_picker_platform.dart @@ -132,7 +132,8 @@ abstract class ImagePickerPlatform extends PlatformInterface { /// /// Use `preferredCameraDevice` to specify the camera to use when the `source` is [ImageSource.camera]. /// The `preferredCameraDevice` is ignored when `source` is [ImageSource.gallery]. It is also ignored if the chosen camera is not supported on the device. - /// Defaults to [CameraDevice.rear]. + /// Defaults to [CameraDevice.rear]. Since Android has no documented parameter for an intent to specify if the front or rear camera should be opened, this + /// function is not guaranteed to work on an Android device. /// /// In Android, the MainActivity can be destroyed for various reasons. If that happens, the result will be lost /// in this call. You can then call [retrieveLostData] when your app relaunches to retrieve the lost data. From 4adfbcb581dc76188d95ea71b63cb64acf5788f1 Mon Sep 17 00:00:00 2001 From: valconetti Date: Fri, 11 Sep 2020 15:21:52 +0200 Subject: [PATCH 2/7] Update pubspec.yaml en CHANGELOG.md version --- packages/image_picker/image_picker/CHANGELOG.md | 4 ++++ packages/image_picker/image_picker/pubspec.yaml | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/image_picker/image_picker/CHANGELOG.md b/packages/image_picker/image_picker/CHANGELOG.md index 07447db130ca..561718ecf357 100644 --- a/packages/image_picker/image_picker/CHANGELOG.md +++ b/packages/image_picker/image_picker/CHANGELOG.md @@ -1,3 +1,7 @@ +## 0.6.7+8 + +* Update documentation of getImage() about Android's disability to preference front/rear camera + ## 0.6.7+7 * Updating documentation to use isEmpty check. diff --git a/packages/image_picker/image_picker/pubspec.yaml b/packages/image_picker/image_picker/pubspec.yaml index 91338f1e22ee..5a0dfdafe8c2 100755 --- a/packages/image_picker/image_picker/pubspec.yaml +++ b/packages/image_picker/image_picker/pubspec.yaml @@ -2,7 +2,7 @@ name: image_picker description: Flutter plugin for selecting images from the Android and iOS image library, and taking new pictures with the camera. homepage: https://github.com/flutter/plugins/tree/master/packages/image_picker/image_picker -version: 0.6.7+7 +version: 0.6.7+8 flutter: plugin: From 9be07573321b02e1762714681c696cc1c6457d24 Mon Sep 17 00:00:00 2001 From: Anniek Date: Wed, 16 Sep 2020 11:37:16 +0200 Subject: [PATCH 3/7] Update packages/image_picker/image_picker/pubspec.yaml version Co-authored-by: Maurits van Beusekom --- packages/image_picker/image_picker/pubspec.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/image_picker/image_picker/pubspec.yaml b/packages/image_picker/image_picker/pubspec.yaml index 5a0dfdafe8c2..6794071a3e65 100755 --- a/packages/image_picker/image_picker/pubspec.yaml +++ b/packages/image_picker/image_picker/pubspec.yaml @@ -2,7 +2,7 @@ name: image_picker description: Flutter plugin for selecting images from the Android and iOS image library, and taking new pictures with the camera. homepage: https://github.com/flutter/plugins/tree/master/packages/image_picker/image_picker -version: 0.6.7+8 +version: 0.6.8 flutter: plugin: From b63982d25b0d107d183146efc05c9cae86b2a890 Mon Sep 17 00:00:00 2001 From: Anniek Date: Wed, 16 Sep 2020 11:37:31 +0200 Subject: [PATCH 4/7] Update packages/image_picker/image_picker/CHANGELOG.md version Co-authored-by: Maurits van Beusekom --- packages/image_picker/image_picker/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/image_picker/image_picker/CHANGELOG.md b/packages/image_picker/image_picker/CHANGELOG.md index 561718ecf357..fe49522ce445 100644 --- a/packages/image_picker/image_picker/CHANGELOG.md +++ b/packages/image_picker/image_picker/CHANGELOG.md @@ -1,4 +1,4 @@ -## 0.6.7+8 +## 0.6.8 * Update documentation of getImage() about Android's disability to preference front/rear camera From 945fa26ac7138811cec3d3ee91ac96c2ac4bbf92 Mon Sep 17 00:00:00 2001 From: Maurits van Beusekom Date: Wed, 16 Sep 2020 23:53:19 +0200 Subject: [PATCH 5/7] Process feedback on pull-request --- packages/image_picker/image_picker/CHANGELOG.md | 4 ++-- packages/image_picker/image_picker/lib/image_picker.dart | 7 +++++-- packages/image_picker/image_picker/pubspec.yaml | 2 +- .../image_picker_platform_interface/CHANGELOG.md | 4 ++++ .../lib/src/platform_interface/image_picker_platform.dart | 7 +++++-- .../image_picker_platform_interface/pubspec.yaml | 2 +- 6 files changed, 18 insertions(+), 8 deletions(-) diff --git a/packages/image_picker/image_picker/CHANGELOG.md b/packages/image_picker/image_picker/CHANGELOG.md index fe49522ce445..100fe9989354 100644 --- a/packages/image_picker/image_picker/CHANGELOG.md +++ b/packages/image_picker/image_picker/CHANGELOG.md @@ -1,6 +1,6 @@ -## 0.6.8 +## 0.6.7+8 -* Update documentation of getImage() about Android's disability to preference front/rear camera +* Update documentation of getImage() about Android's disability to preference front/rear camera. ## 0.6.7+7 diff --git a/packages/image_picker/image_picker/lib/image_picker.dart b/packages/image_picker/image_picker/lib/image_picker.dart index 652426c5df74..58cb4935c1f8 100755 --- a/packages/image_picker/image_picker/lib/image_picker.dart +++ b/packages/image_picker/image_picker/lib/image_picker.dart @@ -87,8 +87,11 @@ class ImagePicker { /// /// Use `preferredCameraDevice` to specify the camera to use when the `source` is [ImageSource.camera]. /// The `preferredCameraDevice` is ignored when `source` is [ImageSource.gallery]. It is also ignored if the chosen camera is not supported on the device. - /// Defaults to [CameraDevice.rear]. Since Android has no documented parameter for an intent to specify if the front or rear camera should be opened, this - /// function is not guaranteed to work on an Android device. + /// Defaults to [CameraDevice.rear]. + /// + /// Note that Android has no documented parameter for an intent to specify if + /// the front or rear camera should be opened, this function is not guaranteed + /// to work on an Android device. /// /// In Android, the MainActivity can be destroyed for various reasons. If that happens, the result will be lost /// in this call. You can then call [getLostData] when your app relaunches to retrieve the lost data. diff --git a/packages/image_picker/image_picker/pubspec.yaml b/packages/image_picker/image_picker/pubspec.yaml index 6794071a3e65..5a0dfdafe8c2 100755 --- a/packages/image_picker/image_picker/pubspec.yaml +++ b/packages/image_picker/image_picker/pubspec.yaml @@ -2,7 +2,7 @@ name: image_picker description: Flutter plugin for selecting images from the Android and iOS image library, and taking new pictures with the camera. homepage: https://github.com/flutter/plugins/tree/master/packages/image_picker/image_picker -version: 0.6.8 +version: 0.6.7+8 flutter: plugin: diff --git a/packages/image_picker/image_picker_platform_interface/CHANGELOG.md b/packages/image_picker/image_picker_platform_interface/CHANGELOG.md index 0a238bcd51bf..33c1cf8ddba7 100644 --- a/packages/image_picker/image_picker_platform_interface/CHANGELOG.md +++ b/packages/image_picker/image_picker_platform_interface/CHANGELOG.md @@ -1,3 +1,7 @@ +## 1.1.1 + +* Update documentation of getImage() about Android's disability to preference front/rear camera. + ## 1.1.0 * Introduce PickedFile type for the new API. diff --git a/packages/image_picker/image_picker_platform_interface/lib/src/platform_interface/image_picker_platform.dart b/packages/image_picker/image_picker_platform_interface/lib/src/platform_interface/image_picker_platform.dart index f9faa95ece57..fadb1dd3af89 100644 --- a/packages/image_picker/image_picker_platform_interface/lib/src/platform_interface/image_picker_platform.dart +++ b/packages/image_picker/image_picker_platform_interface/lib/src/platform_interface/image_picker_platform.dart @@ -132,8 +132,11 @@ abstract class ImagePickerPlatform extends PlatformInterface { /// /// Use `preferredCameraDevice` to specify the camera to use when the `source` is [ImageSource.camera]. /// The `preferredCameraDevice` is ignored when `source` is [ImageSource.gallery]. It is also ignored if the chosen camera is not supported on the device. - /// Defaults to [CameraDevice.rear]. Since Android has no documented parameter for an intent to specify if the front or rear camera should be opened, this - /// function is not guaranteed to work on an Android device. + /// Defaults to [CameraDevice.rear]. + /// + /// Note that Android has no documented parameter for an intent to specify if + /// the front or rear camera should be opened, this function is not guaranteed + /// to work on an Android device. /// /// In Android, the MainActivity can be destroyed for various reasons. If that happens, the result will be lost /// in this call. You can then call [retrieveLostData] when your app relaunches to retrieve the lost data. diff --git a/packages/image_picker/image_picker_platform_interface/pubspec.yaml b/packages/image_picker/image_picker_platform_interface/pubspec.yaml index 946cf80c5187..2a5f9d0380d0 100644 --- a/packages/image_picker/image_picker_platform_interface/pubspec.yaml +++ b/packages/image_picker/image_picker_platform_interface/pubspec.yaml @@ -3,7 +3,7 @@ description: A common platform interface for the image_picker plugin. homepage: https://github.com/flutter/plugins/tree/master/packages/image_picker/image_picker_platform_interface # NOTE: We strongly prefer non-breaking changes, even at the expense of a # less-clean API. See https://flutter.dev/go/platform-interface-breaking-changes -version: 1.1.0 +version: 1.1.1 dependencies: flutter: From 5ca7968fcf627d9723297500eece3ec3df1c0c93 Mon Sep 17 00:00:00 2001 From: Maurits van Beusekom Date: Thu, 17 Sep 2020 08:02:38 +0200 Subject: [PATCH 6/7] Fix formatting issues --- packages/image_picker/image_picker/lib/image_picker.dart | 2 +- .../lib/src/platform_interface/image_picker_platform.dart | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/image_picker/image_picker/lib/image_picker.dart b/packages/image_picker/image_picker/lib/image_picker.dart index 58cb4935c1f8..73726c2e532b 100755 --- a/packages/image_picker/image_picker/lib/image_picker.dart +++ b/packages/image_picker/image_picker/lib/image_picker.dart @@ -88,7 +88,7 @@ class ImagePicker { /// Use `preferredCameraDevice` to specify the camera to use when the `source` is [ImageSource.camera]. /// The `preferredCameraDevice` is ignored when `source` is [ImageSource.gallery]. It is also ignored if the chosen camera is not supported on the device. /// Defaults to [CameraDevice.rear]. - /// + /// /// Note that Android has no documented parameter for an intent to specify if /// the front or rear camera should be opened, this function is not guaranteed /// to work on an Android device. diff --git a/packages/image_picker/image_picker_platform_interface/lib/src/platform_interface/image_picker_platform.dart b/packages/image_picker/image_picker_platform_interface/lib/src/platform_interface/image_picker_platform.dart index fadb1dd3af89..d027888c2960 100644 --- a/packages/image_picker/image_picker_platform_interface/lib/src/platform_interface/image_picker_platform.dart +++ b/packages/image_picker/image_picker_platform_interface/lib/src/platform_interface/image_picker_platform.dart @@ -132,8 +132,8 @@ abstract class ImagePickerPlatform extends PlatformInterface { /// /// Use `preferredCameraDevice` to specify the camera to use when the `source` is [ImageSource.camera]. /// The `preferredCameraDevice` is ignored when `source` is [ImageSource.gallery]. It is also ignored if the chosen camera is not supported on the device. - /// Defaults to [CameraDevice.rear]. - /// + /// Defaults to [CameraDevice.rear]. + /// /// Note that Android has no documented parameter for an intent to specify if /// the front or rear camera should be opened, this function is not guaranteed /// to work on an Android device. From b3a6b1904359e65e93a8832a9466234001ab20bd Mon Sep 17 00:00:00 2001 From: Maurits van Beusekom Date: Thu, 17 Sep 2020 08:07:12 +0200 Subject: [PATCH 7/7] Revert comment on new line --- packages/image_picker/image_picker/lib/image_picker.dart | 4 +--- .../lib/src/platform_interface/image_picker_platform.dart | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/packages/image_picker/image_picker/lib/image_picker.dart b/packages/image_picker/image_picker/lib/image_picker.dart index 73726c2e532b..6fe513dc25f1 100755 --- a/packages/image_picker/image_picker/lib/image_picker.dart +++ b/packages/image_picker/image_picker/lib/image_picker.dart @@ -87,9 +87,7 @@ class ImagePicker { /// /// Use `preferredCameraDevice` to specify the camera to use when the `source` is [ImageSource.camera]. /// The `preferredCameraDevice` is ignored when `source` is [ImageSource.gallery]. It is also ignored if the chosen camera is not supported on the device. - /// Defaults to [CameraDevice.rear]. - /// - /// Note that Android has no documented parameter for an intent to specify if + /// Defaults to [CameraDevice.rear]. Note that Android has no documented parameter for an intent to specify if /// the front or rear camera should be opened, this function is not guaranteed /// to work on an Android device. /// diff --git a/packages/image_picker/image_picker_platform_interface/lib/src/platform_interface/image_picker_platform.dart b/packages/image_picker/image_picker_platform_interface/lib/src/platform_interface/image_picker_platform.dart index d027888c2960..38bf0858dd6f 100644 --- a/packages/image_picker/image_picker_platform_interface/lib/src/platform_interface/image_picker_platform.dart +++ b/packages/image_picker/image_picker_platform_interface/lib/src/platform_interface/image_picker_platform.dart @@ -132,9 +132,7 @@ abstract class ImagePickerPlatform extends PlatformInterface { /// /// Use `preferredCameraDevice` to specify the camera to use when the `source` is [ImageSource.camera]. /// The `preferredCameraDevice` is ignored when `source` is [ImageSource.gallery]. It is also ignored if the chosen camera is not supported on the device. - /// Defaults to [CameraDevice.rear]. - /// - /// Note that Android has no documented parameter for an intent to specify if + /// Defaults to [CameraDevice.rear]. Note that Android has no documented parameter for an intent to specify if /// the front or rear camera should be opened, this function is not guaranteed /// to work on an Android device. ///