From 29ce4381ea713438bc0dac1fcd56c9f26465ff3d Mon Sep 17 00:00:00 2001 From: Sempakonka <47318358+Sempakonka@users.noreply.github.com> Date: Wed, 30 Sep 2020 14:01:15 +0200 Subject: [PATCH 1/3] Improved documentation of the `headers` parameter --- packages/url_launcher/url_launcher/CHANGELOG.md | 4 ++++ packages/url_launcher/url_launcher/lib/url_launcher.dart | 3 +++ packages/url_launcher/url_launcher/pubspec.yaml | 2 +- 3 files changed, 8 insertions(+), 1 deletion(-) diff --git a/packages/url_launcher/url_launcher/CHANGELOG.md b/packages/url_launcher/url_launcher/CHANGELOG.md index 8a15a2b9a6b1..547e17d43cb1 100644 --- a/packages/url_launcher/url_launcher/CHANGELOG.md +++ b/packages/url_launcher/url_launcher/CHANGELOG.md @@ -1,3 +1,7 @@ +## 5.7.5 + +* Improved documentation of the `headers` parameter. + ## 5.7.4 * Update android compileSdkVersion to 29. diff --git a/packages/url_launcher/url_launcher/lib/url_launcher.dart b/packages/url_launcher/url_launcher/lib/url_launcher.dart index ccc6833f0941..7cd9d0fc250e 100644 --- a/packages/url_launcher/url_launcher/lib/url_launcher.dart +++ b/packages/url_launcher/url_launcher/lib/url_launcher.dart @@ -44,6 +44,9 @@ import 'package:url_launcher_platform_interface/url_launcher_platform_interface. /// [enableDomStorage] is an Android only setting. If true, WebView enable /// DOM storage. /// [headers] is an Android only setting that adds headers to the WebView. +/// Adding headers without using a WebView is not fully supported. +/// Some Browsers do not support adding headers. Some browsers partially +/// support it, depending on the browser version. /// [webOnlyWindowName] is an Web only setting . _blank opens the new url in new tab , /// _self opens the new url in current tab. /// Default behaviour is to open the url in new tab. diff --git a/packages/url_launcher/url_launcher/pubspec.yaml b/packages/url_launcher/url_launcher/pubspec.yaml index 49d52eecf69d..56a6f844bd67 100644 --- a/packages/url_launcher/url_launcher/pubspec.yaml +++ b/packages/url_launcher/url_launcher/pubspec.yaml @@ -2,7 +2,7 @@ name: url_launcher description: Flutter plugin for launching a URL on Android and iOS. Supports web, phone, SMS, and email schemes. homepage: https://github.com/flutter/plugins/tree/master/packages/url_launcher/url_launcher -version: 5.7.4 +version: 5.7.5 flutter: plugin: From a4328943b5e2d9614e1c13393877dd3c16240c50 Mon Sep 17 00:00:00 2001 From: Sempakonka <47318358+Sempakonka@users.noreply.github.com> Date: Fri, 9 Oct 2020 10:25:02 +0200 Subject: [PATCH 2/3] Update CHANGELOG.md --- packages/url_launcher/url_launcher/CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/url_launcher/url_launcher/CHANGELOG.md b/packages/url_launcher/url_launcher/CHANGELOG.md index 547e17d43cb1..9b153b47c3ae 100644 --- a/packages/url_launcher/url_launcher/CHANGELOG.md +++ b/packages/url_launcher/url_launcher/CHANGELOG.md @@ -1,4 +1,8 @@ +<<<<<<< HEAD ## 5.7.5 +======= +## 5.7.3 +>>>>>>> a741c59a... Update CHANGELOG.md * Improved documentation of the `headers` parameter. From 332007855267ddf5b73e629775a64be1315448dc Mon Sep 17 00:00:00 2001 From: Sempakonka <47318358+Sempakonka@users.noreply.github.com> Date: Thu, 15 Oct 2020 16:18:21 +0200 Subject: [PATCH 3/3] improved documentation. updated version number --- packages/url_launcher/url_launcher/CHANGELOG.md | 4 ---- packages/url_launcher/url_launcher/lib/url_launcher.dart | 6 +++--- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/packages/url_launcher/url_launcher/CHANGELOG.md b/packages/url_launcher/url_launcher/CHANGELOG.md index 9b153b47c3ae..547e17d43cb1 100644 --- a/packages/url_launcher/url_launcher/CHANGELOG.md +++ b/packages/url_launcher/url_launcher/CHANGELOG.md @@ -1,8 +1,4 @@ -<<<<<<< HEAD ## 5.7.5 -======= -## 5.7.3 ->>>>>>> a741c59a... Update CHANGELOG.md * Improved documentation of the `headers` parameter. diff --git a/packages/url_launcher/url_launcher/lib/url_launcher.dart b/packages/url_launcher/url_launcher/lib/url_launcher.dart index 7cd9d0fc250e..25aa623a590f 100644 --- a/packages/url_launcher/url_launcher/lib/url_launcher.dart +++ b/packages/url_launcher/url_launcher/lib/url_launcher.dart @@ -44,9 +44,9 @@ import 'package:url_launcher_platform_interface/url_launcher_platform_interface. /// [enableDomStorage] is an Android only setting. If true, WebView enable /// DOM storage. /// [headers] is an Android only setting that adds headers to the WebView. -/// Adding headers without using a WebView is not fully supported. -/// Some Browsers do not support adding headers. Some browsers partially -/// support it, depending on the browser version. +/// When not using a WebView, the header information is passed to the browser, +/// some Android browsers do not support the [Browser.EXTRA_HEADERS](https://developer.android.com/reference/android/provider/Browser#EXTRA_HEADERS) +/// intent extra and the header information will be lost. /// [webOnlyWindowName] is an Web only setting . _blank opens the new url in new tab , /// _self opens the new url in current tab. /// Default behaviour is to open the url in new tab.