From 07270364e643bc4919cdd019f80ff6cd07e903ed Mon Sep 17 00:00:00 2001 From: valconetti Date: Thu, 8 Oct 2020 12:05:35 +0200 Subject: [PATCH 1/5] Deprecation warning suppressed --- .../java/io/flutter/plugins/urllauncher/WebViewActivity.java | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/url_launcher/url_launcher/android/src/main/java/io/flutter/plugins/urllauncher/WebViewActivity.java b/packages/url_launcher/url_launcher/android/src/main/java/io/flutter/plugins/urllauncher/WebViewActivity.java index 98c5613e6c62..3253f8df7e02 100644 --- a/packages/url_launcher/url_launcher/android/src/main/java/io/flutter/plugins/urllauncher/WebViewActivity.java +++ b/packages/url_launcher/url_launcher/android/src/main/java/io/flutter/plugins/urllauncher/WebViewActivity.java @@ -87,6 +87,7 @@ public boolean shouldOverrideUrlLoading( } @Override + @SuppressWarnings("deprecation") public boolean shouldOverrideUrlLoading(WebView view, String url) { webview.loadUrl(url); return true; From 7e86e7696f150c0c3c1e32975a02eefbbf519e69 Mon Sep 17 00:00:00 2001 From: valconetti Date: Thu, 8 Oct 2020 13:55:36 +0200 Subject: [PATCH 2/5] Changed CHANGELOG.md and pubspec.yaml accordingly --- packages/url_launcher/url_launcher/CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/url_launcher/url_launcher/CHANGELOG.md b/packages/url_launcher/url_launcher/CHANGELOG.md index c86100784782..8fbaff75dc6b 100644 --- a/packages/url_launcher/url_launcher/CHANGELOG.md +++ b/packages/url_launcher/url_launcher/CHANGELOG.md @@ -1,3 +1,7 @@ +## 5.7.4 + +* Suppress deprecation warning on the `shouldOverrideUrlLoading` method on Android of the `FlutterWebChromeClient` class. + ## 5.7.3 * Check in linux/ directory for example/ From 35e77977c3ef79dfbd5d35c35a45022904c211f4 Mon Sep 17 00:00:00 2001 From: valconetti Date: Thu, 8 Oct 2020 14:03:14 +0200 Subject: [PATCH 3/5] Added explanation --- .../io/flutter/plugins/urllauncher/WebViewActivity.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/url_launcher/url_launcher/android/src/main/java/io/flutter/plugins/urllauncher/WebViewActivity.java b/packages/url_launcher/url_launcher/android/src/main/java/io/flutter/plugins/urllauncher/WebViewActivity.java index 3253f8df7e02..f86740f14b01 100644 --- a/packages/url_launcher/url_launcher/android/src/main/java/io/flutter/plugins/urllauncher/WebViewActivity.java +++ b/packages/url_launcher/url_launcher/android/src/main/java/io/flutter/plugins/urllauncher/WebViewActivity.java @@ -86,8 +86,12 @@ public boolean shouldOverrideUrlLoading( return true; } - @Override + /* + * This method is deprecated in API 24. Still overridden to support + * earlier Android versions. + */ @SuppressWarnings("deprecation") + @Override public boolean shouldOverrideUrlLoading(WebView view, String url) { webview.loadUrl(url); return true; From 645cf93fec14578712d3233ac1eb3d38747f6f12 Mon Sep 17 00:00:00 2001 From: valconetti Date: Fri, 9 Oct 2020 12:29:47 +0200 Subject: [PATCH 4/5] Fix formatting --- .../io/flutter/plugins/urllauncher/WebViewActivity.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/url_launcher/url_launcher/android/src/main/java/io/flutter/plugins/urllauncher/WebViewActivity.java b/packages/url_launcher/url_launcher/android/src/main/java/io/flutter/plugins/urllauncher/WebViewActivity.java index f86740f14b01..7c6978fd657d 100644 --- a/packages/url_launcher/url_launcher/android/src/main/java/io/flutter/plugins/urllauncher/WebViewActivity.java +++ b/packages/url_launcher/url_launcher/android/src/main/java/io/flutter/plugins/urllauncher/WebViewActivity.java @@ -87,9 +87,9 @@ public boolean shouldOverrideUrlLoading( } /* - * This method is deprecated in API 24. Still overridden to support - * earlier Android versions. - */ + * This method is deprecated in API 24. Still overridden to support + * earlier Android versions. + */ @SuppressWarnings("deprecation") @Override public boolean shouldOverrideUrlLoading(WebView view, String url) { From 4a0b3d5bdcfee001e2734cf73579f842eedb4b8d Mon Sep 17 00:00:00 2001 From: valconetti Date: Fri, 16 Oct 2020 09:26:16 +0200 Subject: [PATCH 5/5] fixed pubspec and merge conflicts --- packages/url_launcher/url_launcher/pubspec.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/url_launcher/url_launcher/pubspec.yaml b/packages/url_launcher/url_launcher/pubspec.yaml index a84a8d069a69..49d52eecf69d 100644 --- a/packages/url_launcher/url_launcher/pubspec.yaml +++ b/packages/url_launcher/url_launcher/pubspec.yaml @@ -2,7 +2,7 @@ name: url_launcher description: Flutter plugin for launching a URL on Android and iOS. Supports web, phone, SMS, and email schemes. homepage: https://github.com/flutter/plugins/tree/master/packages/url_launcher/url_launcher -version: 5.7.3 +version: 5.7.4 flutter: plugin: