From 2c1e70baf0c65d32bcb74541de75143a94afcd7e Mon Sep 17 00:00:00 2001
From: Mehmet Fidanboylu <mehmetf@google.com>
Date: Tue, 8 Dec 2020 17:19:06 -0800
Subject: [PATCH 1/3] [share] Migrate to null-safety

---
 packages/share/CHANGELOG.md         |  4 ++++
 packages/share/lib/share.dart       | 12 ++++++------
 packages/share/pubspec.yaml         | 17 +++++++----------
 packages/share/test/share_test.dart | 18 +-----------------
 4 files changed, 18 insertions(+), 33 deletions(-)

diff --git a/packages/share/CHANGELOG.md b/packages/share/CHANGELOG.md
index 8a3806209c1c..920ae10df962 100644
--- a/packages/share/CHANGELOG.md
+++ b/packages/share/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 1.0.0-nullsafety
+
+* Migrate to null safety.
+
 ## 0.6.5+5
 
 * Update Flutter SDK constraint.
diff --git a/packages/share/lib/share.dart b/packages/share/lib/share.dart
index 4a3ff6f1de09..f15566714857 100644
--- a/packages/share/lib/share.dart
+++ b/packages/share/lib/share.dart
@@ -33,8 +33,8 @@ class Share {
   /// from [MethodChannel].
   static Future<void> share(
     String text, {
-    String subject,
-    Rect sharePositionOrigin,
+    String? subject,
+    Rect? sharePositionOrigin,
   }) {
     assert(text != null);
     assert(text.isNotEmpty);
@@ -67,10 +67,10 @@ class Share {
   /// from [MethodChannel].
   static Future<void> shareFiles(
     List<String> paths, {
-    List<String> mimeTypes,
-    String subject,
-    String text,
-    Rect sharePositionOrigin,
+    List<String>? mimeTypes,
+    String? subject,
+    String? text,
+    Rect? sharePositionOrigin,
   }) {
     assert(paths != null);
     assert(paths.isNotEmpty);
diff --git a/packages/share/pubspec.yaml b/packages/share/pubspec.yaml
index 23644d290473..69d0fdbd5eb8 100644
--- a/packages/share/pubspec.yaml
+++ b/packages/share/pubspec.yaml
@@ -2,10 +2,7 @@ name: share
 description: Flutter plugin for sharing content via the platform share UI, using
   the ACTION_SEND intent on Android and UIActivityViewController on iOS.
 homepage: https://github.com/flutter/plugins/tree/master/packages/share
-# 0.6.y+z is compatible with 1.0.0, if you land a breaking change bump
-# the version to 2.0.0.
-# See more details: https://github.com/flutter/flutter/wiki/Package-migration-to-1.0.0
-version: 0.6.5+5
+version: 2.0.0-nullsafety
 
 flutter:
   plugin:
@@ -17,20 +14,20 @@ flutter:
         pluginClass: FLTSharePlugin
 
 dependencies:
-  meta: ^1.0.5
-  mime: ^0.9.7
+  meta: ^1.3.0-nullsafety.6
+  mime: ^1.0.0-nullsafety.0
   flutter:
     sdk: flutter
 
 dev_dependencies:
-  test: ^1.3.0
-  mockito: ^3.0.0
+  test: ^1.16.0-nullsafety.13
+  mockito: ^4.1.3
   flutter_test:
     sdk: flutter
   integration_test:
     path: ../integration_test
-  pedantic: ^1.8.0
+  pedantic: ^1.10.0-nullsafety.3
 
 environment:
-  sdk: ">=2.1.0 <3.0.0"
   flutter: ">=1.12.13+hotfix.5"
+  sdk: ">=2.12.0-0 <3.0.0"
diff --git a/packages/share/test/share_test.dart b/packages/share/test/share_test.dart
index e862d1baf579..fa9f980beae3 100644
--- a/packages/share/test/share_test.dart
+++ b/packages/share/test/share_test.dart
@@ -15,7 +15,7 @@ import 'package:flutter/services.dart';
 void main() {
   TestWidgetsFlutterBinding.ensureInitialized();
 
-  MockMethodChannel mockChannel;
+  late MockMethodChannel mockChannel;
 
   setUp(() {
     mockChannel = MockMethodChannel();
@@ -26,14 +26,6 @@ void main() {
     });
   });
 
-  test('sharing null fails', () {
-    expect(
-      () => Share.share(null),
-      throwsA(const TypeMatcher<AssertionError>()),
-    );
-    verifyZeroInteractions(mockChannel);
-  });
-
   test('sharing empty fails', () {
     expect(
       () => Share.share(''),
@@ -58,14 +50,6 @@ void main() {
     }));
   });
 
-  test('sharing null file fails', () {
-    expect(
-      () => Share.shareFiles([null]),
-      throwsA(const TypeMatcher<AssertionError>()),
-    );
-    verifyZeroInteractions(mockChannel);
-  });
-
   test('sharing empty file fails', () {
     expect(
       () => Share.shareFiles(['']),

From 2c0217eb12e77f5e89b3f45cbb82d7d5ecb80103 Mon Sep 17 00:00:00 2001
From: Mehmet Fidanboylu <mehmetf@google.com>
Date: Mon, 14 Dec 2020 10:30:41 -0800
Subject: [PATCH 2/3] Add share to exclusion list from stable tests

---
 script/nnbd_plugins.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/script/nnbd_plugins.sh b/script/nnbd_plugins.sh
index 8b73ecc24e99..56eb85f7b758 100644
--- a/script/nnbd_plugins.sh
+++ b/script/nnbd_plugins.sh
@@ -13,6 +13,7 @@ readonly NNBD_PLUGINS_LIST=(
   "local_auth"
   "path_provider"
   "plugin_platform_interface"
+  "share"
   "url_launcher"
   "video_player"
 )

From 63dd76aecc784d6743173dc6b27fbcfe69adbd0d Mon Sep 17 00:00:00 2001
From: Mehmet Fidanboylu <mehmetf@users.noreply.github.com>
Date: Mon, 14 Dec 2020 19:12:07 -0800
Subject: [PATCH 3/3] Update CHANGELOG.md

---
 packages/share/CHANGELOG.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/share/CHANGELOG.md b/packages/share/CHANGELOG.md
index 920ae10df962..86906bbd56be 100644
--- a/packages/share/CHANGELOG.md
+++ b/packages/share/CHANGELOG.md
@@ -1,4 +1,4 @@
-## 1.0.0-nullsafety
+## 2.0.0-nullsafety
 
 * Migrate to null safety.