From 81e0f63c8c94e2f3682ade0712200789ff0b063f Mon Sep 17 00:00:00 2001 From: creativecreatorormaybenot Date: Mon, 11 Jan 2021 14:46:25 +0000 Subject: [PATCH 1/4] [video_player] Fix playback speed resetting on iOS --- packages/video_player/video_player/lib/video_player.dart | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/packages/video_player/video_player/lib/video_player.dart b/packages/video_player/video_player/lib/video_player.dart index ac1645085e36..5a6e56229dfd 100644 --- a/packages/video_player/video_player/lib/video_player.dart +++ b/packages/video_player/video_player/lib/video_player.dart @@ -405,6 +405,14 @@ class VideoPlayerController extends ValueNotifier { return; } _updatePosition(newPosition); + + // It seems that seeking will reset the playback speed on iOS. + // However, we do not know how long to wait before applying the + // playback speed again as the video might be buffering. This is why + // we simply apply it in the timer in order to make sure that we + // always apply the latest playback speed. This does not seem to + // have any performance implications. + await _applyPlaybackSpeed(); }, ); From 25031b59cfb392fcfb0bdc0a3e16289eda121ce3 Mon Sep 17 00:00:00 2001 From: creativecreatorormaybenot Date: Mon, 11 Jan 2021 15:00:45 +0000 Subject: [PATCH 2/4] Bump --- packages/video_player/video_player/CHANGELOG.md | 4 ++++ packages/video_player/video_player/pubspec.yaml | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/video_player/video_player/CHANGELOG.md b/packages/video_player/video_player/CHANGELOG.md index f9bae8dee6e1..a38da4f268ee 100644 --- a/packages/video_player/video_player/CHANGELOG.md +++ b/packages/video_player/video_player/CHANGELOG.md @@ -1,3 +1,7 @@ +## 2.0.0-nullsafety.8 + +* Fixed playback speed resetting on iOS (on seeking and on initialization). + ## 2.0.0-nullsafety.7 * Update the example app: remove the deprecated `RaisedButton` and `FlatButton` widgets. diff --git a/packages/video_player/video_player/pubspec.yaml b/packages/video_player/video_player/pubspec.yaml index e4694195ebde..72fb54b125ea 100644 --- a/packages/video_player/video_player/pubspec.yaml +++ b/packages/video_player/video_player/pubspec.yaml @@ -4,7 +4,7 @@ description: Flutter plugin for displaying inline video with other Flutter # 0.10.y+z is compatible with 1.0.0, if you land a breaking change bump # the version to 2.0.0. # See more details: https://github.com/flutter/flutter/wiki/Package-migration-to-1.0.0 -version: 2.0.0-nullsafety.7 +version: 2.0.0-nullsafety.8 homepage: https://github.com/flutter/plugins/tree/master/packages/video_player/video_player flutter: From 1cb83598d48d1fbbbc2777a976bab3540090ffc0 Mon Sep 17 00:00:00 2001 From: Dennis Kugelmann Date: Fri, 25 Jun 2021 13:56:31 +0200 Subject: [PATCH 3/4] Fix version --- packages/video_player/video_player/pubspec.yaml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/video_player/video_player/pubspec.yaml b/packages/video_player/video_player/pubspec.yaml index ed21a01b3d05..da48e343cfba 100644 --- a/packages/video_player/video_player/pubspec.yaml +++ b/packages/video_player/video_player/pubspec.yaml @@ -1,11 +1,10 @@ name: video_player description: Flutter plugin for displaying inline video with other Flutter widgets on Android, iOS, and web. -version: 2.1.7 homepage: https://github.com/flutter/plugins/tree/master/packages/video_player/video_player repository: https://github.com/flutter/plugins/tree/master/packages/video_player/video_player issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+video_player%22 -version: 2.1.6 +version: 2.1.7 environment: sdk: ">=2.12.0 <3.0.0" From 7962ee1535e8f4f025ca4e5561f3c8c45edca8a7 Mon Sep 17 00:00:00 2001 From: Dennis Kugelmann Date: Fri, 25 Jun 2021 13:56:56 +0200 Subject: [PATCH 4/4] Remove homepage --- packages/video_player/video_player/pubspec.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/video_player/video_player/pubspec.yaml b/packages/video_player/video_player/pubspec.yaml index da48e343cfba..15b2cc9d0963 100644 --- a/packages/video_player/video_player/pubspec.yaml +++ b/packages/video_player/video_player/pubspec.yaml @@ -1,7 +1,6 @@ name: video_player description: Flutter plugin for displaying inline video with other Flutter widgets on Android, iOS, and web. -homepage: https://github.com/flutter/plugins/tree/master/packages/video_player/video_player repository: https://github.com/flutter/plugins/tree/master/packages/video_player/video_player issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+video_player%22 version: 2.1.7