From 45ba44c6d341b186719bf42e8d5dde3fcf962df8 Mon Sep 17 00:00:00 2001 From: Abhishek01039 Date: Fri, 2 Jul 2021 10:06:07 +0530 Subject: [PATCH 1/4] Add const constructor --- packages/quick_actions/quick_actions/lib/quick_actions.dart | 3 +++ 1 file changed, 3 insertions(+) diff --git a/packages/quick_actions/quick_actions/lib/quick_actions.dart b/packages/quick_actions/quick_actions/lib/quick_actions.dart index f90a44e0443d..59d7e2b767ca 100644 --- a/packages/quick_actions/quick_actions/lib/quick_actions.dart +++ b/packages/quick_actions/quick_actions/lib/quick_actions.dart @@ -11,6 +11,9 @@ export 'package:quick_actions_platform_interface/types/types.dart'; /// Quick actions plugin. class QuickActions { + /// const constructor for [QuickActions]. + const QuickActions(); + /// Initializes this plugin. /// /// Call this once before any further interaction with the the plugin. From 0e79abe7f5dc6564caac61879eb20489d17ceef6 Mon Sep 17 00:00:00 2001 From: Abhishek01039 Date: Fri, 9 Jul 2021 10:57:30 +0530 Subject: [PATCH 2/4] Update PR based on comments --- packages/quick_actions/quick_actions/CHANGELOG.md | 4 ++++ packages/quick_actions/quick_actions/lib/quick_actions.dart | 2 +- packages/quick_actions/quick_actions/pubspec.yaml | 2 +- .../quick_actions/test/quick_actions_test.dart | 6 +++--- 4 files changed, 9 insertions(+), 5 deletions(-) diff --git a/packages/quick_actions/quick_actions/CHANGELOG.md b/packages/quick_actions/quick_actions/CHANGELOG.md index 179496476c42..0a86b92a2867 100644 --- a/packages/quick_actions/quick_actions/CHANGELOG.md +++ b/packages/quick_actions/quick_actions/CHANGELOG.md @@ -1,3 +1,7 @@ +## 0.6.0+3 + +* make const constructor for QuickActions. + ## 0.6.0+2 * Migrate maven repository from jcenter to mavenCentral. diff --git a/packages/quick_actions/quick_actions/lib/quick_actions.dart b/packages/quick_actions/quick_actions/lib/quick_actions.dart index 59d7e2b767ca..6907f25729ab 100644 --- a/packages/quick_actions/quick_actions/lib/quick_actions.dart +++ b/packages/quick_actions/quick_actions/lib/quick_actions.dart @@ -11,7 +11,7 @@ export 'package:quick_actions_platform_interface/types/types.dart'; /// Quick actions plugin. class QuickActions { - /// const constructor for [QuickActions]. + /// Creates a new instance of [QuickActions]. const QuickActions(); /// Initializes this plugin. diff --git a/packages/quick_actions/quick_actions/pubspec.yaml b/packages/quick_actions/quick_actions/pubspec.yaml index 7927fcc3b548..2a4fb0c634e0 100644 --- a/packages/quick_actions/quick_actions/pubspec.yaml +++ b/packages/quick_actions/quick_actions/pubspec.yaml @@ -3,7 +3,7 @@ description: Flutter plugin for creating shortcuts on home screen, also known as Quick Actions on iOS and App Shortcuts on Android. repository: https://github.com/flutter/plugins/tree/master/packages/quick_actions issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+quick_actions%22 -version: 0.6.0+2 +version: 0.6.0+3 environment: sdk: ">=2.12.0 <3.0.0" diff --git a/packages/quick_actions/quick_actions/test/quick_actions_test.dart b/packages/quick_actions/quick_actions/test/quick_actions_test.dart index b8d7695735b6..f5498a7d5bd5 100644 --- a/packages/quick_actions/quick_actions/test/quick_actions_test.dart +++ b/packages/quick_actions/quick_actions/test/quick_actions_test.dart @@ -17,7 +17,7 @@ void main() { }); test('initialize() PlatformInterface', () async { - QuickActions quickActions = QuickActions(); + const QuickActions quickActions = QuickActions(); QuickActionHandler handler = (type) {}; await quickActions.initialize(handler); @@ -25,7 +25,7 @@ void main() { }); test('setShortcutItems() PlatformInterface', () { - QuickActions quickActions = QuickActions(); + const QuickActions quickActions = QuickActions(); QuickActionHandler handler = (type) {}; quickActions.initialize(handler); quickActions.setShortcutItems([]); @@ -35,7 +35,7 @@ void main() { }); test('clearShortcutItems() PlatformInterface', () { - QuickActions quickActions = QuickActions(); + const QuickActions quickActions = QuickActions(); QuickActionHandler handler = (type) {}; quickActions.initialize(handler); From 2d837a43862ba2a62af375fe2403c033dd472890 Mon Sep 17 00:00:00 2001 From: Abhishek01039 Date: Fri, 9 Jul 2021 18:04:29 +0530 Subject: [PATCH 3/4] add const constructor test --- packages/quick_actions/quick_actions/CHANGELOG.md | 2 +- .../quick_actions/quick_actions/test/quick_actions_test.dart | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/packages/quick_actions/quick_actions/CHANGELOG.md b/packages/quick_actions/quick_actions/CHANGELOG.md index 0a86b92a2867..a792ee47440f 100644 --- a/packages/quick_actions/quick_actions/CHANGELOG.md +++ b/packages/quick_actions/quick_actions/CHANGELOG.md @@ -1,6 +1,6 @@ ## 0.6.0+3 -* make const constructor for QuickActions. +Added a `const` constructor for the `QuickActions` class, so the plugin will behave as documented in the sample code mentioned in the [README.md](https://github.com/flutter/plugins/blob/59e16a556e273c2d69189b2dcdfa92d101ea6408/packages/quick_actions/quick_actions/README.md). ## 0.6.0+2 diff --git a/packages/quick_actions/quick_actions/test/quick_actions_test.dart b/packages/quick_actions/quick_actions/test/quick_actions_test.dart index f5498a7d5bd5..27d3c81a809a 100644 --- a/packages/quick_actions/quick_actions/test/quick_actions_test.dart +++ b/packages/quick_actions/quick_actions/test/quick_actions_test.dart @@ -16,6 +16,11 @@ void main() { QuickActionsPlatform.instance = MockQuickActionsPlatform(); }); + test('constructor() should return valid QuickActions instance', () { + const QuickActions quickActions = QuickActions(); + expect(quickActions, isNotNull); + }); + test('initialize() PlatformInterface', () async { const QuickActions quickActions = QuickActions(); QuickActionHandler handler = (type) {}; From 247eff181153edfe5be4e5bbe5730ae889f08a5c Mon Sep 17 00:00:00 2001 From: Abhishek01039 Date: Fri, 9 Jul 2021 21:40:59 +0530 Subject: [PATCH 4/4] modify changelog --- packages/quick_actions/quick_actions/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/quick_actions/quick_actions/CHANGELOG.md b/packages/quick_actions/quick_actions/CHANGELOG.md index a792ee47440f..b917dcc85db0 100644 --- a/packages/quick_actions/quick_actions/CHANGELOG.md +++ b/packages/quick_actions/quick_actions/CHANGELOG.md @@ -1,6 +1,6 @@ ## 0.6.0+3 -Added a `const` constructor for the `QuickActions` class, so the plugin will behave as documented in the sample code mentioned in the [README.md](https://github.com/flutter/plugins/blob/59e16a556e273c2d69189b2dcdfa92d101ea6408/packages/quick_actions/quick_actions/README.md). +* Added a `const` constructor for the `QuickActions` class, so the plugin will behave as documented in the sample code mentioned in the [README.md](https://github.com/flutter/plugins/blob/59e16a556e273c2d69189b2dcdfa92d101ea6408/packages/quick_actions/quick_actions/README.md). ## 0.6.0+2