From 8fb620c877e8ce35a3c98909d64a4430336e4fc3 Mon Sep 17 00:00:00 2001 From: Nick Bradshaw Date: Fri, 5 Nov 2021 09:50:51 -0700 Subject: [PATCH 1/3] Update documentation to for setting `zoomEnabled` to false on iOS --- packages/webview_flutter/webview_flutter/lib/src/webview.dart | 3 +++ 1 file changed, 3 insertions(+) diff --git a/packages/webview_flutter/webview_flutter/lib/src/webview.dart b/packages/webview_flutter/webview_flutter/lib/src/webview.dart index 442999d0ff5c..93a07fc22878 100644 --- a/packages/webview_flutter/webview_flutter/lib/src/webview.dart +++ b/packages/webview_flutter/webview_flutter/lib/src/webview.dart @@ -272,6 +272,9 @@ class WebView extends StatefulWidget { /// A Boolean value indicating whether the WebView should support zooming /// using its on-screen zoom controls and gestures. /// + /// *Note: On iOS [JavascriptMode] must be set to + /// [JavascriptMode.unrestricted] in order to set [zoomEnabled] to false + /// /// By default 'zoomEnabled' is true final bool zoomEnabled; From 86d3dc991dd73a7c0ac39bf9b41db8e9e5621c2c Mon Sep 17 00:00:00 2001 From: Nick Bradshaw Date: Fri, 5 Nov 2021 09:51:26 -0700 Subject: [PATCH 2/3] Bump version number and update ChangeLog --- packages/webview_flutter/webview_flutter/CHANGELOG.md | 4 ++++ packages/webview_flutter/webview_flutter/pubspec.yaml | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/webview_flutter/webview_flutter/CHANGELOG.md b/packages/webview_flutter/webview_flutter/CHANGELOG.md index 8f4826823c38..57d32efcab2b 100644 --- a/packages/webview_flutter/webview_flutter/CHANGELOG.md +++ b/packages/webview_flutter/webview_flutter/CHANGELOG.md @@ -1,3 +1,7 @@ +## 2.3.1 + +* Add iOS-specific note to set `JavascriptMode.unrestricted` in order to set `zoomEnabled: false`. + ## 2.3.0 * Add ability to enable/disable zoom functionality. diff --git a/packages/webview_flutter/webview_flutter/pubspec.yaml b/packages/webview_flutter/webview_flutter/pubspec.yaml index c7ac2e0200f9..b64e1b4818a3 100644 --- a/packages/webview_flutter/webview_flutter/pubspec.yaml +++ b/packages/webview_flutter/webview_flutter/pubspec.yaml @@ -2,7 +2,7 @@ name: webview_flutter description: A Flutter plugin that provides a WebView widget on Android and iOS. repository: https://github.com/flutter/plugins/tree/master/packages/webview_flutter/webview_flutter issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+webview%22 -version: 2.3.0 +version: 2.3.1 environment: sdk: ">=2.14.0 <3.0.0" From 01a0bfaa7204e465cb5cf5d4e80db229192632b4 Mon Sep 17 00:00:00 2001 From: Nick Bradshaw Date: Fri, 5 Nov 2021 09:56:10 -0700 Subject: [PATCH 3/3] update casing in doc --- packages/webview_flutter/webview_flutter/lib/src/webview.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/webview_flutter/webview_flutter/lib/src/webview.dart b/packages/webview_flutter/webview_flutter/lib/src/webview.dart index 93a07fc22878..61702e514a4b 100644 --- a/packages/webview_flutter/webview_flutter/lib/src/webview.dart +++ b/packages/webview_flutter/webview_flutter/lib/src/webview.dart @@ -272,7 +272,7 @@ class WebView extends StatefulWidget { /// A Boolean value indicating whether the WebView should support zooming /// using its on-screen zoom controls and gestures. /// - /// *Note: On iOS [JavascriptMode] must be set to + /// *Note: On iOS [javascriptMode] must be set to /// [JavascriptMode.unrestricted] in order to set [zoomEnabled] to false /// /// By default 'zoomEnabled' is true