From 78a1573e4d4b3018e3ddd17a933e29872ebed0c9 Mon Sep 17 00:00:00 2001 From: Harry Terkelsen Date: Fri, 3 Dec 2021 15:55:07 -0800 Subject: [PATCH 1/5] [url_launcher] Mark Link as an invisible factory This improves performance, as the Flutter engine is given a signal that it doesn't need to create an overlay to render links. --- .../url_launcher_web/lib/src/shims/dart_ui_fake.dart | 2 +- .../url_launcher/url_launcher_web/lib/url_launcher_web.dart | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/url_launcher/url_launcher_web/lib/src/shims/dart_ui_fake.dart b/packages/url_launcher/url_launcher_web/lib/src/shims/dart_ui_fake.dart index 8757ca22be17..195612251ead 100644 --- a/packages/url_launcher/url_launcher_web/lib/src/shims/dart_ui_fake.dart +++ b/packages/url_launcher/url_launcher_web/lib/src/shims/dart_ui_fake.dart @@ -16,7 +16,7 @@ class platformViewRegistry { /// Shim for registerViewFactory /// https://github.com/flutter/engine/blob/master/lib/web_ui/lib/ui.dart#L72 static bool registerViewFactory( - String viewTypeId, html.Element Function(int viewId) viewFactory) { + String viewTypeId, html.Element Function(int viewId) viewFactory, {bool isVisible = true}) { return false; } } diff --git a/packages/url_launcher/url_launcher_web/lib/url_launcher_web.dart b/packages/url_launcher/url_launcher_web/lib/url_launcher_web.dart index 571acaffed7b..816e550e34c5 100644 --- a/packages/url_launcher/url_launcher_web/lib/url_launcher_web.dart +++ b/packages/url_launcher/url_launcher_web/lib/url_launcher_web.dart @@ -46,7 +46,7 @@ class UrlLauncherPlugin extends UrlLauncherPlatform { /// Registers this class as the default instance of [UrlLauncherPlatform]. static void registerWith(Registrar registrar) { UrlLauncherPlatform.instance = UrlLauncherPlugin(); - ui.platformViewRegistry.registerViewFactory(linkViewType, linkViewFactory); + ui.platformViewRegistry.registerViewFactory(linkViewType, linkViewFactory, isVisible: false); } @override From 3d18f68dda1bf9b00c08720b989f0c05ac403a86 Mon Sep 17 00:00:00 2001 From: Harry Terkelsen Date: Fri, 3 Dec 2021 16:02:52 -0800 Subject: [PATCH 2/5] Update pubspec and changelog --- packages/url_launcher/url_launcher_web/CHANGELOG.md | 3 +++ packages/url_launcher/url_launcher_web/pubspec.yaml | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/url_launcher/url_launcher_web/CHANGELOG.md b/packages/url_launcher/url_launcher_web/CHANGELOG.md index 5790e116c355..381e604c74fb 100644 --- a/packages/url_launcher/url_launcher_web/CHANGELOG.md +++ b/packages/url_launcher/url_launcher_web/CHANGELOG.md @@ -1,3 +1,6 @@ +## 2.0.6 + +* Marks the `Link` widget as invisible so it can be optimized by the engine. ## 2.0.5 * Updates code for new analysis options. diff --git a/packages/url_launcher/url_launcher_web/pubspec.yaml b/packages/url_launcher/url_launcher_web/pubspec.yaml index 37d3193cb4b2..c0f29341c818 100644 --- a/packages/url_launcher/url_launcher_web/pubspec.yaml +++ b/packages/url_launcher/url_launcher_web/pubspec.yaml @@ -2,7 +2,7 @@ name: url_launcher_web description: Web platform implementation of url_launcher repository: https://github.com/flutter/plugins/tree/master/packages/url_launcher/url_launcher_web issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+url_launcher%22 -version: 2.0.5 +version: 2.0.6 environment: sdk: ">=2.12.0 <3.0.0" From c1143e2961c713d476a52ab98534c10e79df51ca Mon Sep 17 00:00:00 2001 From: Harry Terkelsen Date: Fri, 3 Dec 2021 16:04:04 -0800 Subject: [PATCH 3/5] Whitespace --- packages/url_launcher/url_launcher_web/CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/url_launcher/url_launcher_web/CHANGELOG.md b/packages/url_launcher/url_launcher_web/CHANGELOG.md index 381e604c74fb..0d56cfa20eca 100644 --- a/packages/url_launcher/url_launcher_web/CHANGELOG.md +++ b/packages/url_launcher/url_launcher_web/CHANGELOG.md @@ -1,6 +1,7 @@ ## 2.0.6 * Marks the `Link` widget as invisible so it can be optimized by the engine. + ## 2.0.5 * Updates code for new analysis options. From 216eb350aaf7f2bbfd6f775eb4c84b4cacb2acc0 Mon Sep 17 00:00:00 2001 From: Harry Terkelsen Date: Fri, 3 Dec 2021 16:12:47 -0800 Subject: [PATCH 4/5] Format --- .../url_launcher_web/lib/src/shims/dart_ui_fake.dart | 3 ++- .../url_launcher/url_launcher_web/lib/url_launcher_web.dart | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/url_launcher/url_launcher_web/lib/src/shims/dart_ui_fake.dart b/packages/url_launcher/url_launcher_web/lib/src/shims/dart_ui_fake.dart index 195612251ead..f51dce946acc 100644 --- a/packages/url_launcher/url_launcher_web/lib/src/shims/dart_ui_fake.dart +++ b/packages/url_launcher/url_launcher_web/lib/src/shims/dart_ui_fake.dart @@ -16,7 +16,8 @@ class platformViewRegistry { /// Shim for registerViewFactory /// https://github.com/flutter/engine/blob/master/lib/web_ui/lib/ui.dart#L72 static bool registerViewFactory( - String viewTypeId, html.Element Function(int viewId) viewFactory, {bool isVisible = true}) { + String viewTypeId, html.Element Function(int viewId) viewFactory, + {bool isVisible = true}) { return false; } } diff --git a/packages/url_launcher/url_launcher_web/lib/url_launcher_web.dart b/packages/url_launcher/url_launcher_web/lib/url_launcher_web.dart index 816e550e34c5..19033b70b638 100644 --- a/packages/url_launcher/url_launcher_web/lib/url_launcher_web.dart +++ b/packages/url_launcher/url_launcher_web/lib/url_launcher_web.dart @@ -46,7 +46,8 @@ class UrlLauncherPlugin extends UrlLauncherPlatform { /// Registers this class as the default instance of [UrlLauncherPlatform]. static void registerWith(Registrar registrar) { UrlLauncherPlatform.instance = UrlLauncherPlugin(); - ui.platformViewRegistry.registerViewFactory(linkViewType, linkViewFactory, isVisible: false); + ui.platformViewRegistry + .registerViewFactory(linkViewType, linkViewFactory, isVisible: false); } @override From 6d635b31ff80408ff8a2f0b2b0e2fb6a8d1f004e Mon Sep 17 00:00:00 2001 From: David Iglesias Teixeira Date: Thu, 3 Feb 2022 17:13:28 -0800 Subject: [PATCH 5/5] Push change to pubspec.yaml --- packages/url_launcher/url_launcher_web/pubspec.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/url_launcher/url_launcher_web/pubspec.yaml b/packages/url_launcher/url_launcher_web/pubspec.yaml index d0b1ff7c6b57..b3a2de035067 100644 --- a/packages/url_launcher/url_launcher_web/pubspec.yaml +++ b/packages/url_launcher/url_launcher_web/pubspec.yaml @@ -2,7 +2,7 @@ name: url_launcher_web description: Web platform implementation of url_launcher repository: https://github.com/flutter/plugins/tree/main/packages/url_launcher/url_launcher_web issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+url_launcher%22 -version: 2.0.6 +version: 2.0.7 environment: sdk: ">=2.12.0 <3.0.0"