From c4784cdb112c8b31c97d23e9d98c56bbf5b70cc9 Mon Sep 17 00:00:00 2001 From: maximencko Date: Fri, 11 Feb 2022 22:53:53 +0200 Subject: [PATCH 1/3] add allowBackgroundPlayback option platform interface changes --- .../video_player_platform_interface/CHANGELOG.md | 4 ++++ .../lib/video_player_platform_interface.dart | 11 +++++++++-- .../video_player_platform_interface/pubspec.yaml | 2 +- 3 files changed, 14 insertions(+), 3 deletions(-) diff --git a/packages/video_player/video_player_platform_interface/CHANGELOG.md b/packages/video_player/video_player_platform_interface/CHANGELOG.md index 353f2734642c..52612207d8f3 100644 --- a/packages/video_player/video_player_platform_interface/CHANGELOG.md +++ b/packages/video_player/video_player_platform_interface/CHANGELOG.md @@ -1,3 +1,7 @@ +## 5.1.0 + +* Adds `allowBackgroundPlayback` to `VideoPlayerOptions`. + ## 5.0.2 * Adds the Pigeon definitions used to create the method channel implementation. diff --git a/packages/video_player/video_player_platform_interface/lib/video_player_platform_interface.dart b/packages/video_player/video_player_platform_interface/lib/video_player_platform_interface.dart index f10fe667f0ea..599966bb081c 100644 --- a/packages/video_player/video_player_platform_interface/lib/video_player_platform_interface.dart +++ b/packages/video_player/video_player_platform_interface/lib/video_player_platform_interface.dart @@ -346,7 +346,14 @@ class VideoPlayerOptions { // in all of the other video player packages, fix this, and then update // the other packages to use const. // ignore: prefer_const_constructors_in_immutables - VideoPlayerOptions({this.mixWithOthers = false}); + VideoPlayerOptions({ + this.mixWithOthers = false, + this.allowBackgroundPlayback = false, + }); + + /// Set this to true to keep playing video in background, when app goes in background. + /// The default value is false. + final bool allowBackgroundPlayback; /// Set this to true to mix the video players audio with other audio sources. /// The default value is false @@ -354,4 +361,4 @@ class VideoPlayerOptions { /// Note: This option will be silently ignored in the web platform (there is /// currently no way to implement this feature in this platform). final bool mixWithOthers; -} +} \ No newline at end of file diff --git a/packages/video_player/video_player_platform_interface/pubspec.yaml b/packages/video_player/video_player_platform_interface/pubspec.yaml index 7d5bd83278c0..b66fa0b46d75 100644 --- a/packages/video_player/video_player_platform_interface/pubspec.yaml +++ b/packages/video_player/video_player_platform_interface/pubspec.yaml @@ -4,7 +4,7 @@ repository: https://github.com/flutter/plugins/tree/main/packages/video_player/v issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+video_player%22 # NOTE: We strongly prefer non-breaking changes, even at the expense of a # less-clean API. See https://flutter.dev/go/platform-interface-breaking-changes -version: 5.0.2 +version: 5.1.0 environment: sdk: ">=2.12.0 <3.0.0" From e508f5fb2c292fbecb71046e3925da4e275c066e Mon Sep 17 00:00:00 2001 From: maximencko Date: Fri, 11 Feb 2022 22:59:08 +0200 Subject: [PATCH 2/3] format --- .../lib/video_player_platform_interface.dart | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/video_player/video_player_platform_interface/lib/video_player_platform_interface.dart b/packages/video_player/video_player_platform_interface/lib/video_player_platform_interface.dart index 599966bb081c..8a61005c429e 100644 --- a/packages/video_player/video_player_platform_interface/lib/video_player_platform_interface.dart +++ b/packages/video_player/video_player_platform_interface/lib/video_player_platform_interface.dart @@ -361,4 +361,4 @@ class VideoPlayerOptions { /// Note: This option will be silently ignored in the web platform (there is /// currently no way to implement this feature in this platform). final bool mixWithOthers; -} \ No newline at end of file +} From 0077087f2608cac26dcebb674ce0184c8a4247b4 Mon Sep 17 00:00:00 2001 From: maximencko Date: Tue, 15 Feb 2022 20:32:38 +0200 Subject: [PATCH 3/3] add defaults tests --- .../test/video_player_options_test.dart | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) create mode 100644 packages/video_player/video_player_platform_interface/test/video_player_options_test.dart diff --git a/packages/video_player/video_player_platform_interface/test/video_player_options_test.dart b/packages/video_player/video_player_platform_interface/test/video_player_options_test.dart new file mode 100644 index 000000000000..a65fc392c2f8 --- /dev/null +++ b/packages/video_player/video_player_platform_interface/test/video_player_options_test.dart @@ -0,0 +1,19 @@ +import 'package:flutter_test/flutter_test.dart'; +import 'package:video_player_platform_interface/video_player_platform_interface.dart'; + +void main() { + test( + 'VideoPlayerOptions allowBackgroundPlayback defaults to false', + () { + final VideoPlayerOptions options = VideoPlayerOptions(); + expect(options.allowBackgroundPlayback, false); + }, + ); + test( + 'VideoPlayerOptions mixWithOthers defaults to false', + () { + final VideoPlayerOptions options = VideoPlayerOptions(); + expect(options.mixWithOthers, false); + }, + ); +}