From 9f6d7c8235a0e4539b3d4ab0591ea8dbc936dde5 Mon Sep 17 00:00:00 2001 From: Maurice Parrish <10687576+bparrishMines@users.noreply.github.com> Date: Tue, 26 Apr 2022 19:19:18 -0700 Subject: [PATCH 1/2] change default layout direction --- packages/webview_flutter/webview_flutter_android/CHANGELOG.md | 4 ++++ .../webview_flutter_android/lib/webview_android.dart | 2 +- .../webview_flutter_android/lib/webview_surface_android.dart | 2 +- packages/webview_flutter/webview_flutter_android/pubspec.yaml | 2 +- 4 files changed, 7 insertions(+), 3 deletions(-) diff --git a/packages/webview_flutter/webview_flutter_android/CHANGELOG.md b/packages/webview_flutter/webview_flutter_android/CHANGELOG.md index fb5a2b85ffed..20769ccd475e 100644 --- a/packages/webview_flutter/webview_flutter_android/CHANGELOG.md +++ b/packages/webview_flutter/webview_flutter_android/CHANGELOG.md @@ -1,3 +1,7 @@ +## 2.8.6 + +* Change the default WebView layout direction to `TextDirection.ltr`. + ## 2.8.5 * Migrates deprecated `Scaffold.showSnackBar` to `ScaffoldMessenger` in example app. diff --git a/packages/webview_flutter/webview_flutter_android/lib/webview_android.dart b/packages/webview_flutter/webview_flutter_android/lib/webview_android.dart index 1f0eb7bd7ded..d0eb7bc2fb51 100644 --- a/packages/webview_flutter/webview_flutter_android/lib/webview_android.dart +++ b/packages/webview_flutter/webview_flutter_android/lib/webview_android.dart @@ -54,7 +54,7 @@ class AndroidWebView implements WebViewPlatform { }, gestureRecognizers: gestureRecognizers, layoutDirection: - Directionality.maybeOf(context) ?? TextDirection.rtl, + Directionality.maybeOf(context) ?? TextDirection.ltr, creationParams: InstanceManager.instance.getInstanceId(controller.webView), creationParamsCodec: const StandardMessageCodec(), diff --git a/packages/webview_flutter/webview_flutter_android/lib/webview_surface_android.dart b/packages/webview_flutter/webview_flutter_android/lib/webview_surface_android.dart index 00d7c8c53b7f..e642a96f30aa 100644 --- a/packages/webview_flutter/webview_flutter_android/lib/webview_surface_android.dart +++ b/packages/webview_flutter/webview_flutter_android/lib/webview_surface_android.dart @@ -59,7 +59,7 @@ class SurfaceAndroidWebView extends AndroidWebView { // WebView content is not affected by the Android view's layout direction, // we explicitly set it here so that the widget doesn't require an ambient // directionality. - layoutDirection: TextDirection.rtl, + layoutDirection: TextDirection.ltr, creationParams: InstanceManager.instance.getInstanceId(controller.webView), creationParamsCodec: const StandardMessageCodec(), diff --git a/packages/webview_flutter/webview_flutter_android/pubspec.yaml b/packages/webview_flutter/webview_flutter_android/pubspec.yaml index 3fae698d1481..9f2195466276 100644 --- a/packages/webview_flutter/webview_flutter_android/pubspec.yaml +++ b/packages/webview_flutter/webview_flutter_android/pubspec.yaml @@ -2,7 +2,7 @@ name: webview_flutter_android description: A Flutter plugin that provides a WebView widget on Android. repository: https://github.com/flutter/plugins/tree/main/packages/webview_flutter/webview_flutter_android issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+webview%22 -version: 2.8.5 +version: 2.8.6 environment: sdk: ">=2.14.0 <3.0.0" From 992ff45750bc6a3563fb6dc08168428d8ceedea0 Mon Sep 17 00:00:00 2001 From: Maurice Parrish <10687576+bparrishMines@users.noreply.github.com> Date: Tue, 26 Apr 2022 19:20:06 -0700 Subject: [PATCH 2/2] changelog message --- packages/webview_flutter/webview_flutter_android/CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/webview_flutter/webview_flutter_android/CHANGELOG.md b/packages/webview_flutter/webview_flutter_android/CHANGELOG.md index 20769ccd475e..7782f9f49d0b 100644 --- a/packages/webview_flutter/webview_flutter_android/CHANGELOG.md +++ b/packages/webview_flutter/webview_flutter_android/CHANGELOG.md @@ -1,6 +1,6 @@ ## 2.8.6 -* Change the default WebView layout direction to `TextDirection.ltr`. +* Changes default WebView layout direction to `TextDirection.ltr`. ## 2.8.5