From 92165ef46fd02f8534799836c95d5bcd66436923 Mon Sep 17 00:00:00 2001 From: Felix Wielander Date: Sun, 26 Jul 2020 18:29:40 +0200 Subject: [PATCH 1/3] Replaced separator attribute with separatorBuilder in nav back layer --- lib/navigation.dart | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/navigation.dart b/lib/navigation.dart index d593c01..1d9ef47 100644 --- a/lib/navigation.dart +++ b/lib/navigation.dart @@ -45,8 +45,8 @@ class BackdropNavigationBackLayer extends StatelessWidget { /// Callback that is called whenever a list item is tapped by the user. final ValueChanged onTap; - /// Customizable separator used with [ListView.separated]. - final Widget separator; + /// Customizable separatorBuilder used with [ListView.separated]. + final IndexedWidgetBuilder separatorBuilder; /// Creates an instance of [BackdropNavigationBackLayer] to be used with /// [BackdropScaffold]. @@ -56,7 +56,7 @@ class BackdropNavigationBackLayer extends StatelessWidget { Key key, @required this.items, this.onTap, - this.separator, + this.separatorBuilder, }) : assert(items != null), assert(items.isNotEmpty), super(key: key); @@ -76,7 +76,7 @@ class BackdropNavigationBackLayer extends StatelessWidget { onTap?.call(position); }, ), - separatorBuilder: (builder, position) => separator ?? Container(), + separatorBuilder: separatorBuilder ?? (builder, position) => Container(), ); } } From c818b319931e0a4b998231004f41ae074c0783db Mon Sep 17 00:00:00 2001 From: Felix Wielander Date: Sun, 26 Jul 2020 18:30:08 +0200 Subject: [PATCH 2/3] Added separator builder to example app. --- example/lib/navigation.dart | 1 + 1 file changed, 1 insertion(+) diff --git a/example/lib/navigation.dart b/example/lib/navigation.dart index 3b064df..81ea678 100644 --- a/example/lib/navigation.dart +++ b/example/lib/navigation.dart @@ -33,6 +33,7 @@ class _MyAppState extends State { ListTile(title: Text("Widget 2")), ], onTap: (int position) => {setState(() => _currentIndex = position)}, + separatorBuilder: (context, index) => Divider(), ), ), ); From a69bc350c7eabc9324bace134edc539396439fbe Mon Sep 17 00:00:00 2001 From: Harsh Bhikadia Date: Sat, 15 Aug 2020 17:34:37 +0530 Subject: [PATCH 3/3] [navigation] added back `separator` with deprecation warning --- lib/navigation.dart | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/lib/navigation.dart b/lib/navigation.dart index 1d9ef47..6fd7df5 100644 --- a/lib/navigation.dart +++ b/lib/navigation.dart @@ -45,6 +45,11 @@ class BackdropNavigationBackLayer extends StatelessWidget { /// Callback that is called whenever a list item is tapped by the user. final ValueChanged onTap; + /// Customizable separator used with [ListView.separated]. + @Deprecated("Replace by use of `separatorBuilder`." + "This feature was deprecated after v0.4.1.") + final Widget separator; + /// Customizable separatorBuilder used with [ListView.separated]. final IndexedWidgetBuilder separatorBuilder; @@ -56,6 +61,7 @@ class BackdropNavigationBackLayer extends StatelessWidget { Key key, @required this.items, this.onTap, + this.separator, this.separatorBuilder, }) : assert(items != null), assert(items.isNotEmpty), @@ -76,7 +82,8 @@ class BackdropNavigationBackLayer extends StatelessWidget { onTap?.call(position); }, ), - separatorBuilder: separatorBuilder ?? (builder, position) => Container(), + separatorBuilder: + separatorBuilder ?? (builder, position) => separator ?? Container(), ); } }