From 199a784a26d8a00fb1190c6c44b0abaef8685c5b Mon Sep 17 00:00:00 2001 From: Yegor Yefremov Date: Sun, 23 Feb 2025 10:40:00 +0100 Subject: [PATCH 1/2] Resolve -Wunused-parameter warning Declare an unused parameter as void to tell the compiler that this variable is unused on purpose. --- http.c | 3 +++ main.c | 1 + tcp.c | 3 +++ 3 files changed, 7 insertions(+) diff --git a/http.c b/http.c index d1ce054..fded892 100644 --- a/http.c +++ b/http.c @@ -17,6 +17,9 @@ int get_HTTP_headers(int socket_h, SSL *ssl_h, char **headers, int *overflow, double timeout) { +#if !HAVE_OPENSSL + (void)ssl_h; +#endif char *term = NULL; int len_in=0, len=4096; char *buffer = (char *)malloc(len + 1); diff --git a/main.c b/main.c index 9ad5dbb..c10ca56 100644 --- a/main.c +++ b/main.c @@ -72,6 +72,7 @@ volatile char got_sigquit = 0; void handler_quit(int s) { + (void)s; signal(SIGQUIT, handler_quit); got_sigquit = 1; diff --git a/tcp.c b/tcp.c index c4326e9..fa3ef84 100644 --- a/tcp.c +++ b/tcp.c @@ -47,6 +47,9 @@ int set_no_delay(int fd) int create_socket(struct sockaddr *bind_to, struct addrinfo *ai, int recv_buffer_size, int tx_buffer_size, int max_mtu, char use_no_delay, int priority, int tos) { +#ifndef linux + (void)priority; +#endif int fd = -1; /* create socket */ From 2a5d97c9f695af9f7e3ac93ab09e2c278bcae4f2 Mon Sep 17 00:00:00 2001 From: Yegor Yefremov Date: Mon, 24 Feb 2025 11:15:40 +0100 Subject: [PATCH 2/2] nc.c: drop the unused parameter val The parameter val wasn't used inside draw_graph(). Hence, remove it. --- nc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/nc.c b/nc.c index e3d88e3..5dbd837 100644 --- a/nc.c +++ b/nc.c @@ -626,7 +626,7 @@ double calc_trend() return (v1 - v2) / (v2 / 100.0); } -void draw_graph(double val) +void draw_graph() { int index = 0, loop_n = min(max_x, history_n), n = 0, n2 = 0; double avg = 0, sd = 0; @@ -761,7 +761,6 @@ void show_stats_t(int y, int x, char *header, stats_t *data, char abbreviate) void update_stats(stats_t *resolve, stats_t *connect, stats_t *request, stats_t *total, stats_t *ssl_setup, int n_ok, int n_fail, const char *last_connect_str, const char *fp, char use_tfo, char dg, stats_t *st_to, stats_t *tcp_rtt_stats, int re_tx, int pmtu, int tos, stats_t *close_st, stats_t *t_write, int n_cookies, char abbreviate, stats_t *stats_header_size) { - double k = 0.0; char force_redraw = 0; struct pollfd p = { 0, POLLIN, 0 }; @@ -855,7 +854,7 @@ void update_stats(stats_t *resolve, stats_t *connect, stats_t *request, stats_t if (dg && !pause_graphs) { - draw_graph(k); + draw_graph(); #if HAVE_FFTW3 draw_fft(); #endif