From b088b79a9e61fedb9c0b51eb39471484d5d2a477 Mon Sep 17 00:00:00 2001
From: Deeka Wong <8337659+huangdijia@users.noreply.github.com>
Date: Sun, 12 Oct 2025 21:48:09 +0800
Subject: [PATCH] feat(sentry): align GrpcAspect with OpenTelemetry semantic
 conventions

Updates the GrpcAspect to follow OpenTelemetry semantic conventions for RPC spans:
- Changes operation name from 'grpc.client' to 'rpc.client'
- Updates span origin from 'auto.grpc' to 'auto.rpc'
- Renames span data attributes: 'grpc.method' to 'rpc.method', 'grpc.options' to 'rpc.options'
- Adds 'rpc.system' attribute set to 'grpc' to identify the RPC system

This aligns the implementation with standard OpenTelemetry conventions for better compatibility and consistency with observability tools.
---
 src/sentry/src/Tracing/Aspect/GrpcAspect.php | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/sentry/src/Tracing/Aspect/GrpcAspect.php b/src/sentry/src/Tracing/Aspect/GrpcAspect.php
index 16789aa90..4ea0888a9 100644
--- a/src/sentry/src/Tracing/Aspect/GrpcAspect.php
+++ b/src/sentry/src/Tracing/Aspect/GrpcAspect.php
@@ -41,8 +41,9 @@ public function process(ProceedingJoinPoint $proceedingJoinPoint)
         $method = $proceedingJoinPoint->arguments['keys']['method'];
         $options = $proceedingJoinPoint->arguments['keys']['options'];
         $data = [
-            'grpc.method' => $method,
-            'grpc.options' => $options,
+            'rpc.system' => 'grpc',
+            'rpc.method' => $method,
+            'rpc.options' => $options,
         ];
 
         $parent = SentrySdk::getCurrentHub()->getSpan();
@@ -64,9 +65,9 @@ public function process(ProceedingJoinPoint $proceedingJoinPoint)
         return trace(
             fn (Scope $scope) => $proceedingJoinPoint->process(),
             SpanContext::make()
-                ->setOp('grpc.client')
+                ->setOp('rpc.client')
                 ->setDescription($method)
-                ->setOrigin('auto.grpc')
+                ->setOrigin('auto.rpc')
                 ->setData($data)
         );
     }