From a2f20bd034031b16a04487bc3c2fd3fa5fa8153a Mon Sep 17 00:00:00 2001 From: Ruben Bartelink Date: Sat, 23 Dec 2023 15:39:09 +0000 Subject: [PATCH] Prefer `IDisposable` over `IAsyndDisposable` for disposing `ReaderWriterLock` --- src/FSharp.Control.TaskSeq/TaskSeqInternal.fs | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/FSharp.Control.TaskSeq/TaskSeqInternal.fs b/src/FSharp.Control.TaskSeq/TaskSeqInternal.fs index ed92a9fe..8f5da6e8 100644 --- a/src/FSharp.Control.TaskSeq/TaskSeqInternal.fs +++ b/src/FSharp.Control.TaskSeq/TaskSeqInternal.fs @@ -978,13 +978,11 @@ module internal TaskSeqInternal = go <- step } - interface IAsyncDisposable with - override _.DisposeAsync() = + interface IDisposable with + override _.Dispose() = if not (isNull _rwLock) then _rwLock.Dispose() - ValueTask.CompletedTask - let except itemsToExclude (source: TaskSeq<_>) = checkNonNull (nameof source) source checkNonNull (nameof itemsToExclude) itemsToExclude