From fc64f79a43dad5fe192932df7902ef61920ced73 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" <41898282+github-actions[bot]@users.noreply.github.com> Date: Sat, 18 Apr 2026 10:40:44 +0000 Subject: [PATCH 1/2] eng: fix stale FCS VersionOverride; replace Enumerable.Cast with Seq.cast - Remove VersionOverride="43.12.201" from FSharp.Formatting.Markdown.fsproj. The package now uses the central pin ([43.12.202]) from Directory.Packages.props, eliminating the NU1605 (package downgrade) build warning that appeared since the central pin was bumped to 43.12.202 in a later dependabot PR. - Replace Enumerable.Cast (LINQ) with Seq.cast (idiomatic F#) in MarkdownUtils.fs, allowing the 'open System.Linq' import to be removed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- RELEASE_NOTES.md | 2 ++ .../FSharp.Formatting.Markdown.fsproj | 2 +- src/FSharp.Formatting.Markdown/MarkdownUtils.fs | 3 +-- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/RELEASE_NOTES.md b/RELEASE_NOTES.md index e54bd9b2..8a318b6a 100644 --- a/RELEASE_NOTES.md +++ b/RELEASE_NOTES.md @@ -7,6 +7,8 @@ * Replace deprecated `System.Net.WebClient` with `System.Net.Http.HttpClient` in the image downloader used by `--saveimages`. Removes the `#nowarn "44"` suppression. * Bump `Newtonsoft.Json` transitive-dependency pin from 13.0.3 to 13.0.4. * Bump `System.Memory` transitive-dependency pin from 4.5.5 to 4.6.3.0 +* Remove stale `VersionOverride="43.12.201"` on the `FSharp.Compiler.Service` reference in `FSharp.Formatting.Markdown.fsproj`; the package now uses the central pin (`43.12.202`) from `Directory.Packages.props`, eliminating the NU1605 build warning. +* Replace `Enumerable.Cast` (LINQ) with `Seq.cast` (idiomatic F#) in `MarkdownUtils.fs`, removing the `open System.Linq` import. ### Fixed * Fix `Markdown.ToMd` silently dropping YAML frontmatter when serialising a parsed `MarkdownDocument` back to Markdown text. Frontmatter is now preserved with its `---` delimiters. diff --git a/src/FSharp.Formatting.Markdown/FSharp.Formatting.Markdown.fsproj b/src/FSharp.Formatting.Markdown/FSharp.Formatting.Markdown.fsproj index bfec7854..b084c17c 100644 --- a/src/FSharp.Formatting.Markdown/FSharp.Formatting.Markdown.fsproj +++ b/src/FSharp.Formatting.Markdown/FSharp.Formatting.Markdown.fsproj @@ -26,7 +26,7 @@ - + diff --git a/src/FSharp.Formatting.Markdown/MarkdownUtils.fs b/src/FSharp.Formatting.Markdown/MarkdownUtils.fs index 1fb7207c..6b784184 100644 --- a/src/FSharp.Formatting.Markdown/MarkdownUtils.fs +++ b/src/FSharp.Formatting.Markdown/MarkdownUtils.fs @@ -6,7 +6,6 @@ namespace rec FSharp.Formatting.Markdown open System open System.Collections.Generic -open System.Linq open System.Xml.Linq open FSharp.Formatting.Templating @@ -423,7 +422,7 @@ module internal MarkdownUtils = let attributes = match System.Xml.XPath.Extensions.XPathEvaluate(element, "//*/@*[contains(., '.md')]") with | :? System.Collections.IEnumerable as enumerable -> - enumerable |> Enumerable.Cast |> Seq.toArray + enumerable |> Seq.cast |> Seq.toArray | _ -> Array.empty if Array.isEmpty attributes then From 9a66ada4546be0e337e6b1f0c9ac87e3a34bfe19 Mon Sep 17 00:00:00 2001 From: "github-actions[bot]" Date: Sat, 18 Apr 2026 10:40:47 +0000 Subject: [PATCH 2/2] ci: trigger checks