From 7474a45e70fad1ad0e17c940eb47b728e5cc1c63 Mon Sep 17 00:00:00 2001 From: Abdellah Hariti Date: Thu, 17 Apr 2025 16:12:39 +0100 Subject: [PATCH 1/2] migrate android onboarding options to inline syntax --- docs/platforms/android/index.mdx | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/docs/platforms/android/index.mdx b/docs/platforms/android/index.mdx index 7b49747219241..c1589c0746e51 100644 --- a/docs/platforms/android/index.mdx +++ b/docs/platforms/android/index.mdx @@ -110,23 +110,29 @@ The wizard will prompt you to log in to Sentry. It'll then automatically do the Configuration is done via the application `AndroidManifest.xml`. Here's an example config which should get you started: -```xml {filename:AndroidManifest.xml} {"onboardingOptions": {"performance": "6-7", "profiling": "8-13", "session-replay": "14-16"}} +```xml {filename:AndroidManifest.xml} + + + + + + ``` From 175c9d90ad0f3f11963677f68f22dc216b0757ed Mon Sep 17 00:00:00 2001 From: Abdellah Hariti Date: Mon, 21 Apr 2025 12:57:23 +0100 Subject: [PATCH 2/2] fix option name matcher --- src/rehype-onboarding-lines.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/rehype-onboarding-lines.js b/src/rehype-onboarding-lines.js index 1533f3613d108..fe1ca6cf25235 100644 --- a/src/rehype-onboarding-lines.js +++ b/src/rehype-onboarding-lines.js @@ -51,15 +51,15 @@ function handle_inline_options(node) { let currentOption; // product options syntax - // ___PRODUCT_OPTION_START___ performance + // ___PRODUCT_OPTION_START___ session-replay // some lines here - // ___PRODUCT_OPTION_END___ performance + // ___PRODUCT_OPTION_END___ session-replay const PRODUCT_OPTION_START = '___PRODUCT_OPTION_START___'; const PRODUCT_OPTION_END = '___PRODUCT_OPTION_END___'; node.children?.forEach(line => { const lineStr = toString(line); if (lineStr.includes(PRODUCT_OPTION_START)) { - currentOption = lineStr.split(PRODUCT_OPTION_START)[1].trim(); + currentOption = /___PRODUCT_OPTION_START___ ([-\w]+)/.exec(lineStr)?.[1].trim(); line.properties['data-onboarding-option-hidden'] = '1'; } else if (lineStr.includes(PRODUCT_OPTION_END)) { line.properties['data-onboarding-option-hidden'] = '1';