Commit 62be087
authored
ref(node) refactor contextlines to use readline (#12221)
Refactors contextlines integration to use readline instead of reading
the entire file into memory (we were also doubling the memory as we were
splitting the file via `.split(\n)`.
Current implementation is not leveraging the cache to optimize file
reads, so I need to reintroduce that. Something to note is that the
caching behavior will become per frame location vs per file, which I
think makes more sense as we can only assume that this stack frame might
throw in the future (as opposed to anything from the file it is in).1 parent d3ff316 commit 62be087
File tree
3 files changed
+417
-131
lines changed- dev-packages/node-integration-tests/suites/public-api/captureException/catched-error
- packages/node
- src/integrations
- test/integrations
3 files changed
+417
-131
lines changedLines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
33 | | - | |
| 33 | + | |
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
| |||
0 commit comments