meta: lint fixes

Author: billyvg

packages/feedback/src/constants.ts

@@ -23,7 +23,6 @@ export const DEFAULT_THEME = {
   },
 };
 
-
 export const ACTOR_LABEL = 'Report a Bug';
 export const CANCEL_BUTTON_LABEL = 'Cancel';
 export const SUBMIT_BUTTON_LABEL = 'Send Bug Report';
@@ -33,5 +32,5 @@ export const EMAIL_LABEL = 'Email';
 export const MESSAGE_PLACEHOLDER = "What's the bug? What did you expect?";
 export const MESSAGE_LABEL = 'Description';
 export const NAME_PLACEHOLDER = 'Your Name';
-export const NAME_LABEL= 'Name';
+export const NAME_LABEL = 'Name';
 export const SUCCESS_MESSAGE_TEXT = 'Thank you for your report!';

packages/feedback/src/integration.ts

@@ -1,8 +1,21 @@
 import { getCurrentHub } from '@sentry/core';
 import type { Integration } from '@sentry/types';
 import { isNodeEnv, logger } from '@sentry/utils';
-import { ACTOR_LABEL, CANCEL_BUTTON_LABEL, DEFAULT_THEME, EMAIL_LABEL, EMAIL_PLACEHOLDER, FORM_TITLE, MESSAGE_LABEL, MESSAGE_PLACEHOLDER, NAME_LABEL, NAME_PLACEHOLDER, SUBMIT_BUTTON_LABEL, SUCCESS_MESSAGE_TEXT } from './constants';
 
+import {
+  ACTOR_LABEL,
+  CANCEL_BUTTON_LABEL,
+  DEFAULT_THEME,
+  EMAIL_LABEL,
+  EMAIL_PLACEHOLDER,
+  FORM_TITLE,
+  MESSAGE_LABEL,
+  MESSAGE_PLACEHOLDER,
+  NAME_LABEL,
+  NAME_PLACEHOLDER,
+  SUBMIT_BUTTON_LABEL,
+  SUCCESS_MESSAGE_TEXT,
+} from './constants';
 import type { FeedbackConfigurationWithDefaults, FeedbackFormData, FeedbackTheme } from './types';
 import { handleFeedbackSubmit } from './util/handleFeedbackSubmit';
 import { Actor } from './widget/Actor';
@@ -30,7 +43,7 @@ interface FeedbackConfiguration extends Partial<Omit<FeedbackConfigurationWithDe
   theme?: {
     dark?: Partial<FeedbackTheme>;
     light?: Partial<FeedbackTheme>;
-  }
+  };
 }
 
 /**
@@ -78,7 +91,7 @@ export class Feedback implements Integration {
   /**
    * Tracks if dialog has ever been opened at least one time
    */
-  private hasDialogEverOpened: boolean;
+  private _hasDialogEverOpened: boolean;
 
   public constructor({
     id = 'sentry-feedback',
@@ -113,15 +126,15 @@ export class Feedback implements Integration {
     onDialogOpen,
     onSubmitError,
     onSubmitSuccess,
-  }: FeedbackConfiguration  = {}) {
+  }: FeedbackConfiguration = {}) {
     // Initializations
     this.name = Feedback.id;
     this._actor = null;
     this._dialog = null;
     this._host = null;
     this._shadow = null;
     this._isDialogOpen = false;
-    this.hasDialogEverOpened = false;
+    this._hasDialogEverOpened = false;
 
     this.options = {
       id,
@@ -252,7 +265,7 @@ export class Feedback implements Integration {
       }
 
       // Lazy-load until dialog is opened and only inject styles once
-      if (!this.hasDialogEverOpened) {
+      if (!this._hasDialogEverOpened) {
         this._shadow.appendChild(createDialogStyles(document));
       }
 
@@ -279,7 +292,7 @@ export class Feedback implements Integration {
       // Hides the default actor whenever dialog is opened
       this._actor && this._actor.hide();
 
-      this.hasDialogEverOpened = true;
+      this._hasDialogEverOpened = true;
       if (this.options.onDialogOpen) {
         this.options.onDialogOpen();
       }

packages/feedback/src/sendFeedback.ts

@@ -20,7 +20,7 @@ interface SendFeedbackOptions {
 export function sendFeedback(
   { name, email, message, url = document.location.href }: SendFeedbackParams,
   { includeReplay = true }: SendFeedbackOptions = {},
-) {
+): ReturnType<typeof sendFeedbackRequest> {
   const hub = getCurrentHub();
   const client = hub && hub.getClient<BrowserClient>();
   const replay = includeReplay && client ? (client.getIntegrationById('Replay') as Replay | undefined) : undefined;

packages/feedback/src/util/handleFeedbackSubmit.ts

@@ -1,7 +1,10 @@
-import type { FeedbackFormData } from '../types';
-import { DialogComponent } from '../widget/Dialog';
 import { sendFeedback } from '../sendFeedback';
+import type { FeedbackFormData } from '../types';
+import type { DialogComponent } from '../widget/Dialog';
 
+/**
+ *
+ */
 export async function handleFeedbackSubmit(
   dialog: DialogComponent | null,
   feedback: FeedbackFormData,
@@ -11,7 +14,7 @@ export async function handleFeedbackSubmit(
     return false;
   }
 
-  const showFetchError = () => {
+  const showFetchError = (): void => {
     if (!dialog) {
       return;
     }
@@ -23,7 +26,6 @@ export async function handleFeedbackSubmit(
     dialog.hideError();
     dialog.setSubmitDisabled();
     const resp = await sendFeedback(feedback);
-    console.log({ resp });
 
     if (!resp) {
       // Errored... re-enable submit button

packages/feedback/src/widget/Actor.ts

@@ -1,4 +1,4 @@
-import type { FeedbackComponent, FeedbackConfigurationWithDefaults, FeedbackTheme } from '../types';
+import type { FeedbackComponent, FeedbackConfigurationWithDefaults } from '../types';
 import { Icon } from './Icon';
 import { createElement as h } from './util/createElement';
 
@@ -22,7 +22,7 @@ interface ActorComponent extends FeedbackComponent<HTMLButtonElement> {
  *
  */
 export function Actor({ options, onClick }: Props): ActorComponent {
-  function _handleClick(e: MouseEvent) {
+  function _handleClick(e: MouseEvent): void {
     onClick && onClick(e);
   }
 

packages/feedback/src/widget/Dialog.ts

@@ -61,7 +61,7 @@ export function Dialog({
    * semi-transparent bg behind the form. We want clicks outside of the form to
    * hide the form.
    */
-  function handleDialogClick() {
+  function handleDialogClick(): void {
     close();
 
     // Only this should trigger `onClose`, we don't want the `close()` method to
@@ -72,7 +72,7 @@ export function Dialog({
   /**
    * Close the dialog
    */
-  function close() {
+  function close(): void {
     if ($el) {
       $el.open = false;
     }
@@ -81,7 +81,7 @@ export function Dialog({
   /**
    * Opens the dialog
    */
-  function open() {
+  function open(): void {
     if ($el) {
       $el.open = true;
     }

packages/feedback/src/widget/Form.ts

@@ -106,13 +106,13 @@ export function Form({
     ariaHidden: 'true',
   });
 
-  function showError(message: string) {
+  function showError(message: string): void {
     $error.textContent = message;
     $error.classList.remove('form__error-container--hidden');
     $error.setAttribute('ariaHidden', 'false');
   }
 
-  function hideError() {
+  function hideError(): void {
     $error.textContent = '';
     $error.classList.add('form__error-container--hidden');
     $error.setAttribute('ariaHidden', 'true');

packages/feedback/src/widget/Main.css.ts

@@ -3,7 +3,11 @@ import type { FeedbackThemes } from '../types';
 /**
  * Creates <style> element for widget actor (button that opens the dialog)
  */
-export function createMainStyles(d: Document, colorScheme: 'system' | 'dark' | 'light', themes: FeedbackThemes): HTMLStyleElement {
+export function createMainStyles(
+  d: Document,
+  colorScheme: 'system' | 'dark' | 'light',
+  themes: FeedbackThemes,
+): HTMLStyleElement {
   const style = d.createElement('style');
   const theme = colorScheme === 'system' ? themes.light : themes[colorScheme];
   style.textContent = `
@@ -29,7 +33,9 @@ export function createMainStyles(d: Document, colorScheme: 'system' | 'dark' | '
   --border: ${theme.border};
   --box-shadow: ${theme.boxShadow};
 }
-${colorScheme === 'system' ? `
+${
+  colorScheme === 'system'
+    ? `
 @media (prefers-color-scheme: dark) {
   :host {
     --bg-color: ${themes.dark.background};
@@ -41,7 +47,9 @@ ${colorScheme === 'system' ? `
     --box-shadow: ${themes.dark.boxShadow};
   }
 }
-`: ''}`;
+`
+    : ''
+}`;
 
   return style;
 }

packages/feedback/src/widget/SuccessMessage.ts

@@ -18,7 +18,7 @@ interface SuccessMessageComponent extends FeedbackComponent<HTMLDivElement> {
  * Feedback dialog component that has the form
  */
 export function SuccessMessage({ message, onRemove }: SuccessMessageProps): SuccessMessageComponent {
-  function remove() {
+  function remove(): void {
     if (!$el) {
       return;
     }