From 3cd7760571a333de08c411221985674dec665372 Mon Sep 17 00:00:00 2001 From: Luca Forstner Date: Wed, 11 Dec 2024 13:16:55 +0000 Subject: [PATCH 1/2] test(node-integration-tests): Look for specific error message in iitm test --- .../suites/esm/import-in-the-middle/test.ts | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/dev-packages/node-integration-tests/suites/esm/import-in-the-middle/test.ts b/dev-packages/node-integration-tests/suites/esm/import-in-the-middle/test.ts index 8b9e6e06202f..ab93d01178b6 100644 --- a/dev-packages/node-integration-tests/suites/esm/import-in-the-middle/test.ts +++ b/dev-packages/node-integration-tests/suites/esm/import-in-the-middle/test.ts @@ -7,6 +7,11 @@ afterAll(() => { conditionalTest({ min: 18 })('import-in-the-middle', () => { test('onlyIncludeInstrumentedModules', done => { - createRunner(__dirname, 'app.mjs').ensureNoErrorOutput().start(done); + const runner = createRunner(__dirname, 'app.mjs').start(() => { + runner.getLogs().forEach(logMsg => { + expect(logMsg).not.toContain('should be the only hooked modules but we just hooked'); + }); + done(); + }); }); }); From d1f462e4eda3c65d8525d2eb2e82ca350ffe431c Mon Sep 17 00:00:00 2001 From: Luca Forstner Date: Wed, 11 Dec 2024 13:31:58 +0000 Subject: [PATCH 2/2] fix fix fix --- .../suites/esm/import-in-the-middle/test.ts | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/dev-packages/node-integration-tests/suites/esm/import-in-the-middle/test.ts b/dev-packages/node-integration-tests/suites/esm/import-in-the-middle/test.ts index ab93d01178b6..d1584c2ea32d 100644 --- a/dev-packages/node-integration-tests/suites/esm/import-in-the-middle/test.ts +++ b/dev-packages/node-integration-tests/suites/esm/import-in-the-middle/test.ts @@ -1,17 +1,15 @@ +import { spawnSync } from 'child_process'; +import { join } from 'path'; import { conditionalTest } from '../../../utils'; -import { cleanupChildProcesses, createRunner } from '../../../utils/runner'; +import { cleanupChildProcesses } from '../../../utils/runner'; afterAll(() => { cleanupChildProcesses(); }); conditionalTest({ min: 18 })('import-in-the-middle', () => { - test('onlyIncludeInstrumentedModules', done => { - const runner = createRunner(__dirname, 'app.mjs').start(() => { - runner.getLogs().forEach(logMsg => { - expect(logMsg).not.toContain('should be the only hooked modules but we just hooked'); - }); - done(); - }); + test('onlyIncludeInstrumentedModules', () => { + const result = spawnSync('node', [join(__dirname, 'app.mjs')], { encoding: 'utf-8' }); + expect(result.stderr).not.toMatch('should be the only hooked modules but we just hooked'); }); });