From 1e0af43f3dd1bccd09123b474985361becca0600 Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Mon, 7 Aug 2023 18:51:49 +0200 Subject: [PATCH 1/2] add RTR job --- .github/workflows/build.yml | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 38de22f0868b..49e4502869f9 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -921,3 +921,14 @@ jobs: with: name: ${{ steps.process.outputs.artifactName }} path: ${{ steps.process.outputs.artifactPath }} + + job_ready_to_release: + name: Ready to release + needs: [job_required_tests, job_artifacts, job_size_check, job_lint, job_circular_dep_check] + if: needs.job_get_metadata.outputs.is_release == 'true' + runs-on: ubuntu-20.04 + steps: + - name: Check for failures + if: contains(needs.*.result, 'failure') + run: | + echo "One of the dependent jobs have failed. You may need to re-run it." && exit 1 From 50d6867291d954aa03acbaa51d6b90d5ac74a0ae Mon Sep 17 00:00:00 2001 From: Lukas Stracke Date: Tue, 8 Aug 2023 10:54:49 +0200 Subject: [PATCH 2/2] remove RTR, adjust required_jobs_passed --- .github/workflows/build.yml | 18 +++++------------- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 49e4502869f9..4cfa56ec640e 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -855,8 +855,8 @@ jobs: timeout-minutes: 5 run: yarn test:assert - job_required_tests: - name: All required tests passed or skipped + job_required_jobs_passed: + name: All required jobs passed or were skipped needs: [ job_build, @@ -870,6 +870,9 @@ jobs: job_browser_loader_tests, job_remix_integration_tests, job_e2e_tests, + job_artifacts, + job_lint, + job_circular_dep_check, ] # Always run this, even if a dependent job failed if: always() @@ -921,14 +924,3 @@ jobs: with: name: ${{ steps.process.outputs.artifactName }} path: ${{ steps.process.outputs.artifactPath }} - - job_ready_to_release: - name: Ready to release - needs: [job_required_tests, job_artifacts, job_size_check, job_lint, job_circular_dep_check] - if: needs.job_get_metadata.outputs.is_release == 'true' - runs-on: ubuntu-20.04 - steps: - - name: Check for failures - if: contains(needs.*.result, 'failure') - run: | - echo "One of the dependent jobs have failed. You may need to re-run it." && exit 1