From 7e10f72e7cafec2c682d94296edb37d5cafc3115 Mon Sep 17 00:00:00 2001 From: Roman Inflianskas Date: Wed, 14 May 2025 12:44:46 +0300 Subject: [PATCH] tests(logs): avoid failures when running with integrations enabled When (at least) one of integrations is enabled (because some dependencies are installed in the environment), `sentry.sdk.name` is changed from `sentry.python` to `sentry.python.[FIRST_ENABLED_INTEGRATION]` which makes `test_logs_attributes` fail. Prevent failure by relaxing the check. This change is beneficial not only for packaging (this patch was required for packaging for Fedora), but also for running tests with `pytest` directly. See also: https://github.com/getsentry/sentry-python/pull/4316 --- tests/test_logs.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/test_logs.py b/tests/test_logs.py index ec8ce917c2..0d4b1adfe6 100644 --- a/tests/test_logs.py +++ b/tests/test_logs.py @@ -447,6 +447,8 @@ def test_logger_with_all_attributes(sentry_init, capture_envelopes): assert isinstance(attributes["thread.name"], str) del attributes["thread.name"] + assert attributes.pop("sentry.sdk.name").startswith("sentry.python") + # Assert on the remaining non-dynamic attributes. assert attributes == { "foo": "bar", @@ -457,7 +459,6 @@ def test_logger_with_all_attributes(sentry_init, capture_envelopes): "sentry.message.template": "log #%d", "sentry.message.parameter.0": 1, "sentry.environment": "production", - "sentry.sdk.name": "sentry.python", "sentry.sdk.version": VERSION, "sentry.severity_number": 13, "sentry.severity_text": "warn",