diff --git a/tests/integrations/socket/test_socket.py b/tests/integrations/socket/test_socket.py index 389256de33..cc109e0968 100644 --- a/tests/integrations/socket/test_socket.py +++ b/tests/integrations/socket/test_socket.py @@ -2,7 +2,9 @@ from sentry_sdk import start_transaction from sentry_sdk.integrations.socket import SocketIntegration -from tests.conftest import ApproxDict +from tests.conftest import ApproxDict, create_mock_http_server + +PORT = create_mock_http_server() def test_getaddrinfo_trace(sentry_init, capture_events): @@ -10,17 +12,17 @@ def test_getaddrinfo_trace(sentry_init, capture_events): events = capture_events() with start_transaction(): - socket.getaddrinfo("example.com", 443) + socket.getaddrinfo("localhost", PORT) (event,) = events (span,) = event["spans"] assert span["op"] == "socket.dns" - assert span["description"] == "example.com:443" + assert span["description"] == f"localhost:{PORT}" # noqa: E231 assert span["data"] == ApproxDict( { - "host": "example.com", - "port": 443, + "host": "localhost", + "port": PORT, } ) @@ -32,28 +34,28 @@ def test_create_connection_trace(sentry_init, capture_events): events = capture_events() with start_transaction(): - socket.create_connection(("example.com", 443), timeout, None) + socket.create_connection(("localhost", PORT), timeout, None) (event,) = events (connect_span, dns_span) = event["spans"] # as getaddrinfo gets called in create_connection it should also contain a dns span assert connect_span["op"] == "socket.connection" - assert connect_span["description"] == "example.com:443" + assert connect_span["description"] == f"localhost:{PORT}" # noqa: E231 assert connect_span["data"] == ApproxDict( { - "address": ["example.com", 443], + "address": ["localhost", PORT], "timeout": timeout, "source_address": None, } ) assert dns_span["op"] == "socket.dns" - assert dns_span["description"] == "example.com:443" + assert dns_span["description"] == f"localhost:{PORT}" # noqa: E231 assert dns_span["data"] == ApproxDict( { - "host": "example.com", - "port": 443, + "host": "localhost", + "port": PORT, } ) @@ -66,7 +68,7 @@ def test_span_origin(sentry_init, capture_events): events = capture_events() with start_transaction(name="foo"): - socket.create_connection(("example.com", 443), 1, None) + socket.create_connection(("localhost", PORT), 1, None) (event,) = events