From 0c9f54c4375f7d8082f420c71fb23f9470af7807 Mon Sep 17 00:00:00 2001 From: Antonis Lilis Date: Wed, 2 Oct 2024 14:28:21 +0300 Subject: [PATCH 1/2] Moves the Optional section above the macOS section for consistency --- CONTRIBUTING.md | 31 ++++++++++++++++--------------- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 7cfeebdde2..f12f7dd3d6 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -91,6 +91,21 @@ yarn react-native run-ios --mode=Release yarn react-native run-android --mode=Release ``` +### Optional + +You can optionally start the Metro bundler if you want to control where it runs: + +```sh +yarn start --reset-cache +``` + +Run the emulators: + +```sh +yarn react-native run-ios +yarn react-native run-android +``` + ## Running the macOS sample Head to the macOS sample root directory: @@ -100,6 +115,7 @@ cd samples/react-native-macos/ yarn bundle install yarn pod-install-legacy +yarn start ``` You can now build and run the project from command line: @@ -111,21 +127,6 @@ or by openning the `samples/react-native-macos/macos/sentry-react-native-sample. _Note that the new architecture is not supported for the macOS sample at this point._ -### Optional - -You can optionally start the Metro bundler if you want to control where it runs: - -```sh -yarn start --reset-cache -``` - -Run the emulators: - -```sh -yarn react-native run-ios -yarn react-native run-android -``` - ## Develop with sentry-cocoa Here are step on how to test your changes in `sentry-cocoa` with `sentry-react-native`. We assume you have both repositories cloned in siblings folders. From c1179930608bb55ef89acd740ab7e9e290386adc Mon Sep 17 00:00:00 2001 From: Antonis Lilis Date: Wed, 2 Oct 2024 15:09:36 +0300 Subject: [PATCH 2/2] Removes the optional section --- CONTRIBUTING.md | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index f12f7dd3d6..8e67889ffa 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -91,21 +91,6 @@ yarn react-native run-ios --mode=Release yarn react-native run-android --mode=Release ``` -### Optional - -You can optionally start the Metro bundler if you want to control where it runs: - -```sh -yarn start --reset-cache -``` - -Run the emulators: - -```sh -yarn react-native run-ios -yarn react-native run-android -``` - ## Running the macOS sample Head to the macOS sample root directory: