From 5d6a4edf45899795e78b64871d2f0bf739bbf7c7 Mon Sep 17 00:00:00 2001 From: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com> Date: Thu, 14 Nov 2024 04:00:58 +0100 Subject: [PATCH 1/2] fix(e2e): Bump tests to iPhone 16 and macos-15 --- .github/workflows/e2e.yml | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index f043c98476..2b496b1858 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -15,7 +15,8 @@ concurrency: env: SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }} MAESTRO_VERSION: '1.39.0' - IOS_DEVICE: 'iPhone 14' + IOS_DEVICE: 'iPhone 16' + IOS_VERSION: '18.1' jobs: diff_check: @@ -157,8 +158,6 @@ jobs: USE_FRAMEWORKS: ${{ matrix.ios-use-frameworks }} PRODUCTION: ${{ matrix.build-type == 'production' && '1' || '0' }} RCT_NEW_ARCH_ENABLED: ${{ matrix.rn-architecture == 'new' && '1' || '0' }} - IOS_RUNTIME: ${{ matrix.runtime }} - IOS_DEVICE: ${{ matrix.device }} strategy: fail-fast: false # keeps matrix running if one fails matrix: @@ -171,12 +170,10 @@ jobs: include: - platform: ios rn-version: '0.76.0' - runs-on: macos-14 # uses m1 https://github.blog/changelog/2024-01-30-github-actions-macos-14-sonoma-is-now-available/ - runtime: 'latest' + runs-on: macos-14 - platform: ios rn-version: '0.65.3' runs-on: macos-13 - runtime: 'latest' - platform: android runs-on: ubuntu-latest exclude: @@ -309,12 +306,10 @@ jobs: include: - platform: ios rn-version: '0.76.0' - runs-on: macos-14 # uses m1 https://github.blog/changelog/2024-01-30-github-actions-macos-14-sonoma-is-now-available/ - runtime: 'latest' + runs-on: macos-15 - platform: ios rn-version: '0.65.3' - runs-on: macos-latest - runtime: 'latest' + runs-on: macos-15 - platform: android runs-on: ubuntu-latest exclude: @@ -408,6 +403,7 @@ jobs: if: ${{ matrix.platform == 'ios' }} with: model: ${{ env.IOS_DEVICE }} + os_version: ${{ env.IOS_VERSION }} - name: Run tests on iOS if: ${{ matrix.platform == 'ios' }} From 8d385a4f4c9ff71c597ad53af23c0c82bdf50def Mon Sep 17 00:00:00 2001 From: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com> Date: Thu, 14 Nov 2024 04:51:07 +0100 Subject: [PATCH 2/2] Update e2e.yml --- .github/workflows/e2e.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index 2b496b1858..be710af944 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -348,7 +348,10 @@ jobs: name: ${{ matrix.rn-version }}-${{ matrix.rn-architecture }}-${{ matrix.engine }}-${{ matrix.platform }}-${{ matrix.build-type }}-${{ matrix.ios-use-frameworks }}-app-package path: dev-packages/e2e-tests - - run: corepack enable + - name: Enable Corepack + run: | + npm install -g corepack@0.29.4 + corepack enable - uses: actions/setup-node@v4 with: node-version: 20