From a6b61ca60047de5aec5341075abc92844942d87f Mon Sep 17 00:00:00 2001 From: avarayr <7735415+avarayr@users.noreply.github.com> Date: Mon, 17 Feb 2025 17:07:14 -0800 Subject: [PATCH 1/3] fix: module Collection Script Fails with Spaces in Node Path --- packages/core/scripts/collect-modules.sh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/core/scripts/collect-modules.sh b/packages/core/scripts/collect-modules.sh index 419d2e4ac2..975a4bb137 100755 --- a/packages/core/scripts/collect-modules.sh +++ b/packages/core/scripts/collect-modules.sh @@ -28,7 +28,7 @@ if [[ -n "$NODE_BINARY" ]]; then nodePath="$NODE_BINARY" fi -thisFilePath=$(dirname $0) +thisFilePath=$(dirname "$0") collectModulesScript="$thisFilePath/../dist/js/tools/collectModules.js" destination="$CONFIGURATION_BUILD_DIR/$UNLOCALIZED_RESOURCES_FOLDER_PATH" @@ -44,11 +44,11 @@ else modulesPaths="$MODULES_PATHS" fi -type $nodePath >/dev/null 2>&1 || { +if ! command -v "$nodePath" >/dev/null 2>&1; then echo >&2 "error: $nodePath not found! Modules won't be collected." \ "Please export NODE_BINARY in 'Build Phase' - 'Bundle React Native code and images'" \ "to an absolute path of your node binary. Check your node path by 'which node'." exit 0 # Don't fail the build but inform about the problem -} +fi -$nodePath "$collectModulesScript" "$sourceMap" "$modulesOutput" "$modulesPaths" +"$nodePath" "$collectModulesScript" "$sourceMap" "$modulesOutput" "$modulesPaths" From eb67117f146a784f946374b75df1039ebe7ad684 Mon Sep 17 00:00:00 2001 From: avarayr <7735415+avarayr@users.noreply.github.com> Date: Mon, 17 Feb 2025 21:09:24 -0800 Subject: [PATCH 2/3] Update CHANGELOG.md --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 19be3a0f11..1cf3278910 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -25,6 +25,7 @@ } ], ``` +- Sentry Module Collection Script Fails with Spaces in Node Path on iOS ([#4559](https://github.com/getsentry/sentry-react-native/pull/4559)) To learn more about the available configuration options visit [the documentation](https://docs.sentry.io/platforms/react-native/manual-setup/expo/expo-sagp/). From 70ba4772d9e9b9d87e579d31f018d4414613cf3b Mon Sep 17 00:00:00 2001 From: Krystof Woldrich <31292499+krystofwoldrich@users.noreply.github.com> Date: Wed, 19 Feb 2025 16:27:24 +0100 Subject: [PATCH 3/3] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1cf3278910..91dcbe7973 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -25,12 +25,12 @@ } ], ``` -- Sentry Module Collection Script Fails with Spaces in Node Path on iOS ([#4559](https://github.com/getsentry/sentry-react-native/pull/4559)) To learn more about the available configuration options visit [the documentation](https://docs.sentry.io/platforms/react-native/manual-setup/expo/expo-sagp/). ### Fixes +- Sentry Module Collection Script Fails with Spaces in Node Path on iOS ([#4559](https://github.com/getsentry/sentry-react-native/pull/4559)) - Various crashes and issues of Session Replay on Android. See the Android SDK version bump for more details. ([#4529](https://github.com/getsentry/sentry-react-native/pull/4529)) ### Dependencies