Skip to content

Commit db37bc0

Browse files
cursoragentarmenzg
andcommitted
fix(traceSummary): Move size prop to correct FeedbackButton branch
The second FeedbackButton instance had size='xs' on the wrong conditional branch. The TopBar.Slot branch should omit the size prop to inherit from SizeContext, while the fallback branch needs size='xs' for backward compatibility. Co-authored-by: Armen Zambrano G. <armenzg@users.noreply.github.com>
1 parent 617ff8f commit db37bc0

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

static/app/views/performance/newTraceDetails/traceSummary.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,6 @@ export function TraceSummarySection({traceSlug}: {traceSlug: string}) {
185185
{hasPageFrameFeature ? (
186186
<TopBar.Slot name="feedback">
187187
<FeedbackButton
188-
size="xs"
189188
feedbackOptions={{
190189
messagePlaceholder: t(
191190
'How can we make the trace summary better for you?'
@@ -201,6 +200,7 @@ export function TraceSummarySection({traceSlug}: {traceSlug: string}) {
201200
</TopBar.Slot>
202201
) : (
203202
<FeedbackButton
203+
size="xs"
204204
feedbackOptions={{
205205
messagePlaceholder: t(
206206
'How can we make the trace summary better for you?'

0 commit comments

Comments
 (0)