From 1d08ff03edcb8536d87295341dd3075687577ee2 Mon Sep 17 00:00:00 2001 From: Krithik Ravindran Date: Mon, 6 Apr 2026 13:29:14 -0700 Subject: [PATCH 1/4] added data category constant for trace metric byte --- static/gsApp/constants.tsx | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/static/gsApp/constants.tsx b/static/gsApp/constants.tsx index 57652941d53347..00998ca509ab9a 100644 --- a/static/gsApp/constants.tsx +++ b/static/gsApp/constants.tsx @@ -196,6 +196,13 @@ export const BILLED_DATA_CATEGORY_INFO = { ), shortenedUnitName: 'GB', }, + [DataCategoryExact.TRACE_METRIC_BYTE]: { + ...DEFAULT_BILLED_DATA_CATEGORY_INFO[DataCategoryExact.TRACE_METRIC_BYTE], + canProductTrial: true, + freeEventsMultiple: 1, + feature: 'expose-category-trace-metric-byte', + shortenedUnitName: 'GB', + }, [DataCategoryExact.SEER_USER]: { ...DEFAULT_BILLED_DATA_CATEGORY_INFO[DataCategoryExact.SEER_USER], feature: 'seer-user-billing-launch', From 643b475ab54916ad9d3a829f44bce22a72668a60 Mon Sep 17 00:00:00 2001 From: Krithik Ravindran Date: Mon, 6 Apr 2026 13:50:27 -0700 Subject: [PATCH 2/4] flipped billed category to true for installable and trace metrics, updated tests --- static/app/constants/index.tsx | 4 ++-- static/gsApp/components/productSelectionAvailability.spec.tsx | 2 ++ static/gsApp/components/productUnavailableCTA.spec.tsx | 2 ++ .../gsApp/components/upgradeNowModal/usePreviewData.spec.tsx | 2 ++ .../gsApp/components/upgradeNowModal/useUpgradeNowParams.tsx | 2 ++ 5 files changed, 10 insertions(+), 2 deletions(-) diff --git a/static/app/constants/index.tsx b/static/app/constants/index.tsx index 583236a1bd4b99..2998f0d53bf14e 100644 --- a/static/app/constants/index.tsx +++ b/static/app/constants/index.tsx @@ -653,7 +653,7 @@ export const DATA_CATEGORY_INFO = { titleName: t('Metrics (Bytes)'), productName: t('Metrics'), uid: 37, - isBilledCategory: false, + isBilledCategory: true, statsInfo: { ...DEFAULT_STATS_INFO, showExternalStats: true, @@ -698,7 +698,7 @@ export const DATA_CATEGORY_INFO = { titleName: t('Build Distributions'), productName: t('Build Distribution'), uid: 36, - isBilledCategory: false, + isBilledCategory: true, statsInfo: {...DEFAULT_STATS_INFO, showExternalStats: true}, formatting: DEFAULT_COUNT_FORMATTING, }, diff --git a/static/gsApp/components/productSelectionAvailability.spec.tsx b/static/gsApp/components/productSelectionAvailability.spec.tsx index b619008b52b58d..163af192cc2432 100644 --- a/static/gsApp/components/productSelectionAvailability.spec.tsx +++ b/static/gsApp/components/productSelectionAvailability.spec.tsx @@ -351,6 +351,8 @@ describe('ProductSelectionAvailability', () => { reservedSeerScanner: undefined, reservedSeerUsers: undefined, reservedSizeAnalyses: 0, + reservedInstallableBuilds: 0, + reservedTraceMetricBytes: 0, }; const mockPlan = PlanFixture({}); const mockPreview = PreviewDataFixture({}); diff --git a/static/gsApp/components/productUnavailableCTA.spec.tsx b/static/gsApp/components/productUnavailableCTA.spec.tsx index 35785e0bc587d5..d7f255248168f6 100644 --- a/static/gsApp/components/productUnavailableCTA.spec.tsx +++ b/static/gsApp/components/productUnavailableCTA.spec.tsx @@ -219,6 +219,8 @@ describe('ProductUnavailableCTA', () => { reservedSeerScanner: undefined, reservedSeerUsers: undefined, reservedSizeAnalyses: undefined, + reservedInstallableBuilds: undefined, + reservedTraceMetricBytes: undefined, }; const mockPlan = PlanFixture({}); const mockPreview = PreviewDataFixture({}); diff --git a/static/gsApp/components/upgradeNowModal/usePreviewData.spec.tsx b/static/gsApp/components/upgradeNowModal/usePreviewData.spec.tsx index 2bb679032fc052..5b97079b9e03d2 100644 --- a/static/gsApp/components/upgradeNowModal/usePreviewData.spec.tsx +++ b/static/gsApp/components/upgradeNowModal/usePreviewData.spec.tsx @@ -26,6 +26,8 @@ const mockReservations: Reservations = { reservedSeerScanner: 0, reservedSeerUsers: 0, reservedSizeAnalyses: 100, + reservedInstallableBuilds: 25000, + reservedTraceMetricBytes: undefined, }; const mockPreview = PreviewDataFixture({}); diff --git a/static/gsApp/components/upgradeNowModal/useUpgradeNowParams.tsx b/static/gsApp/components/upgradeNowModal/useUpgradeNowParams.tsx index 1d934da6b77421..4e382933e4f34d 100644 --- a/static/gsApp/components/upgradeNowModal/useUpgradeNowParams.tsx +++ b/static/gsApp/components/upgradeNowModal/useUpgradeNowParams.tsx @@ -108,6 +108,8 @@ export function useUpgradeNowParams({organization, subscription, enabled = true} reservedSeerScanner: reserved.seerScanner, reservedSeerUsers: reserved.seerUsers, reservedSizeAnalyses: reserved.sizeAnalyses, + reservedInstallableBuilds: reserved.installableBuilds, + reservedTraceMetricBytes: reserved.traceMetricBytes, }, }; }, [billingConfig, isPending, subscription, enabled]); From 7979d70de77c87628bac31fb0e41bffd5c06a745 Mon Sep 17 00:00:00 2001 From: Krithik Ravindran Date: Mon, 6 Apr 2026 13:58:34 -0700 Subject: [PATCH 3/4] fixed test --- .../components/upgradeNowModal/useUpgradeNowParams.spec.tsx | 2 ++ 1 file changed, 2 insertions(+) diff --git a/static/gsApp/components/upgradeNowModal/useUpgradeNowParams.spec.tsx b/static/gsApp/components/upgradeNowModal/useUpgradeNowParams.spec.tsx index 828c9378007283..607d5fed72f067 100644 --- a/static/gsApp/components/upgradeNowModal/useUpgradeNowParams.spec.tsx +++ b/static/gsApp/components/upgradeNowModal/useUpgradeNowParams.spec.tsx @@ -59,6 +59,8 @@ describe('useUpgradeNowParams', () => { reservedSeerScanner: 0, reservedSeerUsers: 0, reservedSizeAnalyses: 100, + reservedInstallableBuilds: 25000, + reservedTraceMetricBytes: undefined, }, }) ); From 7f313175bde50a0f7c2356d54f4385a89b1dc9ec Mon Sep 17 00:00:00 2001 From: Krithik Ravindran Date: Mon, 6 Apr 2026 14:17:41 -0700 Subject: [PATCH 4/4] removed installable changes --- static/app/constants/index.tsx | 2 +- static/gsApp/components/productSelectionAvailability.spec.tsx | 1 - static/gsApp/components/productUnavailableCTA.spec.tsx | 1 - static/gsApp/components/upgradeNowModal/usePreviewData.spec.tsx | 1 - .../components/upgradeNowModal/useUpgradeNowParams.spec.tsx | 1 - static/gsApp/components/upgradeNowModal/useUpgradeNowParams.tsx | 1 - 6 files changed, 1 insertion(+), 6 deletions(-) diff --git a/static/app/constants/index.tsx b/static/app/constants/index.tsx index 2998f0d53bf14e..8630a1b79ae4b5 100644 --- a/static/app/constants/index.tsx +++ b/static/app/constants/index.tsx @@ -698,7 +698,7 @@ export const DATA_CATEGORY_INFO = { titleName: t('Build Distributions'), productName: t('Build Distribution'), uid: 36, - isBilledCategory: true, + isBilledCategory: false, statsInfo: {...DEFAULT_STATS_INFO, showExternalStats: true}, formatting: DEFAULT_COUNT_FORMATTING, }, diff --git a/static/gsApp/components/productSelectionAvailability.spec.tsx b/static/gsApp/components/productSelectionAvailability.spec.tsx index 163af192cc2432..d8fc54448b91e3 100644 --- a/static/gsApp/components/productSelectionAvailability.spec.tsx +++ b/static/gsApp/components/productSelectionAvailability.spec.tsx @@ -351,7 +351,6 @@ describe('ProductSelectionAvailability', () => { reservedSeerScanner: undefined, reservedSeerUsers: undefined, reservedSizeAnalyses: 0, - reservedInstallableBuilds: 0, reservedTraceMetricBytes: 0, }; const mockPlan = PlanFixture({}); diff --git a/static/gsApp/components/productUnavailableCTA.spec.tsx b/static/gsApp/components/productUnavailableCTA.spec.tsx index d7f255248168f6..63792a6c5c69cc 100644 --- a/static/gsApp/components/productUnavailableCTA.spec.tsx +++ b/static/gsApp/components/productUnavailableCTA.spec.tsx @@ -219,7 +219,6 @@ describe('ProductUnavailableCTA', () => { reservedSeerScanner: undefined, reservedSeerUsers: undefined, reservedSizeAnalyses: undefined, - reservedInstallableBuilds: undefined, reservedTraceMetricBytes: undefined, }; const mockPlan = PlanFixture({}); diff --git a/static/gsApp/components/upgradeNowModal/usePreviewData.spec.tsx b/static/gsApp/components/upgradeNowModal/usePreviewData.spec.tsx index 5b97079b9e03d2..c771d6db5222a2 100644 --- a/static/gsApp/components/upgradeNowModal/usePreviewData.spec.tsx +++ b/static/gsApp/components/upgradeNowModal/usePreviewData.spec.tsx @@ -26,7 +26,6 @@ const mockReservations: Reservations = { reservedSeerScanner: 0, reservedSeerUsers: 0, reservedSizeAnalyses: 100, - reservedInstallableBuilds: 25000, reservedTraceMetricBytes: undefined, }; diff --git a/static/gsApp/components/upgradeNowModal/useUpgradeNowParams.spec.tsx b/static/gsApp/components/upgradeNowModal/useUpgradeNowParams.spec.tsx index 607d5fed72f067..e11edfd1694495 100644 --- a/static/gsApp/components/upgradeNowModal/useUpgradeNowParams.spec.tsx +++ b/static/gsApp/components/upgradeNowModal/useUpgradeNowParams.spec.tsx @@ -59,7 +59,6 @@ describe('useUpgradeNowParams', () => { reservedSeerScanner: 0, reservedSeerUsers: 0, reservedSizeAnalyses: 100, - reservedInstallableBuilds: 25000, reservedTraceMetricBytes: undefined, }, }) diff --git a/static/gsApp/components/upgradeNowModal/useUpgradeNowParams.tsx b/static/gsApp/components/upgradeNowModal/useUpgradeNowParams.tsx index 4e382933e4f34d..d02c2a6de0b12a 100644 --- a/static/gsApp/components/upgradeNowModal/useUpgradeNowParams.tsx +++ b/static/gsApp/components/upgradeNowModal/useUpgradeNowParams.tsx @@ -108,7 +108,6 @@ export function useUpgradeNowParams({organization, subscription, enabled = true} reservedSeerScanner: reserved.seerScanner, reservedSeerUsers: reserved.seerUsers, reservedSizeAnalyses: reserved.sizeAnalyses, - reservedInstallableBuilds: reserved.installableBuilds, reservedTraceMetricBytes: reserved.traceMetricBytes, }, };