Skip to content

fix(overlay): Open overlay on Ctrl+F12 instead of Ctrl/Cmd+Shift+F12#224

Merged
Lms24 merged 1 commit into
mainfrom
lms/fix-overlay-open-key-combination
Dec 5, 2023
Merged

fix(overlay): Open overlay on Ctrl+F12 instead of Ctrl/Cmd+Shift+F12#224
Lms24 merged 1 commit into
mainfrom
lms/fix-overlay-open-key-combination

Conversation

@Lms24
Copy link
Copy Markdown
Member

@Lms24 Lms24 commented Dec 5, 2023

closes #218

For now we ignore the MacOS Command key as it requires more modifications to our keypress handler

Before opening this PR:

  • I added a Changeset Entry with pnpm changeset:add
  • I referenced issues that this PR addresses

@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spotlightjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2023 9:56am

@Lms24 Lms24 merged commit d3d1770 into main Dec 5, 2023
@Lms24 Lms24 deleted the lms/fix-overlay-open-key-combination branch December 5, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spotlight hijacking common hotkey

1 participant