feat: Dependency-inject custom logger into sidecar#226
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Lms24
commented
Dec 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #201
This PR adjusts
setupSidecartooptionsobject instead of just the port numberFurthermore, this PR:
Ultimately, this PR also demots some log/info level logs about receiving and forwarding events to a
debuglevel. In Astro this hides the logs by default. For other plaftorms falling back to the default logger, we probably need to add adebugflag or something later onBefore opening this PR:
pnpm changeset:add