chore: use ncc to replace grunt-browserify#1
Conversation
| <script type="text/javascript" src="https://cdnjs.cloudflare.com/ajax/libs/lodash.js/3.10.1/lodash.js"></script> | ||
| <script type="text/javascript" src="https://cdnjs.cloudflare.com/ajax/libs/jszip/2.5.0/jszip.min.js"></script> | ||
| <script type="text/javascript" src="../dist/excel-builder.dist.js"></script> | ||
| <script type="text/javascript" src="../dist/index.js"></script> |
There was a problem hiding this comment.
Sorry, direct loading here would not work. Because ncc only builds commonjs dist file, not umd.
Probably can remove the whole demo/ folder from this repo.
|
@3cp so I took a quick look at the PR and I see you deleted a few files, it looks like the old grunt files, and there's no compiled dist. I never used Also on npm I see the following |
|
Oh, thx. I will clean it up. |
|
Cleaned up. Alternatively, you can add |
| "homepage": "http://excelbuilderjs.com/", | ||
| "devDependencies": { | ||
| "@vercel/ncc": "^0.24.0" | ||
| "@vercel/ncc": "^0.23.0" |
There was a problem hiding this comment.
@3cp isn't this still going to get latest minor and so 0.24.0? I think we should remove the caret or use ~0.23.0 instead
There was a problem hiding this comment.
Semver has special rule for major version 0, aka pre production.
When major is 0, it treats minor versions (instead normally majors) as breaking change. "^0.23.0" would never match 0.24.x.
There was a problem hiding this comment.
oh ok I didn't know this special rule, thanks for clarifying, I'll merge as is then, it's safe anyway since you already provided the compiled file. Thanks
2 participants
Partly address ghiscoding/aurelia-slickgrid-demos#2