feat: add support to use placement group in launch template #4929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edersonbrilhante
force-pushed
the
feat-placement
branch
2 times, most recently
from
c50f557 to
03c78ee
Compare
npalm
reviewed
Dec 6, 2025
| placement = optional(object({ | ||
| affinity = optional(string) | ||
| availability_zone = optional(string) | ||
| # group_id = try(placement.value.group_id, null) # aws >= 6.12.0 |
Member
There was a problem hiding this comment.
Why is the comment. Requiring a newer version of the provider?
Contributor
Author
There was a problem hiding this comment.
The provider aws also allow to use group ID in placement, but only not in all versions. I left the commented so it can be added in the future. I can remove if is misleading
Member
There was a problem hiding this comment.
I will release next week a new major version, including bump of aws provider, and update to node24. You could update the PR to merge in next instead of main.
Contributor
Author
There was a problem hiding this comment.
Sure thing.
edersonbrilhante
force-pushed
the
feat-placement
branch
from
bea36d0 to
9f79d06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for configuring EC2 placement groups for GitHub Actions runners in the multi-runner module. It plumbs a new placement option from the runner configuration through to the underlying EC2 runner module.
Details
Updated modules/multi-runner/runners.tf to pass placement = each.value.runner_config.placement into the runners module.
This allows specifying AWS placement groups for EC2 runners, enabling tighter control over instance placement.
The change is backwards compatible: if placement is unset in runner_config, behavior remains unchanged.
Motivation / Future work
Placement groups are a prerequisite for supporting macOS runners, which require a host_id.
A follow-up PR will add explicit macOS support leveraging this new placement wiring.