From e49d090fd5b4751675cfda6c5054a848385992ba Mon Sep 17 00:00:00 2001 From: Stanley Goldman Date: Thu, 19 Oct 2017 12:25:58 -0400 Subject: [PATCH 1/3] Adding missing OnEnable/OnDisable --- .../Editor/GitHub.Unity/UI/InitProjectView.cs | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/InitProjectView.cs b/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/InitProjectView.cs index ec20862dd..9bc4db72b 100644 --- a/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/InitProjectView.cs +++ b/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/InitProjectView.cs @@ -29,6 +29,20 @@ public override void OnDataUpdate() gitPathView.OnDataUpdate(); } + public override void OnEnable() + { + base.OnEnable(); + userSettingsView.OnEnable(); + gitPathView.OnEnable(); + } + + public override void OnDisable() + { + base.OnDisable(); + userSettingsView.OnDisable(); + gitPathView.OnDisable(); + } + public override void OnGUI() { var headerRect = EditorGUILayout.BeginHorizontal(Styles.HeaderBoxStyle); From 0a7ede0a061427d049028814f0a3c83fa018be9f Mon Sep 17 00:00:00 2001 From: Stanley Goldman Date: Thu, 19 Oct 2017 12:29:25 -0400 Subject: [PATCH 2/3] Code nitpick --- .../Assets/Editor/GitHub.Unity/UI/InitProjectView.cs | 1 - 1 file changed, 1 deletion(-) diff --git a/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/InitProjectView.cs b/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/InitProjectView.cs index 9bc4db72b..b3f424534 100644 --- a/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/InitProjectView.cs +++ b/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/InitProjectView.cs @@ -24,7 +24,6 @@ public override void InitializeView(IView parent) public override void OnDataUpdate() { base.OnDataUpdate(); - userSettingsView.OnDataUpdate(); gitPathView.OnDataUpdate(); } From 33fb66b2648eca076a692b9e8617d4b72c197c1b Mon Sep 17 00:00:00 2001 From: Stanley Goldman Date: Thu, 19 Oct 2017 15:13:05 -0400 Subject: [PATCH 3/3] Removing unused overloads and calls --- .../Assets/Editor/GitHub.Unity/UI/InitProjectView.cs | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/InitProjectView.cs b/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/InitProjectView.cs index b3f424534..eb78b5ee0 100644 --- a/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/InitProjectView.cs +++ b/src/UnityExtension/Assets/Editor/GitHub.Unity/UI/InitProjectView.cs @@ -31,17 +31,9 @@ public override void OnDataUpdate() public override void OnEnable() { base.OnEnable(); - userSettingsView.OnEnable(); gitPathView.OnEnable(); } - public override void OnDisable() - { - base.OnDisable(); - userSettingsView.OnDisable(); - gitPathView.OnDisable(); - } - public override void OnGUI() { var headerRect = EditorGUILayout.BeginHorizontal(Styles.HeaderBoxStyle);